setup-build: Add more logging

Author: Steelskin

.github/actions/setup-build/action.yml

@@ -136,6 +136,7 @@ runs:
               -PassThru `
               -ArgumentList "modify", `
                   "--noUpdateInstaller", `
+                  "--log", "${env:TEMP}\vs_installer_log_winsdk.log", `
                   "--installPath", "`"$InstallPath`"", `
                   "--channelId", "https://aka.ms/vs/17/release/channel", `
                   "--quiet", "--norestart", "--nocache", `
@@ -146,8 +147,6 @@ runs:
             Write-Output "ℹ️ Windows SDK ${WinSdkVersionString} installed successfully."
           } else {
             Write-Output "::error::Failed to install Windows SDK ${WinSdkVersionString}. Check the installer log for details."
-            $LogFile = Get-ChildItem "${env:TEMP}" -Filter "dd_installer_*.log" | Sort-Object LastWriteTime -Descending | Select-Object -First 1
-            "log-file=$($LogFile.FullName)" | Out-File -FilePath $env:GITHUB_OUTPUT -Encoding utf8 -Append
             exit 1
           }
         }
@@ -172,11 +171,11 @@ runs:
         }
 
     - name: Upload installer log
-      if: always() && steps.setup-windows-sdk.outputs.log-file != ''
+      if: always() && steps.setup-windows-sdk.outcome == 'failure'
       uses: actions/upload-artifact@v4
       with:
         name: ${{ github.job }}-windows-sdk-installer-log
-        path: ${{ steps.setup-windows-sdk.outputs.log-file }}
+        path: ${{ env.TEMP }}/vs_installer_log_winsdk.log"
 
     - name: Install Windows MSVC version ${{ inputs.msvc-version }}
       if: steps.sanitize-input.outputs.build-os == 'windows' && inputs.msvc-version != ''
@@ -234,20 +233,18 @@ runs:
 
         if ($MSVCBuildToolsVersion -eq "") {
           Write-Output "::error::Failed to install MSVC ${MSVCVersionString}. Check the installer log for details."
-          $LogFile = Get-ChildItem "${env:TEMP}" -Filter "dd_installer_*.log" | Sort-Object LastWriteTime -Descending | Select-Object -First 1
-          "log-file=$($LogFile.FullName)" | Out-File -FilePath $env:GITHUB_OUTPUT -Encoding utf8 -Append
           exit 1
         } else {
           Write-Output "ℹ️ MSVC ${MSVCBuildToolsVersion} installed successfully."
           "windows-build-tools-version=${MSVCBuildToolsVersion}" | Out-File -FilePath $env:GITHUB_OUTPUT -Encoding utf8 -Append
         }
 
     - name: Upload installer log
-      if: always() && steps.setup-msvc.outputs.log-file != ''
+      if: always() && steps.setup-msvc.outcome == 'failure'
       uses: actions/upload-artifact@v4
       with:
         name: ${{ github.job }}-msvc-installer-log
-        path: ${{ steps.setup-msvc.outputs.log-file }}
+        path: ${{ env.TEMP }}/vs_installer_log_msvc.log"
 
     - name: Setup Visual Studio Developer Environment
       if: steps.sanitize-input.outputs.build-os == 'windows' && inputs.setup-vs-dev-env == 'true'