refactor alert controller

Author: mikhailChelbaev

Sources/ComponentsKit/Components/Alert/UKAlertController.swift

@@ -1,6 +1,8 @@
 import UIKit
 
 public class UKAlertController: UKCenterModalController {
+  public let alertVM: AlertVM
+
   public let titleLabel = UILabel()
   public let subtitleLabel = UILabel()
   public let primaryButton = UKButton()
@@ -15,45 +17,38 @@ public class UKAlertController: UKCenterModalController {
     primaryAction: (() -> Void)? = nil,
     secondaryAction: (() -> Void)? = nil
   ) {
+    self.alertVM = model
+
     self.primaryAction = primaryAction
     self.secondaryAction = secondaryAction
 
-    super.init(
-      model: model.modalVM,
-      body: { _ in UILabel() }
-    )
+    super.init(model: model.modalVM)
+  }
+
+  required public init?(coder: NSCoder) {
+    fatalError("init(coder:) has not been implemented")
+  }
 
-    if model.title.isNotNilAndEmpty && model.message.isNotNilAndEmpty {
+  public override func setup() {
+    if self.alertVM.title.isNotNilAndEmpty,
+       self.alertVM.message.isNotNilAndEmpty {
       self.header = self.titleLabel
       self.body = self.subtitleLabel
-    } else if model.title.isNotNilAndEmpty {
+    } else if self.alertVM.title.isNotNilAndEmpty {
       self.body = self.titleLabel
     } else {
       self.body = self.subtitleLabel
     }
-
-    if model.primaryButton.isNotNil || model.secondaryButton.isNotNil {
+    if self.alertVM.primaryButton.isNotNil || self.alertVM.secondaryButton.isNotNil {
       self.footer = self.buttonsStackView
     }
 
-    self.titleLabel.text = model.title
-    self.subtitleLabel.text = model.message
-    if let primaryButtonVM = model.primaryButtonVM {
+    if self.alertVM.primaryButton.isNotNil {
       self.buttonsStackView.addArrangedSubview(self.primaryButton)
-      self.primaryButton.model = primaryButtonVM
     }
-    if let secondaryButtonVM = model.secondaryButtonVM {
+    if self.alertVM.secondaryButton.isNotNil {
       self.buttonsStackView.addArrangedSubview(self.secondaryButton)
-      self.secondaryButton.model = secondaryButtonVM
     }
-  }
-
-  required public init?(coder: NSCoder) {
-    fatalError("init(coder:) has not been implemented")
-  }
-
-  public override func setup() {
-    super.setup()
 
     self.primaryButton.action = { [weak self] in
       self?.primaryAction?()
@@ -63,14 +58,26 @@ public class UKAlertController: UKCenterModalController {
       self?.secondaryAction?()
       self?.dismiss(animated: true)
     }
+
+    // NOTE: Labels and stack view should be assigned to `header`, `body`
+    // and `footer` before calling the superview's method, otherwise they
+    // won't be added to the list of subviews.
+    super.setup()
   }
 
   public override func style() {
     super.style()
 
-    Self.Style.titleLabel(self.titleLabel)
-    Self.Style.subtitleLabel(self.subtitleLabel)
+    Self.Style.titleLabel(self.titleLabel, text: self.alertVM.title)
+    Self.Style.subtitleLabel(self.subtitleLabel, text: self.alertVM.message)
     Self.Style.buttonsStackView(self.buttonsStackView)
+
+    if let primaryButtonVM = self.alertVM.primaryButtonVM {
+      self.primaryButton.model = primaryButtonVM
+    }
+    if let secondaryButtonVM = self.alertVM.secondaryButtonVM {
+      self.secondaryButton.model = secondaryButtonVM
+    }
   }
 
   public override func updateViewConstraints() {
@@ -111,14 +118,16 @@ public class UKAlertController: UKCenterModalController {
 
 extension UKAlertController {
   fileprivate enum Style {
-    static func titleLabel(_ label: UILabel) {
+    static func titleLabel(_ label: UILabel, text: String?) {
+      label.text = text
       label.font = UniversalFont.mdHeadline.uiFont
       label.textColor = UniversalColor.foreground.uiColor
       label.textAlignment = .center
       label.numberOfLines = 0
     }
 
-    static func subtitleLabel(_ label: UILabel) {
+    static func subtitleLabel(_ label: UILabel, text: String?) {
+      label.text = text
       label.font = UniversalFont.mdBody.uiFont
       label.textColor = UniversalColor.secondaryForeground.uiColor
       label.textAlignment = .center

Sources/ComponentsKit/Components/Modal/UIKit/UKBottomModalController.swift

@@ -38,13 +38,23 @@ public class UKBottomModalController: UKModalController<BottomModalVM> {
   ///   - header: An optional content block for the modal's header.
   ///   - body: The main content block for the modal.
   ///   - footer: An optional content block for the modal's footer.
-  public override init(
+  public init(
     model: BottomModalVM = .init(),
     header: Content? = nil,
     body: Content,
     footer: Content? = nil
   ) {
-    super.init(model: model, header: header, body: body, footer: footer)
+    super.init(model: model)
+
+    self.header = header?({ [weak self] animated in
+      self?.dismiss(animated: animated)
+    })
+    self.body = body({ [weak self] animated in
+      self?.dismiss(animated: animated)
+    })
+    self.footer = footer?({ [weak self] animated in
+      self?.dismiss(animated: animated)
+    })
   }
 
   required public init?(coder: NSCoder) {

Sources/ComponentsKit/Components/Modal/UIKit/UKCenterModalController.swift

@@ -38,13 +38,27 @@ public class UKCenterModalController: UKModalController<CenterModalVM> {
   ///   - header: An optional content block for the modal's header.
   ///   - body: The main content block for the modal.
   ///   - footer: An optional content block for the modal's footer.
-  public override init(
+  public init(
     model: CenterModalVM = .init(),
     header: Content? = nil,
     body: Content,
     footer: Content? = nil
   ) {
-    super.init(model: model, header: header, body: body, footer: footer)
+    super.init(model: model)
+
+    self.header = header?({ [weak self] animated in
+      self?.dismiss(animated: animated)
+    })
+    self.body = body({ [weak self] animated in
+      self?.dismiss(animated: animated)
+    })
+    self.footer = footer?({ [weak self] animated in
+      self?.dismiss(animated: animated)
+    })
+  }
+
+  override init(model: CenterModalVM) {
+    super.init(model: model)
   }
 
   required public init?(coder: NSCoder) {

Sources/ComponentsKit/Components/Modal/UIKit/UKModalController.swift

@@ -31,12 +31,7 @@ open class UKModalController<VM: ModalVM>: UIViewController {
 
   // MARK: - Initialization
 
-  init(
-    model: VM = .init(),
-    header: Content? = nil,
-    body: Content,
-    footer: Content? = nil
-  ) {
+  init(model: VM) {
     self.model = model
 
     switch model.overlayStyle {
@@ -48,16 +43,6 @@ open class UKModalController<VM: ModalVM>: UIViewController {
 
     super.init(nibName: nil, bundle: nil)
 
-    self.header = header?({ [weak self] animated in
-      self?.dismiss(animated: animated)
-    })
-    self.body = body({ [weak self] animated in
-      self?.dismiss(animated: animated)
-    })
-    self.footer = footer?({ [weak self] animated in
-      self?.dismiss(animated: animated)
-    })
-
     self.modalPresentationStyle = .overFullScreen
     self.modalTransitionStyle = .crossDissolve
   }