Optimize OtherComponent and ProgressIndicator #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the animation of the indeterminate `CircularProgressIndicator` components. - For linear indeterminate progress indicators, the calculation of `progressWidth` is simplified. - For circular indeterminate progress indicators, `rememberInfiniteTransition` and `animateFloat` are now used for smoother and more efficient animations of `rotationAnim` and `sweepAnim`. The `keyframes` animation spec is used for `sweepAnim` to create a more distinct visual effect. - The drawing of end caps for both types of circular progress indicators is simplified by using `StrokeCap.Round`.
# Conflicts: # example/src/commonMain/kotlin/MainPage.kt
YuKongA
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
OtherComponentandProgressIndicatorimplementations, improving composability, performance, and code clarity. Key changes include dividing the single LazyItem inOtherComponentinto multiple, optimizing animation logic inProgressIndicator, and removing redundant code.Refactoring
OtherComponent:OtherComponentfrom a@Composablefunction to aLazyListScopeextension, enabling dynamic item creation and better integration withLazyColumn.FocusManageras a parameter tootherComponent, removing reliance onLocalFocusManagerfor better dependency injection. [1] [2]Enhancements in
ProgressIndicator:LinearProgressIndicatorlogic by removing conditional checks forprogressValue == 0f, reducing unnecessary calculations.CircularProgressIndicatorto userememberInfiniteTransitionfor managing animations, replacing manualAnimatableinstances and improving readability.Code Cleanup:
OtherComponent, streamlining the codebase. [1] [2]ColorPicker, enhancing readability.