Skip to content

Commit f0d27fc

Browse files
committed
make defaultPattern public otherwise ExtractVariables isn't usable
Signed-off-by: Nicolas De Loof <[email protected]>
1 parent d1d5cc9 commit f0d27fc

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

template/template.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ var patternString = fmt.Sprintf(
4444
groupInvalid,
4545
)
4646

47-
var defaultPattern = regexp.MustCompile(patternString)
47+
var DefaultPattern = regexp.MustCompile(patternString)
4848

4949
// InvalidTemplateError is returned when a variable template is not in a valid
5050
// format
@@ -121,7 +121,7 @@ func SubstituteWithOptions(template string, mapping Mapping, options ...Option)
121121
var returnErr error
122122

123123
cfg := &Config{
124-
pattern: defaultPattern,
124+
pattern: DefaultPattern,
125125
replacementFunc: DefaultReplacementFunc,
126126
logging: true,
127127
}
@@ -268,14 +268,14 @@ func getFirstBraceClosingIndex(s string) int {
268268

269269
// Substitute variables in the string with their values
270270
func Substitute(template string, mapping Mapping) (string, error) {
271-
return SubstituteWith(template, mapping, defaultPattern)
271+
return SubstituteWith(template, mapping, DefaultPattern)
272272
}
273273

274274
// ExtractVariables returns a map of all the variables defined in the specified
275275
// composefile (dict representation) and their default value if any.
276276
func ExtractVariables(configDict map[string]interface{}, pattern *regexp.Regexp) map[string]Variable {
277277
if pattern == nil {
278-
pattern = defaultPattern
278+
pattern = DefaultPattern
279279
}
280280
return recurseExtract(configDict, pattern)
281281
}

template/template_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -366,15 +366,15 @@ func TestSubstituteWithCustomFunc(t *testing.T) {
366366
return value, true, nil
367367
}
368368

369-
result, err := SubstituteWith("ok ${FOO}", defaultMapping, defaultPattern, errIsMissing)
369+
result, err := SubstituteWith("ok ${FOO}", defaultMapping, DefaultPattern, errIsMissing)
370370
assert.NilError(t, err)
371371
assert.Check(t, is.Equal("ok first", result))
372372

373-
result, err = SubstituteWith("ok ${BAR}", defaultMapping, defaultPattern, errIsMissing)
373+
result, err = SubstituteWith("ok ${BAR}", defaultMapping, DefaultPattern, errIsMissing)
374374
assert.NilError(t, err)
375375
assert.Check(t, is.Equal("ok ", result))
376376

377-
_, err = SubstituteWith("ok ${NOTHERE}", defaultMapping, defaultPattern, errIsMissing)
377+
_, err = SubstituteWith("ok ${NOTHERE}", defaultMapping, DefaultPattern, errIsMissing)
378378
assert.Check(t, is.ErrorContains(err, "required variable"))
379379
}
380380

@@ -594,7 +594,7 @@ func TestExtractVariables(t *testing.T) {
594594
for _, tc := range testCases {
595595
tc := tc
596596
t.Run(tc.name, func(t *testing.T) {
597-
actual := ExtractVariables(tc.dict, defaultPattern)
597+
actual := ExtractVariables(tc.dict, DefaultPattern)
598598
assert.Check(t, is.DeepEqual(actual, tc.expected))
599599
})
600600
}

0 commit comments

Comments
 (0)