Skip to content

Commit c1c1d6e

Browse files
committed
Slight cleanup and fix test file
1 parent 4396894 commit c1c1d6e

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

ecs_composex/elbv2/elbv2_stack/elbv2.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ def __init__(
6868
self.ingress = None
6969
self.lb_sg = None
7070
self.lb_eips = []
71-
self.unique_service_lb = False
7271
self.lb = None
7372
self.new_listeners: list[ComposeListener] = []
7473
self.lookup_listeners: dict[int, LookupListener] = {}
@@ -91,7 +90,6 @@ def __init__(
9190
self.cloud_control_attributes_mapping = LB_CLOUD_CONTROL_ATTRIBUTES
9291
self.no_allocate_eips: bool = keyisset("NoAllocateEips", self.settings)
9392
self.retain_eips: bool = keyisset("RetainEips", self.settings)
94-
self.validate_services()
9593
self.sort_props()
9694
self.module_name = MOD_KEY
9795
self.ref_parameter = LB_ARN
@@ -284,14 +282,6 @@ def set_services_targets(self, settings):
284282

285283
self.debug_families_targets()
286284

287-
def validate_services(self):
288-
services_names = list(self.services.keys())
289-
if len(services_names) == 1:
290-
LOG.info(
291-
f"LB {self.name} only has a unique service. LB will be deployed with the service stack."
292-
)
293-
self.unique_service_lb = True
294-
295285
def sort_props(self):
296286
self.lb_is_public = (
297287
True

use-cases/warpstream.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,15 @@ x-elbv2:
8888
Settings:
8989
NoAllocateEips: true
9090
Listeners:
91-
- Port: 9092
91+
9092:
9292
Protocol: TLS
9393
Certificates:
9494
- x-acm: warp-cert
9595
Targets:
9696
- name: warp:warp:9092
9797
access: /
9898
Services:
99-
warp:warp:
99+
warp:warp:9092:
100100
port: 9092
101101
protocol: TCP
102102
healthcheck: 9092:TCP:2:2:15:5

0 commit comments

Comments
 (0)