Skip to content

Commit b5b1e1d

Browse files
committed
Fix deprecation warnings, bump CI to php 8.4
1 parent 0c866aa commit b5b1e1d

File tree

7 files changed

+36
-40
lines changed

7 files changed

+36
-40
lines changed

.github/workflows/conductor.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
with:
2323
coverage: "none"
2424
extensions: "intl, zip, apcu"
25-
php-version: "8.3"
25+
php-version: "8.4"
2626

2727
# See the Conductor GitHub Action at https://github.com/packagist/conductor-github-action
2828
- name: "Running Conductor"

.github/workflows/continuous-integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
with:
2222
coverage: "none"
2323
extensions: "intl, zip, apcu"
24-
php-version: "8.3"
24+
php-version: "8.4"
2525
tools: composer
2626
ini-values: apc.enable_cli=1
2727

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
with:
1818
coverage: "none"
1919
extensions: "intl"
20-
php-version: "8.3"
20+
php-version: "8.4"
2121

2222
- name: "Lint PHP files"
2323
run: "find src/ -type f -name '*.php' -print0 | xargs -0 -L1 -P4 -- php -l -f"

.github/workflows/phpstan.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
with:
2222
coverage: "none"
2323
extensions: "intl, zip, apcu"
24-
php-version: "8.3"
24+
php-version: "8.4"
2525
tools: composer
2626
ini-values: apc.enable_cli=1
2727

composer.lock

Lines changed: 30 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Entity/Package.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -696,7 +696,7 @@ public function getType(): string|null
696696
return $this->type;
697697
}
698698

699-
public function getInstallCommand(Version $version = null): string
699+
public function getInstallCommand(Version|null $version = null): string
700700
{
701701
if (in_array($this->getType(), ['php-ext', 'php-ext-zend'], true)) {
702702
return 'pie install '.$this->getName();

src/Model/DownloadManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public function __construct(private Client $redis, private ManagerRegistry $doct
4040
*
4141
* @return array{total: int, monthly: int, daily: float, views?: int}
4242
*/
43-
public function getDownloads(Package|int $package, Version|int $version = null, bool $incrViews = false): array
43+
public function getDownloads(Package|int $package, Version|int|null $version = null, bool $incrViews = false): array
4444
{
4545
if ($package instanceof Package) {
4646
$package = $package->getId();

0 commit comments

Comments
 (0)