Update phpstan

Author: Seldaek

composer.lock

@@ -60,6 +60,36 @@ parameters:
 			count: 1
 			path: src/Package/SymlinkDumper.php
 
+		-
+			message: '#^Parameter \#1 \$conflict of method App\\Entity\\Version\:\:addConflictLink\(\) expects App\\Entity\\ConflictLink, App\\Entity\\ConflictLink\|App\\Entity\\DevRequireLink\|App\\Entity\\ProvideLink\|App\\Entity\\ReplaceLink\|App\\Entity\\RequireLink given\.$#'
+			identifier: argument.type
+			count: 1
+			path: src/Package/Updater.php
+
+		-
+			message: '#^Parameter \#1 \$devRequire of method App\\Entity\\Version\:\:addDevRequireLink\(\) expects App\\Entity\\DevRequireLink, App\\Entity\\ConflictLink\|App\\Entity\\DevRequireLink\|App\\Entity\\ProvideLink\|App\\Entity\\ReplaceLink\|App\\Entity\\RequireLink given\.$#'
+			identifier: argument.type
+			count: 1
+			path: src/Package/Updater.php
+
+		-
+			message: '#^Parameter \#1 \$provide of method App\\Entity\\Version\:\:addProvideLink\(\) expects App\\Entity\\ProvideLink, App\\Entity\\ConflictLink\|App\\Entity\\DevRequireLink\|App\\Entity\\ProvideLink\|App\\Entity\\ReplaceLink\|App\\Entity\\RequireLink given\.$#'
+			identifier: argument.type
+			count: 1
+			path: src/Package/Updater.php
+
+		-
+			message: '#^Parameter \#1 \$replace of method App\\Entity\\Version\:\:addReplaceLink\(\) expects App\\Entity\\ReplaceLink, App\\Entity\\ConflictLink\|App\\Entity\\DevRequireLink\|App\\Entity\\ProvideLink\|App\\Entity\\ReplaceLink\|App\\Entity\\RequireLink given\.$#'
+			identifier: argument.type
+			count: 1
+			path: src/Package/Updater.php
+
+		-
+			message: '#^Parameter \#1 \$require of method App\\Entity\\Version\:\:addRequireLink\(\) expects App\\Entity\\RequireLink, App\\Entity\\ConflictLink\|App\\Entity\\DevRequireLink\|App\\Entity\\ProvideLink\|App\\Entity\\ReplaceLink\|App\\Entity\\RequireLink given\.$#'
+			identifier: argument.type
+			count: 1
+			path: src/Package/Updater.php
+
 		-
 			message: '#^Parameter \#1 \$ids of method App\\Entity\\PackageRepository\:\:getPackagesWithVersions\(\) expects list\<int\>\|null, array\<int\<0, max\>, int\> given\.$#'
 			identifier: argument.type

phpstan-baseline.neon

@@ -128,7 +128,7 @@ public function createPackageAction(Request $request, ProviderManager $providerM
                 $githubUserMigrationWorker->setupWebHook($user->getGithubToken(), $package);
             }
         } catch (\Exception $e) {
-            $this->logger->critical($e->getMessage(), ['exception', $e]);
+            $this->logger->critical('Unable to create package', ['exception' => $e]);
 
             return new JsonResponse(['status' => 'error', 'message' => 'Error saving package'], 500);
         }

src/Controller/ApiController.php

@@ -12,8 +12,13 @@
 
 namespace App\Package;
 
+use App\Entity\ConflictLink;
 use App\Entity\Dependent;
+use App\Entity\DevRequireLink;
 use App\Entity\PackageFreezeReason;
+use App\Entity\ProvideLink;
+use App\Entity\ReplaceLink;
+use App\Entity\RequireLink;
 use App\HtmlSanitizer\ReadmeImageSanitizer;
 use App\HtmlSanitizer\ReadmeLinkSanitizer;
 use App\Util\HttpDownloaderOptionsFactory;
@@ -63,24 +68,34 @@ class Updater
 
     private const SUPPORTED_LINK_TYPES = [
         'require' => [
-            'method' => 'getRequires',
-            'entity' => 'RequireLink',
+            'composer-getter' => 'getRequires',
+            'getter' => 'getRequire',
+            'setter' => 'addRequireLink',
+            'entity' => RequireLink::class,
         ],
         'conflict' => [
-            'method' => 'getConflicts',
-            'entity' => 'ConflictLink',
+            'composer-getter' => 'getConflicts',
+            'getter' => 'getConflict',
+            'setter' => 'addConflictLink',
+            'entity' => ConflictLink::class,
         ],
         'provide' => [
-            'method' => 'getProvides',
-            'entity' => 'ProvideLink',
+            'composer-getter' => 'getProvides',
+            'getter' => 'getProvide',
+            'setter' => 'addProvideLink',
+            'entity' => ProvideLink::class,
         ],
         'replace' => [
-            'method' => 'getReplaces',
-            'entity' => 'ReplaceLink',
+            'composer-getter' => 'getReplaces',
+            'getter' => 'getReplace',
+            'setter' => 'addReplaceLink',
+            'entity' => ReplaceLink::class,
         ],
         'devRequire' => [
-            'method' => 'getDevRequires',
-            'entity' => 'DevRequireLink',
+            'composer-getter' => 'getDevRequires',
+            'getter' => 'getDevRequire',
+            'setter' => 'addDevRequireLink',
+            'entity' => DevRequireLink::class,
         ],
     ];
 
@@ -510,9 +525,9 @@ private function updateInformation(IOInterface $io, VersionRepository $versionRe
         }
 
         // handle links
-        foreach (self::SUPPORTED_LINK_TYPES as $linkType => $opts) {
+        foreach (self::SUPPORTED_LINK_TYPES as $opts) {
             $links = [];
-            foreach ($data->{$opts['method']}() as $link) {
+            foreach ($data->{$opts['composer-getter']}() as $link) {
                 $constraint = $link->getPrettyConstraint();
                 if (false !== strpos($constraint, ',') && false !== strpos($constraint, '@')) {
                     $constraint = Preg::replaceCallbackStrictGroups('{([><]=?\s*[^@]+?)@([a-z]+)}i', static function ($matches) {
@@ -527,10 +542,10 @@ private function updateInformation(IOInterface $io, VersionRepository $versionRe
                 $links[$link->getTarget()] = $constraint;
             }
 
-            foreach ($version->{'get'.$linkType}() as $link) {
+            foreach ($version->{$opts['getter']}() as $link) {
                 // clear links that have changed/disappeared (for updates)
                 if (!isset($links[$link->getPackageName()]) || $links[$link->getPackageName()] !== $link->getPackageVersion()) {
-                    $version->{'get'.$linkType}()->removeElement($link);
+                    $version->{$opts['getter']}()->removeElement($link);
                     $em->remove($link);
                 } else {
                     // clear those that are already set
@@ -539,11 +554,11 @@ private function updateInformation(IOInterface $io, VersionRepository $versionRe
             }
 
             foreach ($links as $linkPackageName => $linkPackageVersion) {
-                $class = 'App\Entity\\'.$opts['entity'];
+                $class = $opts['entity'];
                 $link = new $class;
                 $link->setPackageName((string) $linkPackageName);
                 $link->setPackageVersion($linkPackageVersion);
-                $version->{'add'.$linkType.'Link'}($link);
+                $version->{$opts['setter']}($link);
                 $link->setVersion($version);
                 $em->persist($link);
             }