Add conditional param-out to fix internal returns

Seldaek · Seldaek · commit 3de930c85efd · 2024-03-15T14:28:12.000+01:00
diff --git a/src/Preg.php b/src/Preg.php
@@ -422,7 +422,7 @@ private static function enforceNonNullMatchAll(string $pattern, array $matches,
      * @param int-mask<PREG_UNMATCHED_AS_NULL|PREG_OFFSET_CAPTURE> $flags
      * @return 0|1|false
      *
-     * @param-out array<int|string, string|null> $matches
+     * @param-out ($flags is PREG_OFFSET_CAPTURE ? array<int|string, array{string|null, int<-1, max>}> : array<int|string, string|null>) $matches
      */
     private static function pregMatch(string $pattern, string $subject, ?array &$matches = null, int $flags = 0, int $offset = 0)
     {

Original file line number	Diff line number	Diff line change
`@@ -422,7 +422,7 @@ private static function enforceNonNullMatchAll(string $pattern, array $matches,`
`422`	`422`	`* @param int-mask<PREG_UNMATCHED_AS_NULL\|PREG_OFFSET_CAPTURE> $flags`
`423`	`423`	`* @return 0\|1\|false`
`424`	`424`	`*`
`425`		`- * @param-out array<int\|string, string\|null> $matches`
	`425`	`+ * @param-out ($flags is PREG_OFFSET_CAPTURE ? array<int\|string, array{string\|null, int<-1, max>}> : array<int\|string, string\|null>) $matches`
`426`	`426`	`*/`
`427`	`427`	`private static function pregMatch(string $pattern, string $subject, ?array &$matches = null, int $flags = 0, int $offset = 0)`
`428`	`428`	`{`