CI fixes

Seldaek · Seldaek · commit 68be757204a4 · 2021-12-06T10:50:09.000+01:00
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -53,7 +53,7 @@ jobs:
       - name: "Install latest dependencies"
         run: |
           # Remove PHPStan as it requires a newer PHP
-          composer remove phpstan/phpstan --dev --no-update
+          composer remove phpstan/phpstan phpstan/phpstan-strict-rules --dev --no-update
           composer update ${{ env.COMPOSER_FLAGS }}
 
       - name: "Run tests"
diff --git a/tests/BaseTestCase.php b/tests/BaseTestCase.php
@@ -73,7 +73,7 @@ protected function expectPcreException($pattern, $error = null)
             self::fail('Preg function name is missing');
         }
 
-        if (null !== $error) {
+        if (null === $error) {
             // Only use a message if the error can be reliably determined
             if (PHP_VERSION_ID >= 80000) {
                 $error = 'Internal error';

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ protected function expectPcreException($pattern, $error = null)`
`73`	`73`	`self::fail('Preg function name is missing');`
`74`	`74`	`}`
`75`	`75`
`76`		`- if (null !== $error) {`
	`76`	`+ if (null === $error) {`
`77`	`77`	`// Only use a message if the error can be reliably determined`
`78`	`78`	`if (PHP_VERSION_ID >= 80000) {`
`79`	`79`	`$error = 'Internal error';`