Use PHPStan strict rules

Author: Seldaek

composer.json

@@ -21,7 +21,8 @@
     },
     "require-dev": {
         "symfony/phpunit-bridge": "^4.2 || ^5",
-        "phpstan/phpstan": "^1"
+        "phpstan/phpstan": "^1",
+        "phpstan/phpstan-strict-rules": "^1.1"
     },
     "autoload": {
         "psr-4": {

phpstan.neon.dist

@@ -3,3 +3,6 @@ parameters:
     paths:
         - src
         - tests
+
+includes:
+    - vendor/phpstan/phpstan-strict-rules/rules.neon

tests/BaseTestCase.php

@@ -15,8 +15,8 @@
 
 class BaseTestCase extends TestCase
 {
-    /** @var string */
-    protected $pregFunction;
+    /** @var string|null */
+    protected $pregFunction = null;
 
     /**
      * @param  class-string<\Exception> $class
@@ -27,7 +27,7 @@ protected function doExpectException($class, $message = null)
     {
         if (method_exists($this, 'expectException')) {
             $this->expectException($class);
-            if ($message) {
+            if (null !== $message) {
                 $this->expectExceptionMessage($message);
             }
         } else {
@@ -69,11 +69,11 @@ protected function expectPcreEngineException($pattern)
      */
     protected function expectPcreException($pattern, $error = null)
     {
-        if (!$this->pregFunction) {
+        if (null === $this->pregFunction) {
             $this->fail('Preg function name is missing');
         }
 
-        if (!$error) {
+        if (null !== $error) {
             // Only use a message if the error can be reliably determined
             if (PHP_VERSION_ID >= 80000) {
                 $error = 'Internal error';
@@ -82,7 +82,7 @@ protected function expectPcreException($pattern, $error = null)
             }
         }
 
-        if ($error) {
+        if (null !== $error) {
             $message = sprintf('%s: failed executing "%s": %s', $this->pregFunction, $pattern, $error);
         } else {
             $message = null;
@@ -97,11 +97,11 @@ protected function expectPcreException($pattern, $error = null)
      */
     protected function expectPcreWarning($warning = null)
     {
-        if (!$this->pregFunction) {
+        if (null === $this->pregFunction) {
             $this->fail('Preg function name is missing');
         }
 
-        $warning = $warning ?: 'No ending matching delimiter \'}\' found';
+        $warning = $warning !== null ? $warning : 'No ending matching delimiter \'}\' found';
         $message = sprintf('%s: %s', $this->pregFunction, $warning);
         $this->doExpectWarning($message);
     }