Skip to content

Commit bbc50e2

Browse files
committed
Tweaks
1 parent 23e29a4 commit bbc50e2

File tree

7 files changed

+25
-20
lines changed

7 files changed

+25
-20
lines changed

extension.neon

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ services:
1313
-
1414
class: Composer\Pcre\PHPStan\PregMatchParameterOutTypeExtension
1515
-
16-
class: Composer\Pcre\PHPStan\PregMatchTypeSpecifyingExtension
16+
class: Composer\Pcre\PHPStan\PregMatchTypeSpecifyingExtension

phpstan.neon.dist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ parameters:
77
reportUnmatchedIgnoredErrors: false
88
treatPhpDocTypesAsCertain: false
99

10-
ignoreErrors:
11-
- '#Test::data[a-zA-Z0-9_]+\(\) return type has no value type specified in iterable type#'
10+
bootstrapFiles:
11+
- tests/phpstan-locate-phpunit-autoloader.php
1212

1313
excludePaths:
1414
- tests/PHPStanTests/nsrt/*

src/PHPStan/PregMatchFlags.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,4 @@ static public function getType(?Arg $flagsArg, Scope $scope): ?Type
3232
}
3333
return TypeCombinator::union(...$internalFlagsTypes);
3434
}
35-
}
35+
}

src/PHPStan/PregMatchParameterOutTypeExtension.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@
1414

1515
final class PregMatchParameterOutTypeExtension implements StaticMethodParameterOutTypeExtension
1616
{
17-
18-
private RegexArrayShapeMatcher $regexShapeMatcher;
17+
/**
18+
* @var RegexArrayShapeMatcher
19+
*/
20+
private $regexShapeMatcher;
1921

2022
public function __construct(
2123
RegexArrayShapeMatcher $regexShapeMatcher

src/PHPStan/PregMatchTypeSpecifyingExtension.php

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,21 @@
1616

1717
final class PregMatchTypeSpecifyingExtension implements StaticMethodTypeSpecifyingExtension, TypeSpecifierAwareExtension
1818
{
19+
/**
20+
* @var TypeSpecifier
21+
*/
22+
private $typeSpecifier;
1923

20-
private TypeSpecifier $typeSpecifier;
24+
/**
25+
* @var RegexArrayShapeMatcher
26+
*/
27+
private $regexShapeMatcher;
2128

22-
private RegexArrayShapeMatcher $regexShapeMatcher;
23-
24-
public function __construct(
25-
RegexArrayShapeMatcher $regexShapeMatcher
26-
)
29+
public function __construct(RegexArrayShapeMatcher $regexShapeMatcher)
2730
{
2831
$this->regexShapeMatcher = $regexShapeMatcher;
2932
}
3033

31-
3234
public function setTypeSpecifier(TypeSpecifier $typeSpecifier): void
3335
{
3436
$this->typeSpecifier = $typeSpecifier;
@@ -83,5 +85,4 @@ public function specifyTypes(MethodReflection $methodReflection, StaticCall $nod
8385
$node,
8486
);
8587
}
86-
8788
}

tests/PHPStanTests/TypeInferenceTest.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@
1515

1616
class TypeInferenceTest extends TypeInferenceTestCase
1717
{
18+
/**
19+
* @return mixed
20+
*/
1821
public function dataFileAsserts(): iterable
1922
{
2023
yield from $this->gatherAssertTypesFromDirectory(__DIR__ . '/nsrt');
21-
2224
}
2325

2426
/**
@@ -28,9 +30,9 @@ public function dataFileAsserts(): iterable
2830
public function testFileAsserts(
2931
string $assertType,
3032
string $file,
31-
...$args
32-
): void
33-
{
33+
...$args
34+
): void
35+
{
3436
$this->assertFileAsserts($assertType, $file, ...$args);
3537
}
3638

@@ -41,4 +43,4 @@ public static function getAdditionalConfigFiles(): array
4143
__DIR__ . '/../../extension.neon',
4244
];
4345
}
44-
}
46+
}

tests/PHPStanTests/nsrt/preg-match.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,4 @@ function equalMatch(string $s): void
4747
assertType('array{}', $matches);
4848
}
4949
assertType('array{}|array{string}', $matches);
50-
}
50+
}

0 commit comments

Comments
 (0)