Split Unfold benchmarks for "streamly" and "srteamly-core"

Author: harendra-kumar

benchmark/Streamly/Benchmark/Data/Unfold.hs

@@ -31,11 +31,7 @@ import qualified Prelude
 import qualified Streamly.FileSystem.Handle as FH
 import qualified Streamly.Internal.Data.Fold as FL
 import qualified Streamly.Internal.Data.Unfold as UF
-#ifndef USE_STREAMLY_CORE
-import qualified Streamly.Internal.Data.Unfold.Prelude as UF
-#endif
 import qualified Streamly.Internal.Data.Stream as S
-import qualified Streamly.Internal.Data.Stream as D
 import qualified Streamly.Internal.Data.StreamK as K
 
 import Test.Tasty.Bench hiding (env)
@@ -175,7 +171,7 @@ fromStreamK size start = drainGeneration UF.fromStreamK (K.replicate size start)
 {-# INLINE fromStreamD #-}
 fromStreamD :: Monad m => Int -> Int -> m ()
 fromStreamD size start =
-    drainGeneration UF.fromStreamD (D.replicate size start)
+    drainGeneration UF.fromStreamD (S.replicate size start)
 
 {-# INLINE _nilM #-}
 _nilM :: Monad m => Int -> Int -> m ()
@@ -793,14 +789,7 @@ inspect $ hasNoTypeClassesExcept 'readWriteFinally_Unfold [''MonadCatch]
 #else
 inspect $ hasNoTypeClasses 'readWriteFinally_Unfold
 #endif
--- inspect $ 'readWriteFinallyUnfold `hasNoType` ''Step
-#endif
-
-#ifndef USE_STREAMLY_CORE
-readWriteFinallyUnfold :: Handle -> Handle -> IO ()
-readWriteFinallyUnfold inh devNull =
-    let readEx = UF.finally (\_ -> hClose inh) FH.reader
-    in S.fold (FH.write devNull) $ S.unfold readEx inh
+-- inspect $ 'readWriteFinally_Unfold `hasNoType` ''Step
 #endif
 
 -- | Send the file contents to /dev/null with exception handling
@@ -815,14 +804,7 @@ inspect $ hasNoTypeClassesExcept 'readWriteBracket_Unfold [''MonadCatch]
 #else
 inspect $ hasNoTypeClasses 'readWriteBracket_Unfold
 #endif
--- inspect $ 'readWriteBracketUnfold `hasNoType` ''Step
-#endif
-
-#ifndef USE_STREAMLY_CORE
-readWriteBracketUnfold :: Handle -> Handle -> IO ()
-readWriteBracketUnfold inh devNull =
-    let readEx = UF.bracket return (\_ -> hClose inh) FH.reader
-    in S.fold (FH.write devNull) $ S.unfold readEx inh
+-- inspect $ 'readWriteBracket_Unfold `hasNoType` ''S.Step
 #endif
 
 o_1_space_copy_read_exceptions :: BenchEnv -> [Benchmark]
@@ -836,12 +818,6 @@ o_1_space_copy_read_exceptions env =
            readWriteFinally_Unfold inh (nullH env)
        , mkBenchSmall "UF.bracket_" env $ \inh _ ->
            readWriteBracket_Unfold inh (nullH env)
-#ifndef USE_STREAMLY_CORE
-       , mkBenchSmall "UF.finally" env $ \inh _ ->
-           readWriteFinallyUnfold inh (nullH env)
-       , mkBenchSmall "UF.bracket" env $ \inh _ ->
-           readWriteBracketUnfold inh (nullH env)
-#endif
         ]
     ]
 

benchmark/Streamly/Benchmark/Data/Unfold/Prelude1.hs

@@ -0,0 +1,54 @@
+-- |
+-- Module      : Streamly.Benchmark.Data.Unfold.Prelude
+-- Copyright   : (c) 2018 Composewell
+-- License     : MIT
+-- Maintainer  : [email protected]
+
+{-# LANGUAGE ScopedTypeVariables #-}
+
+module Main (main) where
+
+import System.IO (Handle, hClose)
+
+import qualified Streamly.Internal.Data.Stream as S
+import qualified Streamly.Internal.Data.Unfold.Prelude as UF
+import qualified Streamly.FileSystem.Handle as FH
+
+import Test.Tasty.Bench hiding (env)
+import Streamly.Benchmark.Common
+import Streamly.Benchmark.Common.Handle
+
+readWriteFinallyUnfold :: Handle -> Handle -> IO ()
+readWriteFinallyUnfold inh devNull =
+    let readEx = UF.finally (\_ -> hClose inh) FH.reader
+    in S.fold (FH.write devNull) $ S.unfold readEx inh
+
+readWriteBracketUnfold :: Handle -> Handle -> IO ()
+readWriteBracketUnfold inh devNull =
+    let readEx = UF.bracket return (\_ -> hClose inh) FH.reader
+    in S.fold (FH.write devNull) $ S.unfold readEx inh
+
+o_1_space_copy_read_exceptions :: BenchEnv -> [Benchmark]
+o_1_space_copy_read_exceptions env =
+    [ bgroup "exceptions"
+       [ mkBenchSmall "UF.finally" env $ \inh _ ->
+           readWriteFinallyUnfold inh (nullH env)
+       , mkBenchSmall "UF.bracket" env $ \inh _ ->
+           readWriteBracketUnfold inh (nullH env)
+        ]
+    ]
+
+moduleName :: String
+moduleName = "Data.Unfold.Prelude"
+
+main :: IO ()
+main = do
+    env <- mkHandleBenchEnv
+    runWithCLIOpts defaultStreamSize (allBenchmarks env)
+
+    where
+
+    allBenchmarks env _size =
+        [ bgroup (o_1_space_prefix moduleName)
+            $ o_1_space_copy_read_exceptions env
+        ]

benchmark/streamly-benchmarks.cabal

@@ -107,8 +107,8 @@ common default-extensions
 common compile-options
     import: default-extensions
 
-    if flag(use-streamly-core)
-      cpp-options:    -DUSE_STREAMLY_CORE
+    -- if flag(use-streamly-core)
+    --   cpp-options:    -DUSE_STREAMLY_CORE
 
     if flag(dev)
       cpp-options:    -DDEVBUILD
@@ -599,6 +599,16 @@ benchmark Data.Unfold
   else
     buildable: True
 
+benchmark Data.Unfold.Prelude
+  import: bench-options
+  type: exitcode-stdio-1.0
+  hs-source-dirs: Streamly/Benchmark/Data/Unfold
+  main-is: Prelude1.hs
+  if flag(use-streamly-core) || impl(ghcjs)
+    buildable: False
+  else
+    buildable: True
+
 benchmark FileSystem.Handle
   import: bench-options
   type: exitcode-stdio-1.0

hie.yaml

@@ -72,6 +72,8 @@ cradle:
               component: "bench:Data.Stream.Prelude.Exceptions"
             - path: "./benchmark/Streamly/Benchmark/Data/Unfold.hs"
               component: "bench:Data.Unfold"
+            - path: "./benchmark/Streamly/Benchmark/Data/Unfold/Prelude1.hs"
+              component: "bench:Data.Unfold.Prelude"
             - path: "./benchmark/Streamly/Benchmark/FileSystem/Handle/Read.hs"
               component: "bench:FileSystem.Handle"
             - path: "./benchmark/Streamly/Benchmark/FileSystem/Handle/ReadWrite.hs"

streamly.cabal

@@ -85,6 +85,7 @@ extra-source-files:
     benchmark/Streamly/Benchmark/Data/Stream/*.hs
     benchmark/Streamly/Benchmark/Data/Stream/Prelude/*.hs
     benchmark/Streamly/Benchmark/Data/StreamK/*.hs
+    benchmark/Streamly/Benchmark/Data/Unfold/*.hs
     benchmark/Streamly/Benchmark/FileSystem/*.hs
     benchmark/Streamly/Benchmark/FileSystem/Handle/*.hs
     benchmark/Streamly/Benchmark/Unicode/*.hs