hlint

Author: wismill

unicode-data-security/bench/Main.hs

@@ -22,23 +22,27 @@ main = defaultMain
             [ benchNF "isAllowedInIdentifier" Security.isAllowedInIdentifier
             ]
         , bgroup "Identifier Types"
-            [ benchNF "identifierTypes"     (fmap fromEnum . Security.identifierTypes)
+            [ benchNF "identifierTypes" (fmap fromEnum . Security.identifierTypes)
             ]
         , bgroup "Confusables"
             [ bgroup' "confusablePrototype"
-                [ Bench "CString" (\c -> Ptr (Confusables.confusablePrototype c))
+                [ Bench "CString" confusablePrototype
                 , Bench "String"  Security.confusablePrototype
                 ]
             -- , benchNF "prototype" Security.prototype
             , bgroup' "intentionalConfusables"
-                [ Bench "CString" (\c -> Ptr (Confusables.intentionalConfusables c))
+                [ Bench "CString" intentionalConfusables
                 , Bench "String"  Security.intentionalConfusables
                 ]
             , benchNF "isIntentionallyConfusable" Security.intentionalConfusables
             ]
         ]
     ]
   where
+    -- [NOTE] Cannot use point-free because of unlifted types
+    confusablePrototype c = Ptr (Confusables.confusablePrototype c)
+    intentionalConfusables c = Ptr (Confusables.intentionalConfusables c)
+
     bgroup' groupTitle bs = bgroup groupTitle
         [ benchNF' groupTitle title f
         | Bench title f <- bs

unicode-data-security/test/Unicode/Char/Identifiers/SecuritySpec.hs

@@ -58,6 +58,6 @@ spec = do
             -- [TODO] more invariants
             traverse_ check (enumFromTo minBound maxBound)
     it "Identifier status is consistent with identifier types" do
-        let checkChar c = all (== isAllowedInIdentifier c)
-                              (isIdentifierTypeAllowed <$> identifierTypes c)
+        let checkChar c = all ((== isAllowedInIdentifier c) . isIdentifierTypeAllowed)
+                              (identifierTypes c)
         traverse_ (`shouldSatisfy` checkChar) (enumFromTo minBound maxBound)

unicode-data/lib/Unicode/Char/General/Blocks.hs

@@ -1,7 +1,3 @@
-{-# LANGUAGE PatternSynonyms #-}
-{-# LANGUAGE ViewPatterns #-}
-{-# LANGUAGE DeriveGeneric #-}
-
 -- |
 -- Module      : Unicode.Char.General.Blocks
 -- Copyright   : (c) 2020 Composewell Technologies and Contributors