organize: kubernetes should have a subdirectory for a job

antipating other kubernetes abstractions, lets move job
into a submodule of kubernetes.

Signed-off-by: vsoch <[email protected]>

Author: vsoch

examples/agent/README.md

@@ -72,6 +72,8 @@ We haven't hit the case yet where the manager needs to take over - that needs fu
 #### To do items
 
 - Figure out optimization agent (with some goal)
+- The LLM absolutely needs detail about the data, and what to run.
+- Error messages from programs are immensely important now since the LLM makes decisions entirely from it.
 - Right now when we restart, we do with fresh slate (no log memory) - should there be?
 - We likely want some want to quantify the amount of change between prompts, and the difficulty of the task.
 - I think likely when we return to the manager, we want the last response (that might say why it is returning) should inform step selection. But not just step selection, the updated prompt to the step missing something.

fractale/agent/__init__.py

@@ -1,5 +1,5 @@
 from fractale.agent.build import BuildAgent
-from fractale.agent.kubernetes_job import KubernetesJobAgent
+from fractale.agent.kubernetes import KubernetesJobAgent
 from fractale.agent.manager import ManagerAgent
 
 

fractale/agent/base.py

@@ -272,12 +272,6 @@ def ask_gemini(self, prompt, with_history=True):
         """
         Ask gemini adds a wrapper with some error handling.
         """
-        # Always remove lines with empty spaces
-        if len(prompt) > 15000:
-            print("FOUND CHONKER PROMPT")
-            import IPython
-
-            IPython.embed()
         try:
             start = time.perf_counter()
             if with_history:

fractale/agent/kubernetes/__init__.py

@@ -0,0 +1,2 @@
+from .job import KubernetesJobAgent
+assert KubernetesJobAgent

fractale/agent/kubernetes/base.py

@@ -0,0 +1,67 @@
+import argparse
+from rich.syntax import Syntax
+
+import fractale.agent.logger as logger
+from fractale.agent.base import GeminiAgent
+
+
+class KubernetesAgent(GeminiAgent):
+    """
+    A Kubernetes agent is a base class for a generic Kubernetes agent.
+    """
+
+    def _add_arguments(self, subparser):
+        """
+        Add arguments for the plugin to show up in argparse
+        """
+        agent = subparser.add_parser(
+            self.name,
+            formatter_class=argparse.RawTextHelpFormatter,
+            description=self.description,
+        )
+        agent.add_argument(
+            "container",
+            help="Container unique resource identifier to use (required)",
+        )
+        agent.add_argument(
+            "--environment",
+            help="Environment description to build for (defaults to generic)",
+        )
+        agent.add_argument(
+            "--no-pull",
+            default=False,
+            action="store_true",
+            help="Do not pull the image, assume pull policy is Never",
+        )
+        agent.add_argument("--context-file", help="Context from a deploy failure or similar.")
+        return agent
+
+    def print_result(self, job_crd):
+        """
+        Print Job CRD with highlighted Syntax
+        """
+        highlighted_syntax = Syntax(job_crd, "yaml", theme="monokai", line_numbers=True)
+        logger.custom(
+            highlighted_syntax, title="Final Kubernetes Job", border_style="green", expand=True
+        )
+
+
+    def save_log(self, full_logs):
+        """
+        Save logs to metadata
+        """
+        if self.save_incremental:
+            if "logs" not in self.metadata["assets"]:
+                self.metadata["assets"]["logs"] = []
+            self.metadata["assets"]["logs"].append({"item": full_logs, "attempt": self.attempts})
+
+    def save_job_manifest(self, job):
+        """
+        Save job manifest to metadata
+        """
+        if self.save_incremental:
+            if self.result_type not in self.metadata["assets"]:
+                self.metadata["assets"][self.result_type] = []
+            self.metadata["assets"][self.result_type].append(
+                {"item": job, "attempt": self.attempts}
+            )

fractale/agent/kubernetes_job/__init__.py renamed to fractale/agent/kubernetes/job/__init__.py

@@ -13,8 +13,9 @@
 from rich import print
 from rich.syntax import Syntax
 
-import fractale.agent.kubernetes_job.objects as objects
-import fractale.agent.kubernetes_job.prompts as prompts
+import fractale.agent.kubernetes.objects as objects
+from fractale.agent.kubernetes.base import KubernetesAgent
+import fractale.agent.kubernetes.job.prompts as prompts
 import fractale.agent.logger as logger
 import fractale.utils as utils
 from fractale.agent.base import GeminiAgent
@@ -23,7 +24,7 @@
 from fractale.agent.errors import DebugAgent
 
 
-class KubernetesJobAgent(GeminiAgent):
+class KubernetesJobAgent(KubernetesAgent):
     """
     A Kubernetes Job agent knows how to design a Kubernetes job.
     """
@@ -32,32 +33,6 @@ class KubernetesJobAgent(GeminiAgent):
     description = "Kubernetes Job agent"
     result_type = "kubernetes-job-manifest"
 
-    def _add_arguments(self, subparser):
-        """
-        Add arguments for the plugin to show up in argparse
-        """
-        agent = subparser.add_parser(
-            self.name,
-            formatter_class=argparse.RawTextHelpFormatter,
-            description=self.description,
-        )
-        agent.add_argument(
-            "container",
-            help="Container unique resource identifier to use (required)",
-        )
-        agent.add_argument(
-            "--environment",
-            help="Environment description to build for (defaults to generic)",
-        )
-        agent.add_argument(
-            "--no-pull",
-            default=False,
-            action="store_true",
-            help="Do not pull the image, assume pull policy is Never",
-        )
-        agent.add_argument("--context-file", help="Context from a deploy failure or similar.")
-        return agent
-
     def get_prompt(self, context):
         """
         Get the prompt for the LLM. We expose this so the manager can take it
@@ -135,15 +110,6 @@ def add_build_context(self, context):
             context.dockerfile = utils.read_file(build_context)
         return context
 
-    def print_result(self, job_crd):
-        """
-        Print Job CRD with highlighted Syntax
-        """
-        highlighted_syntax = Syntax(job_crd, "yaml", theme="monokai", line_numbers=True)
-        logger.custom(
-            highlighted_syntax, title="Final Kubernetes Job", border_style="green", expand=True
-        )
-
     def get_diagnostics(self, job, pod):
         """
         Helper to collect rich error data for a failed job.
@@ -369,15 +335,6 @@ def deploy(self, context):
         # Save full logs for the step
         return 0, full_logs
 
-    def save_log(self, full_logs):
-        """
-        Save logs to metadata
-        """
-        if self.save_incremental:
-            if "logs" not in self.metadata["assets"]:
-                self.metadata["assets"]["logs"] = []
-            self.metadata["assets"]["logs"].append({"item": full_logs, "attempt": self.attempts})
-
     def save_job_manifest(self, job):
         """
         Save job manifest to metadata