* generate crash reports on unhandled exceptions after startup

* make ACTcpClient.SendPacketUdp public

Author: compujuckel

AssettoServer.Shared/Services/CriticalBackgroundService.cs

@@ -1,10 +1,11 @@
 using Microsoft.Extensions.Hosting;
-using Serilog;
 
 namespace AssettoServer.Shared.Services;
 
 public abstract class CriticalBackgroundService : IHostedService, IDisposable
 {
+    public static event UnhandledExceptionEventHandler? UnhandledException;
+    
     private readonly CancellationTokenSource _stoppingCts = new();
     private readonly IHostApplicationLifetime _applicationLifetime;
 
@@ -30,7 +31,7 @@ public Task StartAsync(CancellationToken cancellationToken)
         {
             if (t.Exception != null)
             {
-                Log.Fatal(t.Exception, "Error executing critical background service");
+                UnhandledException?.Invoke(this, new UnhandledExceptionEventArgs(t.Exception, true));
                 _applicationLifetime.StopApplication();
             }
         }, _stoppingCts.Token);

AssettoServer/CrashReportHelper.cs

@@ -7,6 +7,7 @@
 using System.Text.RegularExpressions;
 using AssettoServer.Server.Configuration;
 using Scriban;
+using Serilog;
 
 namespace AssettoServer;
 
@@ -18,6 +19,28 @@ private class Attachment
         public string? Type { get; init; }
         public required string Content { get; init; }
     }
+
+    public static void HandleFatalException(Exception ex)
+    {
+        Log.Fatal(ex, "Fatal exception occurred");
+        string? crashReportPath = null;
+
+        var configLocations = Program.ConfigurationLocations;
+        if (configLocations != null)
+        {
+            try
+            {
+                crashReportPath = GenerateCrashReport(configLocations, ex);
+            }
+            catch (Exception ex2)
+            {
+                Log.Error(ex2, "Error writing crash report");
+            }
+        }
+
+        Log.CloseAndFlush();
+        ExceptionHelper.PrintExceptionHelp(ex, Program.IsContentManager, crashReportPath);
+    }
 
     public static string GenerateCrashReport(ConfigurationLocations locations, Exception exception)
     {

AssettoServer/Network/Tcp/ACTcpClient.cs

@@ -259,7 +259,7 @@ public void SendPacket<TPacket>(TPacket packet) where TPacket : IOutgoingNetwork
         }
     }
 
-    internal void SendPacketUdp<TPacket>(in TPacket packet) where TPacket : IOutgoingNetworkPacket
+    public void SendPacketUdp<TPacket>(in TPacket packet) where TPacket : IOutgoingNetworkPacket
     {
         if (UdpEndpoint == null) return;
 

AssettoServer/Program.cs

@@ -6,6 +6,7 @@
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
+using AssettoServer.Shared.Services;
 using AssettoServer.Utils;
 using Autofac.Extensions.DependencyInjection;
 using CommandLine;
@@ -61,7 +62,9 @@ private class StartOptions
         public string? EntryListPath { get; init; }
     }
 
-    public static bool IsContentManager;
+    public static bool IsContentManager { get; private set; }
+    public static ConfigurationLocations? ConfigurationLocations { get; private set; }
+    
     private static bool _loadPluginsFromWorkdir;
     private static bool _generatePluginConfigs;
     private static TaskCompletionSource<StartOptions> _restartTask = new();
@@ -100,7 +103,8 @@ internal static async Task Main(string[] args)
         string logPrefix = string.IsNullOrEmpty(options.Preset) ? "log" : options.Preset;
         Logging.CreateLogger(logPrefix, IsContentManager, options.Preset, options.UseVerboseLogging);
 
-        AppDomain.CurrentDomain.UnhandledException += OnUnhandledException;
+        AppDomain.CurrentDomain.UnhandledException += UnhandledException;
+        CriticalBackgroundService.UnhandledException += UnhandledException;
         Log.Information("AssettoServer {Version}", ThisAssembly.AssemblyInformationalVersion);
         if (IsContentManager)
         {
@@ -150,11 +154,11 @@ private static async Task RunServerAsync(
         bool useVerboseLogging,
         CancellationToken token = default)
     {
-        var configLocations = ConfigurationLocations.FromOptions(preset, serverCfgPath, entryListPath);
+        ConfigurationLocations = ConfigurationLocations.FromOptions(preset, serverCfgPath, entryListPath);
 
         try
         {
-            var config = new ACServerConfiguration(preset, configLocations, _loadPluginsFromWorkdir, _generatePluginConfigs);
+            var config = new ACServerConfiguration(preset, ConfigurationLocations, _loadPluginsFromWorkdir, _generatePluginConfigs);
 
             string logPrefix = string.IsNullOrEmpty(preset) ? "log" : preset;
             Logging.CreateLogger(logPrefix, IsContentManager, preset, useVerboseLogging, config.Extra.RedactIpAddresses, config.Extra.LokiSettings);
@@ -191,26 +195,13 @@ private static async Task RunServerAsync(
         }
         catch (Exception ex)
         {
-            Log.Fatal(ex, "Error starting server");
-            string? crashReportPath = null;
-            try
-            {
-                crashReportPath = CrashReportHelper.GenerateCrashReport(configLocations, ex);
-            }
-            catch (Exception ex2)
-            {
-                Log.Error(ex2, "Error writing crash report");
-            }
-            await Log.CloseAndFlushAsync();
-            ExceptionHelper.PrintExceptionHelp(ex, IsContentManager, crashReportPath);
+            CrashReportHelper.HandleFatalException(ex);
         }
     }
 
-    private static void OnUnhandledException(object sender, UnhandledExceptionEventArgs args)
+    private static void UnhandledException(object sender, UnhandledExceptionEventArgs args)
     {
-        Log.Fatal((Exception)args.ExceptionObject, "Unhandled exception occurred");
-        Log.CloseAndFlush();
-        Environment.Exit(1);
+        CrashReportHelper.HandleFatalException((Exception)args.ExceptionObject);
     }
 
     private static void SetupFluentValidation()