Skip to content

Commit cbbd708

Browse files
authored
v1.12.2+galaxy2 (#40)
* createDatabase and spectralMatching bug fixes * Update .travis.yml * Version bump in readme * Remove galaxy version for lint travis
1 parent 89bf304 commit cbbd708

File tree

6 files changed

+18
-8
lines changed

6 files changed

+18
-8
lines changed

.travis.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
language: python
2-
python: 2.7
2+
python: 3.7
33
cache:
44
directories:
55
- $HOME/miniconda3
@@ -27,6 +27,6 @@ before_install:
2727

2828

2929
script:
30-
- planemo lint ${TRAVIS_BUILD_DIR}/${TEST}
31-
- planemo test --conda_debug ${TRAVIS_BUILD_DIR}/${TEST}
30+
- planemo lint ${TRAVIS_BUILD_DIR}/${TEST}
31+
- planemo test --conda_debug ${TRAVIS_BUILD_DIR}/${TEST} --galaxy_python_version 3.7
3232

README.rst

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@ msPurity for Galaxy
33
|Build Status (Travis)| |Git| |Bioconda| |License|
44

55

6-
Version v1.12.2+galaxy1
6+
Version v1.12.2+galaxy2
77
------
88

99
- msPurity
1010
- bioconductor-mspurity v1.12.2
1111
- Galaxy tools
12-
- v1
12+
- v2
1313

1414
About
1515
------
@@ -55,6 +55,11 @@ Authors, contributors & contacts
5555

5656
Changes
5757
-------------------------
58+
v1.12.2-galaxy2
59+
- Bug fix for using custom library sqlite database from Galaxy UI
60+
- Bug fix for "allfrag" for createDatabase
61+
62+
5863
v1.12.2-galaxy1
5964
- grpPeaklist reference incorrect in createDatabase.xml
6065
- Add custom adduct handling for createMSP

tools/msPurity/createDatabase.R

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,11 @@ pa <- loadRData(opt$pa, 'pa')
9494

9595
print(pa@fileList)
9696

97-
97+
# Missing list element causes failures (should be updated
98+
# in msPurity R package for future releases)
99+
if (!exists('allfrag', where=pa@filter_frag_params)){
100+
pa@filter_frag_params$allfrag <- FALSE
101+
}
98102

99103
if (opt$xcms_camera_option=='xcms'){
100104

tools/msPurity/macros.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0"?>
22
<macros>
33
<token name="@TOOL_VERSION@">1.12.2</token>
4-
<token name="@GALAXY_TOOL_VERSION@">1</token>
4+
<token name="@GALAXY_TOOL_VERSION@">2</token>
55

66
<xml name="requirements">
77
<requirements>

tools/msPurity/spectralMatching.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,7 @@ if(!is.null(opt$q_rtrangeMin)){
292292
q_check <- checkSPeakMeta(opt$q_dbPth, 'query')
293293
l_check <- checkSPeakMeta(opt$l_dbPth, 'library')
294294

295+
295296
if (q_check && l_check){
296297
sm <- msPurity::spectralMatching(
297298
q_purity = opt$q_purity,

tools/msPurity/spectralMatching.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
2020
#if $Library.l_dbPth_con.l_dbPth_select == 'msPurityData'
2121
--l_defaultDb
22-
#else if $Library.l_dbPth_con.l_dbPth_select == 'userdb_sqlite'
22+
#else if $Library.l_dbPth_con.l_dbPth_select == 'sqlite'
2323
--l_dbPth=$Library.l_dbPth_con.l_dbPth
2424
#end if
2525

0 commit comments

Comments
 (0)