Skip to content

Commit 35b3913

Browse files
committed
fix broken vigettes
groups slot for pca scores is no longer usedis deprecated
1 parent c2786a8 commit 35b3913

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

R/PCA_plotfcns.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ pca_scores_plot<-setClass(
6969
params.factor_name='entity',
7070
params.ellipse='enum',
7171
params.label_filter='entity',
72-
params.groups='factor'
72+
params.groups='ANY' # will be deprecated
7373
),
7474

7575
prototype = list(name='PCA scores plot',

vignettes/method_example.Rmd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ MVA = model.train(MVA,predicted(PMP))
5757
MVA = model.predict(MVA,predicted(PMP))
5858
5959
# charts
60-
C = pca_scores_plot(factor_name = 'Class',groups=D$sample_meta$class)
60+
C = pca_scores_plot(factor_name = 'class',groups=D$sample_meta$class)
6161
chart.plot(C,MVA[2])
6262
```
6363

@@ -149,7 +149,7 @@ MVA2 = model.train(MVA2,predicted(MS2))
149149
MVA2 = model.predict(MVA2,predicted(MS2))
150150
151151
# charts
152-
C = pca_scores_plot(factor_name = 'Class',groups=D$sample_meta$class)
152+
C = pca_scores_plot(factor_name = 'class',groups=D$sample_meta$class)
153153
chart.plot(C,MVA2[2])
154154
```
155155

vignettes/model_example.Rmd

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,9 @@ chart.plot(C,M[2])
105105
If we makes changes to our chart object, we must call `chart.plot` again.
106106

107107
```{r}
108-
C$groups = D$data$Petal.Width
108+
# add petal width to emta data of pca scores
109+
M[2]$scores$sample_meta$Petal.Width=D$data$Petal.Width
110+
# update plot
109111
C$factor_name='Petal.Width'
110112
chart.plot(C,M[2])
111113
```

0 commit comments

Comments
 (0)