Skip to content

Commit d6406e1

Browse files
Updating minimiser with abstract methods
1 parent 6b9931b commit d6406e1

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

fidimag/common/hubert_minimiser.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ def minimise(self,
291291
if avGradE < mXgradE_tol:
292292
print(f'Average torque length |mX∇E|/N = {avGradE} negligible. Stopping calculation.')
293293
exitFlag = True
294+
# TODO: add break here?
294295

295296
# Stop while creepCount
296297

fidimag/common/minimiser_base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from __future__ import division
2+
from abc import abstractmethod
23
import numpy as np
34
import os
45
import zipfile
@@ -75,9 +76,8 @@ def run_step_CLIB(self):
7576
"""
7677
pass
7778

78-
def minimise(self, stopping_dm=1e-2, max_steps=2000,
79-
save_data_steps=10, save_m_steps=None, save_vtk_steps=None,
80-
log_steps=1000):
79+
@abstractmethod
80+
def minimise(self):
8181
pass
8282

8383
def relax(self):

0 commit comments

Comments
 (0)