Skip to content

Commit fa9f317

Browse files
fmietingvidartf
andauthored
Establish stable parameter order
Co-authored-by: Vidar Tonaas Fauske <[email protected]>
1 parent 5c79a5b commit fa9f317

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

nbval/kernel.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ class RunningKernel(object):
7575
this class.
7676
7777
"""
78-
def __init__(self, kernel_name, startup_timeout, cwd=None):
78+
def __init__(self, kernel_name, cwd=None, startup_timeout=60):
7979
"""
8080
Initialise a new kernel
8181
specify that matplotlib is inline and connect the stderr.

nbval/plugin.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,10 @@ def setup(self):
239239
kernel_name = self.nb.metadata.get(
240240
'kernelspec', {}).get('name', 'python')
241241
self.kernel = RunningKernel(
242-
kernel_name, self.config.option.nbval_kernel_startup_timeout, str(self.fspath.dirname))
242+
kernel_name,
243+
cwd=str(self.fspath.dirname),
244+
startup_timeout=self.config.option.nbval_kernel_startup_timeout,
245+
)
243246
self.setup_sanitize_files()
244247
if getattr(self.parent.config.option, 'cov_source', None):
245248
setup_coverage(self.parent.config, self.kernel, getattr(self, "fspath", None))

0 commit comments

Comments
 (0)