Skip to content

Commit 565fdb7

Browse files
committed
fix: refresh from db, remove redundant code
DataCiteApi.mint_public_doi already saves the DOI on the codebase or codebase release, no need to re-save
1 parent 58d147f commit 565fdb7

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

django/deploy/cron.daily/doi_mint_pending_releases

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@
77
# Pros of before backups: backups will be more up-to-date
88
#
99
# currently syncing after backups
10-
./manage.py doi_mint_pending_releases --no-interactive --no-dry-run
10+
./manage.py doi_mint_pending_releases --no-interactive --no-dry-run

django/library/doi.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -556,8 +556,6 @@ def mint_pending_dois(self):
556556
(release, log, "Unable to mint DOI for parent codebase")
557557
)
558558
continue
559-
codebase.doi = codebase_doi
560-
codebase.save()
561559

562560
"""
563561
Mint DOI for release
@@ -569,15 +567,15 @@ def mint_pending_dois(self):
569567
(release, log, "Unable to mint DOI for release")
570568
)
571569
continue
572-
release.doi = log.doi
573-
release.save()
574570

575571
logger.debug(
576572
"Updating metadata for parent codebase of release %s", release.pk
577573
)
578574
"""
579575
Update parent Codebase metadata for new release DOI
580576
"""
577+
codebase.refresh_from_db()
578+
release.refresh_from_db()
581579
log, ok = self.update_doi_metadata(codebase)
582580
if not ok:
583581
logger.error("Failed to update metadata for codebase %s", codebase.pk)

0 commit comments

Comments
 (0)