Skip to content

Commit f3f3d08

Browse files
committed
feat: add some indicators for imported releases
on the model detail page as well as in review stuff
1 parent a4a5566 commit f3f3d08

File tree

9 files changed

+45
-5
lines changed

9 files changed

+45
-5
lines changed

django/library/fs.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -873,7 +873,12 @@ def _guess_file_category(self, name: Path) -> str:
873873
"""return an appropriate category name for a file based on its extension.
874874
currently defaults to code for all files except pdfs, which can be reasonably assumed to be docs
875875
"""
876-
if name.suffix == ".pdf":
876+
if (
877+
name.suffix == ".pdf"
878+
or name.suffix == ".docx"
879+
or name.suffix == ".doc"
880+
or name.suffix == ".md"
881+
):
877882
return FileCategories.docs.name
878883
return FileCategories.code.name
879884

django/library/jinja2/library/codebases/macros.jinja

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,3 +109,9 @@
109109
</div>
110110
</div>
111111
{% endmacro %}
112+
113+
{% macro imported_release_indicator(release) %}
114+
{% if release.is_imported and release.imported_release_package.service %}
115+
<i class="small text-muted fas fa-file-import" title="This release was imported from {{ release.imported_release_package.service }}"></i>
116+
{% endif %}
117+
{% endmacro %}

django/library/jinja2/library/codebases/releases/retrieve.jinja

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{% extends "sidebar_layout.jinja" %}
22
{% from "common.jinja" import breadcrumb, embed_discourse_comments, share_card, search_tag_href, member_profile_href, render_ogp_tags, alert_if_spam, mark_spam_confirm_modal %}
33
{% from "library/review/includes/macros.jinja" import confirm_change_closed_modal %}
4+
{% from "library/codebases/macros.jinja" import imported_release_indicator %}
45

56
{% set open_code_badge_png_url = request.build_absolute_uri(static("images/icons/open-code-badge.png")) %}
67
{% set open_code_badge_svg_url = request.build_absolute_uri(static("images/icons/open-code-badge.svg")) %}
@@ -102,7 +103,9 @@
102103
{% else %}
103104
<div class="alert alert-danger mt-2">The release you are viewing is currently unpublished.</div>
104105
{% endif %}
105-
<h1 class='codebase-title mb-3'>{{ codebase.title }} <span class="badge bg-gray py-1 px-2">{{ release.version_number }}</span></h1>
106+
<h1 class='codebase-title mb-3'>
107+
{{ codebase.title }} <span class="badge bg-gray py-1 px-2">{{ release.version_number }}</span>
108+
</h1>
106109
<div class='metadata text-muted mb-2'>
107110
<span class="me-3">
108111
<b>Submitted by</b>
@@ -401,6 +404,17 @@
401404
<div class="card-text mb-3">
402405
{{ release.version_number }}
403406
</div>
407+
{% with imported_package = release.imported_release_package %}
408+
{% if imported_package and imported_package.display_name and imported_package.html_url %}
409+
<b class='card-title'>Imported From</b>
410+
<div class="card-text mb-3">
411+
<a href='{{ imported_package.html_url }}'>
412+
<i class="fas fa-tag"></i>
413+
{{ imported_package.display_name }}
414+
</a>
415+
</div>
416+
{% endif %}
417+
{% endwith %}
404418
<b class='card-title'>License</b>
405419
<div class="card-text mb-3">
406420
<a href='{{ release.license.url }}'>{{ release.license.name }}</a>
@@ -551,7 +565,7 @@
551565
<tbody>
552566
{% for related_release in codebase.ordered_releases_list(has_change_perm, asc=False) %}
553567
<tr>
554-
<td><a href='{{ related_release.get_absolute_url() }}'>{{ related_release.version_number }}</a></td>
568+
<td><a href='{{ related_release.get_absolute_url() }}'>{{ related_release.version_number }} {{ imported_release_indicator(related_release) }}</a></td>
555569
<td>
556570
{% if release.live or has_change_perm %}
557571
{{ member_profile_href(related_release.submitter.member_profile) }}

django/library/jinja2/library/github_sync_overview.jinja

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@
170170
<div class="col-md-6">
171171
<div class="card mb-4">
172172
<div class="card-header d-flex align-items-center justify-content-between">
173-
<h3 class="mb-0"><i class="fas fa-archive"></i> Importing</h3>
173+
<h3 class="mb-0"><i class="fas fa-file-import"></i> Importing</h3>
174174
<span class="text-muted">(GitHub → CoMSES)</span>
175175
</div>
176176
<div class="card-body">

django/library/jinja2/library/review/dashboard.jinja

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{% extends 'sidebar_layout.jinja' %}
22
{% from "common.jinja" import breadcrumb, paginator %}
33
{% from "library/review/includes/macros.jinja" import display_closed_status %}
4+
{% from "library/codebases/macros.jinja" import imported_release_indicator %}
45

56
{% block introduction %}
67
<h1>Peer Review Editor Dashboard</h1>
@@ -32,6 +33,7 @@
3233
{% set review = release.review %}
3334
<hr>
3435
<h5 class="fw-bold">
36+
{{ imported_release_indicator(release) }}
3537
<a href="{{ review.get_absolute_url() }}">Review for version {{ release.version_number }}</a>
3638
{{ display_closed_status(review) }}
3739
</h5>

django/library/jinja2/library/review/feedback/update.jinja

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,12 @@
3535
<a target='_blank' href="{{ review_feedback.invitation.review.codebase_release.share_url }}">
3636
(click here to open in a new window/tab)
3737
</a>
38+
{% if release.is_imported %}
39+
<p><i>
40+
Please note that this model release was imported from GitHub, so the file structure may differ from
41+
a typical release package in the CoMSES Model Library.
42+
</i></p>
43+
{% endif %}
3844
</p>
3945
<div class='alert alert-info' role='alert'>
4046
You can save your progress at any time with the save button. Use the Submit button to send your finalized

django/library/jinja2/library/review/invitations/update.jinja

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,12 @@
2929
</ul>
3030
If this model is not published, please do not share it with anyone else.
3131
</p>
32+
{% if release.is_imported %}
33+
<p><i>
34+
Please note that this model release was imported from GitHub, so the file structure may differ from
35+
a typical release package in the CoMSES Model Library.
36+
</i></p>
37+
{% endif %}
3238
</section>
3339

3440
<section>

django/library/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import os
77
import pathlib
88
from string import Template
9+
import uuid
910
import semver
1011
from datetime import timedelta
1112
from packaging.version import Version

frontend/src/components/GitHubRemoteItem.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<label class="form-check-label" for="flexSwitchCheckDefault1">Importing</label>
4141
<div>
4242
<small class="form-text text-muted text-nowrap"
43-
><small><i class="fas fa-archive"></i> from GitHub</small></small
43+
><small><i class="fas fa-file-import"></i> from GitHub</small></small
4444
>
4545
</div>
4646
</div>

0 commit comments

Comments
 (0)