subunit: add version 1.4.4 (#24773)

* (#24732) subunit: add version 1.4.4

* (#24732) subunit: fix PATH deprecation warning

* (#24732) subunit: add build requirements

automake, libtool and pkgconfig are required to configure project
successfully

* (#24732) subunit: restore 1.4.0 build behavior

Building 1.4.0 version under MacOSX armv8 fails probably because
reconfiguration is done. Try to keep previous behavior to make build
successful.

* pkgconf version range | remove old virtualbuildEnv | move conandata_patches to source method | change autoreconf if

* Remove old version in favour of newer one, which simplifies recipe logic handling

---------

Co-authored-by: Ernesto de Gracia Herranz <[email protected]>
Co-authored-by: Abril Rincón Blanco <[email protected]>

Author: 3 people

recipes/subunit/all/conandata.yml

@@ -1,7 +1,4 @@
 sources:
-  "1.4.0":
-    url: "https://launchpad.net/subunit/trunk/1.4.0/+download/subunit-1.4.0.tar.gz"
-    sha256: "00792096e96cbf1d5f9394dadd0ea73309a4f8b2214822949f1888ce5c2cf1c0"
-patches:
-  "1.4.0":
-    - patch_file: "patches/0001-fix-ExtUtils-MakeMaker-error.patch"
+  "1.4.4":
+    url: "https://github.com/testing-cabal/subunit/archive/refs/tags/1.4.4.tar.gz"
+    sha256: "395787f52b8b36830c331faca546ea6c248b6cbd8de95989c2f64d432cc90531"

recipes/subunit/all/conanfile.py

@@ -4,14 +4,14 @@
 from conan import ConanFile
 from conan.errors import ConanInvalidConfiguration
 from conan.tools.build import cross_building
-from conan.tools.env import Environment, VirtualBuildEnv, VirtualRunEnv
-from conan.tools.files import apply_conandata_patches, chdir, copy, export_conandata_patches, get, rm, rmdir
+from conan.tools.env import Environment, VirtualRunEnv
+from conan.tools.files import chdir, copy, get, rm, rmdir
 from conan.tools.gnu import Autotools, AutotoolsDeps, AutotoolsToolchain
 from conan.tools.layout import basic_layout
 from conan.tools.microsoft import is_msvc, unix_path
 from conan.tools.scm import Version
 
-required_conan_version = ">=1.53.0"
+required_conan_version = ">=2"
 
 
 class SubunitConan(ConanFile):
@@ -33,17 +33,10 @@ class SubunitConan(ConanFile):
         "fPIC": True,
     }
 
-    @property
-    def _settings_build(self):
-        return getattr(self, "settings_build", self.settings)
-
     @property
     def _is_clang_cl(self):
         return self.settings.os == "Windows" and self.settings.compiler == "clang"
 
-    def export_sources(self):
-        export_conandata_patches(self)
-
     def config_options(self):
         if self.settings.os == "Windows":
             del self.options.fPIC
@@ -65,23 +58,22 @@ def validate(self):
             # Complete error is:
             # make[2]: *** No rule to make target `/Applications/Xcode-9.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Perl/5.18/darwin-thread-multi-2level/CORE/config.h', needed by `Makefile'.  Stop.
             raise ConanInvalidConfiguration("Due to weird make error involving missing config.h file in sysroot")
-        if self.settings.compiler == "apple-clang" and self.options.shared:
-            raise ConanInvalidConfiguration("Shared builds with apple-clang are not supported")
 
     def build_requirements(self):
-        if self._settings_build.os == "Windows":
+        if self.settings_build.os == "Windows":
             self.win_bash = True
             if not self.conf.get("tools.microsoft.bash:path", check_type=str):
                 self.tool_requires("msys2/cci.latest")
-        if is_msvc(self):
-            self.tool_requires("automake/1.16.5")
+        # version >=1.4.4 is kept on GitHub without configuration built
+        self.tool_requires("libtool/2.4.7")
+        self.tool_requires("automake/1.16.5")
+        if not self.conf.get("tools.gnu:pkg_config", check_type=str):
+            self.tool_requires("pkgconf/[>=2.2 <3]")
+
     def source(self):
         get(self, **self.conan_data["sources"][self.version], strip_root=True)
 
     def generate(self):
-        env = VirtualBuildEnv(self)
-        env.generate()
-
         if not cross_building(self):
             env = VirtualRunEnv(self)
             env.generate(scope="build")
@@ -134,9 +126,9 @@ def generate(self):
             env.vars(self).save_script("conanbuild_msvc")
 
     def build(self):
-        apply_conandata_patches(self)
         with chdir(self, self.source_folder):
             autotools = Autotools(self)
+            autotools.autoreconf()
             autotools.configure()
             autotools.make()
 
@@ -164,4 +156,4 @@ def package_info(self):
         self.cpp_info.components["libcppunit_subunit"].set_property("pkg_config_name", "libcppunit_subunit")
 
         bin_path = os.path.join(self.package_folder, "bin")
-        self.env_info.PATH.append(bin_path)
+        self.runenv_info.append_path("PATH", bin_path)

recipes/subunit/all/patches/0001-fix-ExtUtils-MakeMaker-error.patch

@@ -1,3 +1,3 @@
 versions:
-  "1.4.0":
+  "1.4.4":
     folder: "all"