Skip to content

Commit 4f7f508

Browse files
authored
ICU: Disable tests building (#28762)
* Disable tests building * Fix patch sources
1 parent 4b51fc2 commit 4f7f508

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

recipes/icu/all/conanfile.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,6 @@ def _settings_build(self):
6868
def _enable_icu_tools(self):
6969
return self.settings.os not in ["iOS", "tvOS", "watchOS", "Emscripten"]
7070

71-
@property
72-
def _with_unit_tests(self):
73-
return not self.conf.get("tools.build:skip_test", default=True, check_type=bool)
74-
7571
def export_sources(self):
7672
export_conandata_patches(self)
7773

@@ -151,7 +147,7 @@ def generate(self):
151147
"--disable-layoutex",
152148
"--disable-layout",
153149
f"--enable-tools={yes_no(self._enable_icu_tools)}",
154-
f"--enable-tests={yes_no(self._with_unit_tests)}",
150+
"--disable-tests",
155151
"--disable-samples",
156152
])
157153
if cross_building(self):
@@ -187,14 +183,12 @@ def generate(self):
187183
def _patch_sources(self):
188184
apply_conandata_patches(self)
189185

190-
if not self._with_unit_tests:
191-
# Prevent any call to python during configuration, it's only needed for unit tests
192-
replace_in_file(
186+
replace_in_file(
193187
self,
194188
os.path.join(self.source_folder, "source", "configure"),
195189
"if test -z \"$PYTHON\"",
196190
"if true",
197-
)
191+
)
198192

199193
if self._settings_build.os == "Windows":
200194
# https://unicode-org.atlassian.net/projects/ICU/issues/ICU-20545
@@ -229,8 +223,6 @@ def build(self):
229223
autotools = Autotools(self)
230224
autotools.configure(build_script_folder=os.path.join(self.source_folder, "source"))
231225
autotools.make()
232-
if self._with_unit_tests:
233-
autotools.make(target="check")
234226

235227
@property
236228
def _data_filename(self):

0 commit comments

Comments
 (0)