cyrus-sasl: add missing time.h header (#24003)

* cyrus-sasl: clang buildfix

* unused imports

* Revert conanfile.py changes

Signed-off-by: Uilian Ries <[email protected]>

* Avoid exposing author data

Signed-off-by: Uilian Ries <[email protected]>

* Do not touch configure.ac to avoid reconfigure

Signed-off-by: Uilian Ries <[email protected]>

* Revert "Do not touch configure.ac to avoid reconfigure"

This reverts commit 96da6a5.

* Run autoreconf due patch for time.h

Signed-off-by: Uilian Ries <[email protected]>

* Install aclocal as tool requirement

Signed-off-by: Uilian Ries <[email protected]>

* Avoid running autoreconf

Signed-off-by: Uilian Ries <[email protected]>

---------

Signed-off-by: Uilian Ries <[email protected]>
Co-authored-by: Uilian Ries <[email protected]>

Author: DenisRazinkin

recipes/cyrus-sasl/all/conandata.yml

@@ -7,6 +7,9 @@ sources:
     sha256: "26866b1549b00ffd020f188a43c258017fa1c382b3ddadd8201536f72efb05d5"
 patches:
   "2.1.28":
+    - patch_file: "patches/0001-Fix-time.h.patch"
+      patch_description: "patch"
+      patch_type: "portability"
     - patch_file: "patches/0001-use-attr-on-gnu.patch"
       patch_source: https://github.com/cyrusimap/cyrus-sasl/commit/06f41c41e5c0f62ed5c1d703a9e2da42dfdb71f6
       patch_description: "Fix https://github.com/cyrusimap/cyrus-sasl/issues/831"

recipes/cyrus-sasl/all/patches/0001-Fix-time.h.patch

@@ -0,0 +1,47 @@
+From 266f0acf7f5e029afbb3e263437039e50cd6c262 Mon Sep 17 00:00:00 2001
+From: Sam James <>
+Date: Wed, 23 Feb 2022 00:45:15 +0000
+Subject: [PATCH] Fix <time.h> check
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+We're conditionally including based on HAVE_TIME_H in a bunch of places,
+but we're not actually checking for time.h, so that's never going to be defined.
+
+While at it, add in a missing include in the cram plugin.
+
+This fixes a bunch of implicit declaration warnings:
+```
+ * cyrus-sasl-2.1.28/lib/saslutil.c:280:3: warning: implicit declaration of function ‘time’ [-Wimplicit-function-declaration]
+ * cyrus-sasl-2.1.28/lib/saslutil.c:364:41: warning: implicit declaration of function ‘clock’ [-Wimplicit-function-declaration]
+ * cyrus-sasl-2.1.28/plugins/cram.c:132:7: warning: implicit declaration of function ‘time’ [-Wimplicit-function-declaration]
+ * cyrus-sasl-2.1.28/lib/saslutil.c:280:3: warning: implicit declaration of function ‘time’ [-Wimplicit-function-declaration]
+ * cyrus-sasl-2.1.28/lib/saslutil.c:364:41: warning: implicit declaration of function ‘clock’ [-Wimplicit-function-declaration]
+ * cyrus-sasl-2.1.28/plugins/cram.c:132:7: warning: implicit declaration of function ‘time’ [-Wimplicit-function-declaration]
+```
+
+https://github.com/cyrusimap/cyrus-sasl/commit/266f0acf7f5e029afbb3e263437039e50cd6c262
+
+--- a/lib/saslutil.c
++++ b/lib/saslutil.c
+@@ -59,9 +59,7 @@
+ #ifdef HAVE_UNISTD_H
+ #include <unistd.h>
+ #endif
+-#ifdef HAVE_TIME_H
+ #include <time.h>
+-#endif
+ #include "saslint.h"
+ #include <saslutil.h>
+
+--- a/plugins/cram.c
++++ b/plugins/cram.c
+@@ -53,6 +53,7 @@
+ #endif
+ #include <fcntl.h>
+
++#include <time.h>
+ #include <sasl.h>
+ #include <saslplug.h>
+ #include <saslutil.h>