Merge pull request #377 from concourse/ibrahimparvez2/master

Enable Port Name overrides on web-api-service - Ibrahimparvez2/master

Author: taylorsilva

README.md

@@ -232,6 +232,8 @@ The following table lists the configurable parameters of the Concourse chart and
 | `web.service.api.loadBalancerSourceRanges` | Concourse Web API Service Load Balancer Source IP ranges | `nil` |
 | `web.service.api.tlsNodePort` | Sets the nodePort for api tls when using `NodePort` | `nil` |
 | `web.service.api.type` | Concourse Web API service type | `ClusterIP` |
+| `web.service.api.port.name` | Sets the port name for web service with `targetPort` `atc` | `atc` |
+| `web.service.api.tlsPort.name` | Sets the port name for web service with `targetPort` `atc-tls` | `atc-tls` |
 | `web.service.workerGateway.annotations` | Concourse Web workerGateway Service annotations | `nil` |
 | `web.service.workerGateway.labels` | Additional concourse web workerGateway service labels | `nil` |
 | `web.service.workerGateway.loadBalancerIP` | The IP to use when web.service.workerGateway.type is LoadBalancer | `nil` |

templates/web-api-svc.yaml

@@ -33,14 +33,14 @@ spec:
   loadBalancerIP: {{ .Values.web.service.api.loadBalancerIP }}
   {{- end }}
   ports:
-  - name: atc
+  - name: {{ .Values.web.service.api.port.name }}
     port: {{ .Values.concourse.web.bindPort }}
     targetPort: atc
     {{- if and (eq "NodePort" .Values.web.service.api.type) .Values.web.service.api.NodePort }}
     nodePort: {{ .Values.web.service.api.NodePort}}
     {{- end }}
 {{- if .Values.concourse.web.tls.enabled }}
-  - name: atc-tls
+  - name: {{ .Values.web.service.api.tlsPort.name }}
     port: {{ .Values.concourse.web.tls.bindPort }}
     targetPort: atc-tls
     {{- if and (eq "NodePort" .Values.web.service.api.type) .Values.web.service.api.tlsNodePort }}

values.yaml

@@ -2305,6 +2305,15 @@ web:
       ##
       tlsNodePort:
 
+      ## When using thirdy party service mesh providers such as istio, port
+      ## name ovverrides can be set to meet the default `http` naming convention
+      ##
+      port:
+        name: atc
+
+      tlsPort:
+        name: atc-tls
+
     workerGateway:
       ## For minikube, set this to ClusterIP, elsewhere use LoadBalancer or NodePort
       ## Ref: https://kubernetes.io/docs/user-guide/services/#publishing-services---service-types