Skip to content

Commit 6c50e6a

Browse files
committed
[ci skip] clean up some outdated comments
1 parent 5dc2376 commit 6c50e6a

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

recipe/meta.yaml

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ source:
5353
- patches/0010-avoid-deprecated-find_package-CUDA-in-caffe2-CMake-m.patch
5454
# backport https://github.com/pytorch/pytorch/pull/148668
5555
- patches/0011-Fix-CUPTI-lookup-to-include-target-directory.patch
56-
# skip a test that fails with numpy 2.3; can be dropped for pytorch>2.7
56+
# skip a test that fails with numpy v2.3; still triggers as of pytorch v2.9
5757
- patches/0012-skip-test_norm_matrix_degenerate_shapes-on-numpy-2.3.patch
5858
# backport https://github.com/pytorch/pytorch/pull/127702
5959
- patches/0013-Define-PY_SSIZE_T_CLEAN-before-include-Python.h.patch
@@ -165,9 +165,6 @@ requirements:
165165
run:
166166
- libblas * *{{ blas_impl }} # [blas_impl == "mkl"]
167167
run_constrained:
168-
# These constraints ensure conflict between pytorch and
169-
# pytorch-cpu 1.1 which we built before conda-forge had GPU infrastructure
170-
# built into place.
171168
# https://github.com/conda-forge/pytorch-cpu-feedstock/issues/65
172169
- pytorch-cpu {{ version }} # [cuda_compiler_version == "None"]
173170
- pytorch-gpu <0.0a0 # [cuda_compiler_version == "None"]
@@ -178,7 +175,7 @@ requirements:
178175
# if using OpenBLAS, ensure that a version compatible with OpenMP is used
179176
# otherwise, we get the following warnings:
180177
# OpenBLAS Warning : Detect OpenMP Loop and this application may hang. Please rebuild the library with USE_OPENMP=1 option.
181-
- libopenblas * openmp_* # [unix and blas_impl != "mkl"]
178+
- libopenblas * openmp_* # [unix and blas_impl != "mkl"]
182179
- openblas * openmp_* # [unix and blas_impl != "mkl"]
183180

184181
# these tests are for the libtorch output below, but due to
@@ -327,9 +324,6 @@ outputs:
327324
- sympy >=1.13.3
328325
- typing_extensions >=4.10.0
329326
run_constrained:
330-
# These constraints ensure conflict between pytorch and
331-
# pytorch-cpu 1.1 which we built before conda-forge had GPU infrastructure
332-
# built into place.
333327
# https://github.com/conda-forge/pytorch-cpu-feedstock/issues/65
334328
- pytorch-cpu {{ version }} # [cuda_compiler_version == "None"]
335329
- pytorch-gpu <0.0a0 # [cuda_compiler_version == "None"]
@@ -386,8 +380,6 @@ outputs:
386380
source_files:
387381
# Only include the source_files if we are actually going to run the tests.
388382
- test
389-
# tools/ is needed to optimise test run
390-
# as of pytorch=2.0.0, there is a bug when trying to run tests without the tools
391383
- tools
392384
commands:
393385
# Run pip check so as to ensure that all pytorch packages are installed
@@ -537,12 +529,8 @@ outputs:
537529
- cmake --build . # [unix]
538530
- cmake --build . --config Release # [win]
539531

540-
# 2021/08/01, hmaarrfk
541-
# While this seems like a roundabout way of defining the package name
542-
# It helps the linter avoid errors on a package not having tests.
543-
{% set pytorch_cpu_gpu = "pytorch-cpu" %} # [cuda_compiler_version == "None"]
544-
{% set pytorch_cpu_gpu = "pytorch-gpu" %} # [cuda_compiler_version != "None"]
545-
- name: {{ pytorch_cpu_gpu }}
532+
- name: pytorch-cpu # [cuda_compiler_version == "None"]
533+
- name: pytorch-gpu # [cuda_compiler_version != "None"]
546534
build:
547535
string: cuda{{ cuda_compiler_version | replace('.', '') }}_{{ blas_impl }}_h{{ PKG_HASH }}_{{ build }} # [cuda_compiler_version != "None"]
548536
string: cpu_{{ blas_impl }}_h{{ PKG_HASH }}_{{ build }} # [cuda_compiler_version == "None"]

0 commit comments

Comments
 (0)