Skip to content

Tensorpipe support on windowsΒ #334

@h-vetinari

Description

@h-vetinari

While digging around upstream I stumbled over

  if(USE_TENSORPIPE)
    target_compile_definitions(torch_python PRIVATE USE_TENSORPIPE)
  endif()

We're already installing tensorpipe on unix

mv build/lib.*/torch/include/{ATen,caffe2,tensorpipe,torch,c10} ${PREFIX}/include/

but not setting it explicitly. At least during the main build, it seems to default to true on unix, as I see

USE_TENSORPIPE        : ON

On windows though, it's

USE_TENSORPIPE        : OFF

Once we have CMake tests (c.f. #333), we can also add this there, because the following metadata gets installed already

share/cmake/Tensorpipe/TensorpipeTargets-release.cmake
share/cmake/Tensorpipe/TensorpipeTargets.cmake

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions