Skip to content

Comments

Add net-snmp#31200

Open
simon-ess wants to merge 6 commits intoconda-forge:mainfrom
simon-ess:net-snmp-recipe
Open

Add net-snmp#31200
simon-ess wants to merge 6 commits intoconda-forge:mainfrom
simon-ess:net-snmp-recipe

Conversation

@simon-ess
Copy link

@simon-ess simon-ess commented Oct 9, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 9, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/net-snmp-feedstock/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/net-snmp-feedstock/recipe.yaml:

  • ❌ The license item is expected in the about section.
  • ❌ The recipe must have some tests.
  • ❌ There are too few lines. There should be one empty line at the end of the file.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18378493678. Examine the logs at this URL for more detail.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/net-snmp-feedstock/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/net-snmp-feedstock/recipe.yaml:

  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18399666937. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/net-snmp-feedstock/recipe.yaml) and found it was in an excellent condition.

@simon-ess
Copy link
Author

@conda-forge/help-c-cpp, ready for review!

@simon-ess simon-ess force-pushed the net-snmp-recipe branch 4 times, most recently from 2560e5c to c8d2995 Compare October 15, 2025 06:56
@simon-ess
Copy link
Author

@conda-forge/staged-recipes @conda-forge/help-c-cpp, ready for review!

@github-actions
Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@simon-ess simon-ess force-pushed the net-snmp-recipe branch 3 times, most recently from d7b6e96 to 91e3a84 Compare October 22, 2025 11:25
@traversaro
Copy link
Contributor

It seems that the CI is failing, is this expected?

@simon-ess
Copy link
Author

I have been meaning to get back to this :/

The CI tests are failing, but it isn't clear to me exactly why. The test pass locally so...

@traversaro
Copy link
Contributor

The test pass locally so...

Did you tried with the build-locally.py python script?

I have been meaning to get back to this :/

When this is ready, feel free to ping the help team again, so the label review-requested is added again.

@simon-ess
Copy link
Author

@conda-forge/staged-recipes @conda-forge/help-c-cpp, ready for review again.

Note that I have removed the make test stage in the build script. This is for two reasons:

  • The tests pass locally but I am not able to make them pass in the github pipelines
  • This isn't really even the correct location to be performing tests; it would presumably be better to set up a separate test stage, which would take a bit more work given how the build configuration is currently set up, and feels like an inappropriate blocker to getting this released. Some issues have been created on the upstream repository, at least in regards to tests failing in newer versions.

Given that the tests did not appear to be a hard requirement for a pass, I would like to request a revew of this recipe as it stands.

@github-actions
Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 19, 2026

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/net-snmp/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/net-snmp/recipe.yaml:

  • ❌ pin_compatible should be used instead of pin_subpackage for ${{ because it is not a known output of this recipe: ['net-snmp'].

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22185158737. Examine the logs at this URL for more detail.

build:
skip:
- win
- osx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- osx

Why is macOS being skipped? If it's failing please enable it so we can see what is wrong and potentially fix it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it is failing, and the build doesn't seem to want to run locally either, but for different reasons. I'd rather remove it for now and fix it later.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/net-snmp/recipe.yaml) and found it was in an excellent condition.

@anderslindho
Copy link
Contributor

@danielnachun @traversaro could you please check in again on this PR? We are waiting for the completion of this; we have downstream things that need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants