Update dependencies with conda self update --all (#84)

* Allow passing --update-deps into install command

* Improve typing in update tests

* Add news

* Apply suggestions from code review

Co-authored-by: Jannis Leidel <jannis@leidel.info>

* Use --all to update dependencies

* Remove obsolete test

---------

Co-authored-by: Jannis Leidel <jannis@leidel.info>

Author: marcoesters

conda_self/cli/main_update.py

@@ -30,7 +30,7 @@ def configure_parser(parser: argparse.ArgumentParser) -> None:
     update_group.add_argument(
         "--all",
         action="store_true",
-        help="Update conda and all plugins.",
+        help="Update conda, all plugins, and dependencies.",
     )
     parser.set_defaults(func=execute)
 
@@ -66,9 +66,14 @@ def execute(args: argparse.Namespace) -> int:
             print(f"Installed {package_name}: {installed.version}")
             print(f"Latest {package_name}: {latest.version}")
 
-        if not update_available and not args.force_reinstall:
+        if not update_available and not args.force_reinstall and not args.all:
             print(f"{package_name} is already using the latest version available!")
         else:
+            if not update_available and args.all:
+                print(
+                    f"{package_name} is using the latest version available, "
+                    "but may have outdated dependencies."
+                )
             updates[package_name] = latest.version
 
     if args.dry_run:
@@ -80,4 +85,5 @@ def execute(args: argparse.Namespace) -> int:
         packages=updates,
         channel=channel,
         force_reinstall=args.force_reinstall,
+        update_dependencies=args.all,
     )

conda_self/install.py

@@ -9,20 +9,23 @@ def install_package_in_protected_env(
     package_version: str,
     channel: str,
     force_reinstall: bool = False,
+    update_dependencies: bool = False,
     json: bool = False,
 ) -> int:
     return install_package_list_in_protected_env(
         {package_name: package_version},
         channel,
-        force_reinstall,
-        json,
+        force_reinstall=force_reinstall,
+        update_dependencies=update_dependencies,
+        json=json,
     )
 
 
 def install_package_list_in_protected_env(
     packages: dict[str, str],
     channel: str,
     force_reinstall: bool = False,
+    update_dependencies: bool = False,
     json: bool = False,
 ) -> int:
     specs = [f"{name}={version}" for name, version in packages.items()]
@@ -40,7 +43,7 @@ def install_package_list_in_protected_env(
             ),
             *(("--force-reinstall",) if force_reinstall else ()),
             *(("--json",) if json else ()),
-            "--update-specs",
+            "--all" if update_dependencies else "--update-specs",
             "--override-channels",
             f"--channel={channel}",
             *specs,

news/84-update-deps

@@ -0,0 +1,19 @@
+### Enhancements
+
+* Expand `conda self update --all` to also update all dependencies. (#80 via #84)
+
+### Bug fixes
+
+* <news item>
+
+### Deprecations
+
+* <news item>
+
+### Docs
+
+* <news item>
+
+### Other
+
+* <news item>

tests/test_cli_update.py

@@ -18,7 +18,7 @@
     from pytest_mock import MockerFixture
 
 
-def test_help(conda_cli):
+def test_help(conda_cli: CondaCLIFixture):
     out, err, exc = conda_cli("self", "update", "--help", raises=SystemExit)
     assert exc.value.code == 0
 
@@ -43,7 +43,9 @@ def test_help(conda_cli):
         ),
     ),
 )
-def test_update_conda(conda_cli, mocker, latest_version, message):
+def test_update_conda(
+    conda_cli: CondaCLIFixture, mocker: MockerFixture, latest_version: str, message: str
+):
     mocker.patch.object(
         query,
         "latest",
@@ -63,7 +65,9 @@ def test_update_conda(conda_cli, mocker, latest_version, message):
 @pytest.mark.parametrize(
     "plugin_name,ok", (("conda-libmamba-solver", True), ("conda-fake-solver", False))
 )
-def test_update_plugin(conda_cli, plugin_name, ok):
+def test_update_plugin(
+    conda_cli: CondaCLIFixture, plugin_name: str, ok: tuple[str, bool]
+):
     conda_cli(
         "self",
         "update",
@@ -83,8 +87,14 @@ def test_update_plugin(conda_cli, plugin_name, ok):
                 "conda-libmamba-solver": clms_version,
             },
             (
-                "conda is already using the latest version available!",
-                "conda-libmamba-solver is already using the latest version available!",
+                (
+                    "conda is using the latest version "
+                    "available, but may have outdated dependencies."
+                ),
+                (
+                    "conda-libmamba-solver is using the latest version "
+                    "available, but may have outdated dependencies."
+                ),
             ),
             id="No updates",
         ),
@@ -94,7 +104,10 @@ def test_update_plugin(conda_cli, plugin_name, ok):
                 "conda-libmamba-solver": "2080",
             },
             (
-                "conda is already using the latest version available!",
+                (
+                    "conda is using the latest version "
+                    "available, but may have outdated dependencies."
+                ),
                 "Latest conda-libmamba-solver: 2080",
             ),
             id="Update one",