Remove frozen environment protection files during uninstallation (#180)

* Add functionality to find and remove frozen files

* Optimize frozen file search

* First pass at testing frozen file removal

* First pass at testing frozen file removal

* Move out of main function

* Handle potential permissions errors

* Add test_uninstallation_frozen_environment

* Test across multiple frozen environments

* Remove old code

* Setup custom envs dir

* Add news file

* Apply suggestions from code review

Co-authored-by: Marco Esters <mesters@anaconda.com>

* Leverage existing env dir detection

* Revert to testing only one environment

* Use tmp_env instead of conda_cli

* Apply suggestions from code review

Co-authored-by: Marco Esters <mesters@anaconda.com>

---------

Co-authored-by: Marco Esters <mesters@anaconda.com>

Author: Jrice1317

news/180-remove-frozen-files

@@ -0,0 +1,19 @@
+### Enhancements
+
+* Remove frozen environment protection files before environment removal during uninstallation. (#180)
+
+### Bug fixes
+
+* <news item>
+
+### Deprecations
+
+* <news item>
+
+### Docs
+
+* <news item>
+
+### Other
+
+* <news item>

src/conda_constructor/uninstall.py

@@ -4,7 +4,7 @@
 from pathlib import Path
 from shutil import rmtree
 
-from conda.base.constants import COMPATIBLE_SHELLS, PREFIX_MAGIC_FILE
+from conda.base.constants import COMPATIBLE_SHELLS, PREFIX_FROZEN_FILE, PREFIX_MAGIC_FILE
 from conda.base.context import context, reset_context
 from conda.cli.main import main as conda_main
 from conda.common.compat import on_win
@@ -32,7 +32,7 @@ def _is_subdir(directory: Path, root: Path) -> bool:
     return directory == root or root in directory.parents
 
 
-def _remove_file_directory(file: Path):
+def _remove_file_directory(file: Path, raise_on_error: bool = False):
     """
     Try to remove a file or directory.
 
@@ -45,8 +45,12 @@ def _remove_file_directory(file: Path):
             rmtree(file)
         elif file.is_symlink() or file.is_file():
             file.unlink()
-    except PermissionError:
-        pass
+    except PermissionError as e:
+        if raise_on_error:
+            raise PermissionError(
+                f"Could not remove {file}. "
+                "You may need to re-run with elevated privileges or manually remove this file."
+            ) from e
 
 
 def _remove_config_file_and_parents(file: Path):
@@ -201,6 +205,11 @@ def _remove_environments(prefix: Path, prefixes: list[Path]):
     # Otherwise, parent environments will delete the environment directory and
     # uninstallation logic (removing shortcuts, pre-unlink scripts, etc.) cannot be run.
     for env_prefix in reversed(prefixes):
+        # Unprotect frozen environments first
+        frozen_file = env_prefix / PREFIX_FROZEN_FILE
+        if frozen_file.is_file():
+            _remove_file_directory(frozen_file, raise_on_error=True)
+
         install_shortcut(env_prefix, root_prefix=menuinst_base_prefix, remove=True)
         # If conda_root_prefix is the same as prefix, conda remove will not be able
         # to remove that environment, so temporarily unset it.

tests/test_uninstall.py

@@ -9,7 +9,7 @@
 from typing import TYPE_CHECKING
 
 import pytest
-from conda.base.constants import COMPATIBLE_SHELLS
+from conda.base.constants import COMPATIBLE_SHELLS, PREFIX_FROZEN_FILE
 from conda.common.path import win_path_to_unix
 from conda.core.initialize import (
     Result,
@@ -114,6 +114,24 @@ def test_uninstallation(
         assert str(base_env) not in environments and str(second_env) in environments
 
 
+def test_uninstallation_frozen_environment(
+    tmp_env: TmpEnvFixture,
+):
+    """Test that frozen environments are removed during uninstallation."""
+    with tmp_env() as frozen_env:
+        # Create frozen file in the environment
+        frozen_file = frozen_env / PREFIX_FROZEN_FILE
+        frozen_file.touch()
+        assert frozen_file.exists()
+
+        # Run uninstaller on the environment
+        run_uninstaller(frozen_env)
+
+        # Verify frozen file and environment are removed
+        assert not frozen_file.exists()
+        assert not frozen_env.exists()
+
+
 @pytest.mark.parametrize("remove", (True, False), ids=("remove directory", "keep directory"))
 def test_uninstallation_envs_dirs(
     mock_system_paths: dict[str, Path],