Skip to content

Commit 886e7ad

Browse files
feat(api): api update (#43)
1 parent f4724e0 commit 886e7ad

File tree

3 files changed

+23
-19
lines changed

3 files changed

+23
-19
lines changed

.stats.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
configured_endpoints: 165
2-
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/conductor%2Fconductor-8c60db6402b06938360570eb16c42f6393e21efff5a6c829b16a489d5014fa12.yml
2+
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/conductor%2Fconductor-d102b25effab50507103206c7c7d0d4df86e901788d289c94fcfe1b6eb000dc0.yml

src/resources/qbd/time-tracking-activities.ts

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -132,13 +132,13 @@ export interface TimeTrackingActivity {
132132
* activity, they are not returned in responses since QuickBooks Desktop's UI does
133133
* not display seconds.
134134
*
135-
* **NOTE**: This field is required for every update request, even if it is not
136-
* being updated, because of a bug in QuickBooks itself.
135+
* **NOTE**: This field is required for updating time tracking activities, even if
136+
* the field is not being updated, because of a bug in QuickBooks itself.
137137
*/
138138
duration: string;
139139

140140
/**
141-
* The employee, vendor, or person on QuickBooks's Other Names list whose time is
141+
* The employee, vendor, or person on QuickBooks's "Other Names" list whose time is
142142
* being tracked in this time tracking activity. This cannot refer to a customer -
143143
* use the `customer` field to associate a customer or customer-job with this time
144144
* tracking activity.
@@ -250,7 +250,7 @@ export namespace TimeTrackingActivity {
250250
}
251251

252252
/**
253-
* The employee, vendor, or person on QuickBooks's Other Names list whose time is
253+
* The employee, vendor, or person on QuickBooks's "Other Names" list whose time is
254254
* being tracked in this time tracking activity. This cannot refer to a customer -
255255
* use the `customer` field to associate a customer or customer-job with this time
256256
* tracking activity.
@@ -352,13 +352,13 @@ export interface TimeTrackingActivityCreateParams {
352352
* activity, they are not returned in responses since QuickBooks Desktop's UI does
353353
* not display seconds.
354354
*
355-
* **NOTE**: This field is required for every update request, even if it is not
356-
* being updated, because of a bug in QuickBooks itself.
355+
* **NOTE**: This field is required for updating time tracking activities, even if
356+
* the field is not being updated, because of a bug in QuickBooks itself.
357357
*/
358358
duration: string;
359359

360360
/**
361-
* Body param: The employee, vendor, or person on QuickBooks's Other Names list
361+
* Body param: The employee, vendor, or person on QuickBooks's "Other Names" list
362362
* whose time is being tracked in this time tracking activity. This cannot refer to
363363
* a customer - use the `customer` field to associate a customer or customer-job
364364
* with this time tracking activity.
@@ -453,11 +453,22 @@ export interface TimeTrackingActivityUpdateParams {
453453
* activity, they are not returned in responses since QuickBooks Desktop's UI does
454454
* not display seconds.
455455
*
456-
* **NOTE**: This field is required for every update request, even if it is not
457-
* being updated, because of a bug in QuickBooks itself.
456+
* **NOTE**: This field is required for updating time tracking activities, even if
457+
* the field is not being updated, because of a bug in QuickBooks itself.
458458
*/
459459
duration: string;
460460

461+
/**
462+
* Body param: The employee, vendor, or person on QuickBooks's "Other Names" list
463+
* whose time is being tracked in this time tracking activity. This cannot refer to
464+
* a customer - use the `customer` field to associate a customer or customer-job
465+
* with this time tracking activity.
466+
*
467+
* **NOTE**: This field is required for updating time tracking activities, even if
468+
* the field is not being updated, because of a bug in QuickBooks itself.
469+
*/
470+
entityId: string;
471+
461472
/**
462473
* Body param: The current QuickBooks-assigned revision number of the time tracking
463474
* activity object you are updating, which you can get by fetching the object
@@ -494,14 +505,6 @@ export interface TimeTrackingActivityUpdateParams {
494505
*/
495506
customerId?: string;
496507

497-
/**
498-
* Body param: The employee, vendor, or person on QuickBooks's “Other Names” list
499-
* whose time is being tracked in this time tracking activity. This cannot refer to
500-
* a customer - use the `customer` field to associate a customer or customer-job
501-
* with this time tracking activity.
502-
*/
503-
entityId?: string;
504-
505508
/**
506509
* Body param: A note or comment about this time tracking activity.
507510
*/

tests/api-resources/qbd/time-tracking-activities.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ describe('resource timeTrackingActivities', () => {
6363
test('update: only required params', async () => {
6464
const responsePromise = client.qbd.timeTrackingActivities.update('123ABC-1234567890', {
6565
duration: 'PT1H30M',
66+
entityId: '80000001-1234567890',
6667
revisionNumber: '1721172183',
6768
conductorEndUserId: 'end_usr_1234567abcdefg',
6869
});
@@ -78,12 +79,12 @@ describe('resource timeTrackingActivities', () => {
7879
test('update: required and optional params', async () => {
7980
const response = await client.qbd.timeTrackingActivities.update('123ABC-1234567890', {
8081
duration: 'PT1H30M',
82+
entityId: '80000001-1234567890',
8183
revisionNumber: '1721172183',
8284
conductorEndUserId: 'end_usr_1234567abcdefg',
8385
billingStatus: 'billable',
8486
classId: '80000001-1234567890',
8587
customerId: '80000001-1234567890',
86-
entityId: '80000001-1234567890',
8788
note: 'Project planning meeting with client.',
8889
payrollWageItemId: '80000001-1234567890',
8990
serviceItemId: '80000001-1234567890',

0 commit comments

Comments
 (0)