Compatibility with gen_stage v0.14+

[xward]

In most of my recent project, I can't use conduit_sqs since it is using gen_stage v0.14+ and conduit forbid it using v0.13.1.

Any plan to upgrade ? Thx !

[blatyo]

Sure, send a PR that adds or ~> 0.14.0 to the requirements. I'm assuming there were no backwards incompatible changes between the versions?

[xward]

Actually that was my plan first, but then when you run tests you have:

warning: conflicting behaviours found. function terminate/2 is required by GenStage and GenStage (in module ConduitSQS.Poller)
  lib/conduit_sqs/poller.ex:1

warning: conflicting behaviours found. function init/1 is required by GenStage and GenStage (in module ConduitSQS.Poller)
  lib/conduit_sqs/poller.ex:1

warning: conflicting behaviours found. function handle_subscribe/4 is required by GenStage and GenStage (in module ConduitSQS.Poller)
  lib/conduit_sqs/poller.ex:1

warning: conflicting behaviours found. function handle_info/2 is required by GenStage and GenStage (in module ConduitSQS.Poller)
  lib/conduit_sqs/poller.ex:1

warning: conflicting behaviours found. function handle_events/3 is required by GenStage and GenStage (in module ConduitSQS.Poller)
  lib/conduit_sqs/poller.ex:1

warning: conflicting behaviours found. function handle_demand/2 is required by GenStage and GenStage (in module ConduitSQS.Poller)
  lib/conduit_sqs/poller.ex:1

warning: conflicting behaviours found. function handle_cast/2 is required by GenStage and GenStage (in module ConduitSQS.Poller)
  lib/conduit_sqs/poller.ex:1

warning: conflicting behaviours found. function handle_cancel/3 is required by GenStage and GenStage (in module ConduitSQS.Poller)
  lib/conduit_sqs/poller.ex:1

warning: conflicting behaviours found. function handle_call/3 is required by GenStage and GenStage (in module ConduitSQS.Poller)
  lib/conduit_sqs/poller.ex:1

warning: conflicting behaviours found. function format_status/2 is required by GenStage and GenStage (in module ConduitSQS.Poller)
  lib/conduit_sqs/poller.ex:1

warning: conflicting behaviours found. function code_change/3 is required by GenStage and GenStage (in module ConduitSQS.Poller)
  lib/conduit_sqs/poller.ex:1

warning: conflicting behaviours found. function terminate/2 is required by GenStage and GenStage (in module ConduitSQS.Worker)
  lib/conduit_sqs/worker.ex:1

warning: conflicting behaviours found. function init/1 is required by GenStage and GenStage (in module ConduitSQS.Worker)
  lib/conduit_sqs/worker.ex:1

warning: conflicting behaviours found. function handle_subscribe/4 is required by GenStage and GenStage (in module ConduitSQS.Worker)
  lib/conduit_sqs/worker.ex:1

warning: conflicting behaviours found. function handle_info/2 is required by GenStage and GenStage (in module ConduitSQS.Worker)
  lib/conduit_sqs/worker.ex:1

warning: conflicting behaviours found. function handle_events/3 is required by GenStage and GenStage (in module ConduitSQS.Worker)
  lib/conduit_sqs/worker.ex:1

warning: conflicting behaviours found. function handle_demand/2 is required by GenStage and GenStage (in module ConduitSQS.Worker)
  lib/conduit_sqs/worker.ex:1

warning: conflicting behaviours found. function handle_cast/2 is required by GenStage and GenStage (in module ConduitSQS.Worker)
  lib/conduit_sqs/worker.ex:1

warning: conflicting behaviours found. function handle_cancel/3 is required by GenStage and GenStage (in module ConduitSQS.Worker)
  lib/conduit_sqs/worker.ex:1

warning: conflicting behaviours found. function handle_call/3 is required by GenStage and GenStage (in module ConduitSQS.Worker)
  lib/conduit_sqs/worker.ex:1

warning: conflicting behaviours found. function format_status/2 is required by GenStage and GenStage (in module ConduitSQS.Worker)
  lib/conduit_sqs/worker.ex:1

warning: conflicting behaviours found. function code_change/3 is required by GenStage and GenStage (in module ConduitSQS.Worker)
  lib/conduit_sqs/worker.ex:1

So it would go depper than that.

[blatyo]

Looks like use GenStage starting setting @behaviour GenStage. If you want to submit a PR that removes the @behaviour from both of those modules, it seems like it would fix that.

[xward]

Yep indeed, (cf PR: #5).
But other warning appear if you still works with gen_stage v0.13+, like:

warning: got "@impl true" for function init/1 but no behaviour was declared
  lib/conduit_sqs/poller.ex:41

warning: got "@impl true" for function handle_demand/2 but no behaviour was declared
  lib/conduit_sqs/poller.ex:60

warning: got "@impl true" for function handle_info/2 but no behaviour was declared
  lib/conduit_sqs/poller.ex:74

warning: got "@impl true" for function init/1 but no behaviour was declared
  lib/conduit_sqs/worker.ex:31

warning: got "@impl true" for function handle_events/3 but no behaviour was declared
  lib/conduit_sqs/worker.ex:56

warning: got "@impl true" for function handle_info/2 but no behaviour was declared
  lib/conduit_sqs/worker.ex:65

Thus I've put:
{:gen_stage, "~> 0.14.0"},

[blatyo]

v0.3.0 has your changes in it