Refactor serializer implementations to remove unnecessary ContinueWith calls (#2448)

Co-authored-by: Robert Yokota <[email protected]>

Author: Havret

src/Confluent.SchemaRegistry.Serdes.Avro/GenericSerializerImpl.cs

@@ -165,9 +165,8 @@ public async Task<byte[]> Serialize(string topic, Headers headers, GenericRecord
                     {
                         return await AvroUtils.Transform(ctx, writerSchema, message, transform).ConfigureAwait(false);
                     };
-                    data = await ExecuteRules(isKey, subject, topic, headers, RuleMode.Write, null,
+                    data = (GenericRecord) await ExecuteRules(isKey, subject, topic, headers, RuleMode.Write, null,
                         latestSchema, data, fieldTransformer)
-                        .ContinueWith(t => (GenericRecord)t.Result)
                         .ConfigureAwait(continueOnCapturedContext: false);
                 }
 

src/Confluent.SchemaRegistry.Serdes.Avro/SpecificSerializerImpl.cs

@@ -206,9 +206,8 @@ public async Task<byte[]> Serialize(string topic, Headers headers, T data, bool
                     {
                         return await AvroUtils.Transform(ctx, schema, message, transform).ConfigureAwait(false);
                     };
-                    data = await ExecuteRules(isKey, subject, topic, headers, RuleMode.Write, null,
+                    data = (T) await ExecuteRules(isKey, subject, topic, headers, RuleMode.Write, null,
                         latestSchema, data, fieldTransformer)
-                        .ContinueWith(t => (T) t.Result)
                         .ConfigureAwait(continueOnCapturedContext: false);
                 }
 

src/Confluent.SchemaRegistry.Serdes.Json/JsonSerializer.cs

@@ -242,10 +242,9 @@ public override async Task<byte[]> SerializeAsync(T value, SerializationContext
                     {
                         return await JsonUtils.Transform(ctx, parsedSchema, "$", message, transform).ConfigureAwait(false);
                     };
-                    value = await ExecuteRules(context.Component == MessageComponentType.Key, subject,
+                    value = (T) await ExecuteRules(context.Component == MessageComponentType.Key, subject,
                             context.Topic, context.Headers, RuleMode.Write, null,
                             latestSchema, value, fieldTransformer)
-                        .ContinueWith(t => (T)t.Result)
                         .ConfigureAwait(continueOnCapturedContext: false);
                 }
                 else

src/Confluent.SchemaRegistry.Serdes.Protobuf/ProtobufSerializer.cs

@@ -301,10 +301,10 @@ await RegisterOrGetReferences(value.Descriptor.File, context, autoRegisterSchema
                     {
                         return await ProtobufUtils.Transform(ctx, fdSet, message, transform).ConfigureAwait(false);
                     };
-                    value = await ExecuteRules(context.Component == MessageComponentType.Key, subject,
+                    value = (T) await ExecuteRules(context.Component == MessageComponentType.Key, subject,
                             context.Topic, context.Headers, RuleMode.Write, null,
                             latestSchema, value, fieldTransformer)
-                        .ContinueWith(t => (T)t.Result).ConfigureAwait(continueOnCapturedContext: false);
+                        .ConfigureAwait(continueOnCapturedContext: false);
                 }
 
                 using (var stream = new MemoryStream(initialBufferSize))