Limit splitting auth info to a max of 2 parts (#1880)

luismedel · web-flow · commit 6610aa720f90 · 2022-09-06T15:07:40.000+05:30
Auth info after the first colon must be considered as the password.
See IETF's rfc7617 (Basic Auth) for more details.
diff --git a/src/Confluent.SchemaRegistry/CachedSchemaRegistryClient.cs b/src/Confluent.SchemaRegistry/CachedSchemaRegistryClient.cs
@@ -164,7 +164,7 @@ public CachedSchemaRegistryClient(IEnumerable<KeyValuePair<string, string>> conf
             {
                 if (basicAuthInfo != "")
                 {
-                    var userPass = (basicAuthInfo).Split(':');
+                    var userPass = basicAuthInfo.Split(new char[] { ':' }, 2);
                     if (userPass.Length != 2)
                     {
                         throw new ArgumentException($"Configuration property {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthUserInfo} must be of the form 'username:password'.");

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ public CachedSchemaRegistryClient(IEnumerable<KeyValuePair<string, string>> conf`
`164`	`164`	`{`
`165`	`165`	`if (basicAuthInfo != "")`
`166`	`166`	`{`
`167`		`- var userPass = (basicAuthInfo).Split(':');`
	`167`	`+ var userPass = basicAuthInfo.Split(new char[] { ':' }, 2);`
`168`	`168`	`if (userPass.Length != 2)`
`169`	`169`	`{`
`170`	`170`	`throw new ArgumentException($"Configuration property {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthUserInfo} must be of the form 'username:password'.");`