removed CompilerServices.Unsafe dependency (#813)

Author: mhowlett

src/Confluent.Kafka/Confluent.Kafka.csproj

@@ -22,7 +22,6 @@
     <PackageReference Include="librdkafka.redist" Version="1.0.0-RC7">
         <PrivateAssets Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">None</PrivateAssets>
     </PackageReference>
-    <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="4.5.0" />
     <PackageReference Include="System.Memory" Version="4.5.0" />
   </ItemGroup>
 

src/Confluent.Kafka/Consumer.cs

@@ -600,9 +600,9 @@ public List<TopicPartitionOffset> Position(IEnumerable<TopicPartition> partition
         /// </exception>
         public List<TopicPartitionOffset> OffsetsForTimes(IEnumerable<TopicPartitionTimestamp> timestampsToSearch, TimeSpan timeout)
             // TODO: use a librdkafka queue for this.
-            => kafkaHandle.OffsetsForTimes(timestampsToSearch, timeout.TotalMillisecondsAsInt());
-
-
+            => kafkaHandle.OffsetsForTimes(timestampsToSearch, timeout.TotalMillisecondsAsInt());
+
+
         /// <summary>
         ///     Get the last cached low (oldest available/beginning) and high (newest/end)
         ///     offsets for a topic/partition. Does not block.
@@ -893,7 +893,7 @@ private ConsumeResult<K, V> ConsumeImpl<K,V>(
 
             try
             {
-                var msg = Util.Marshal.PtrToStructureUnsafe<rd_kafka_message>(msgPtr);
+                var msg = Util.Marshal.PtrToStructure<rd_kafka_message>(msgPtr);
 
                 string topic = null;
                 if (this.enableTopicNameMarshaling)

src/Confluent.Kafka/Internal/Util.cs

@@ -17,7 +17,6 @@
 using System;
 using System.Text;
 using SystemMarshal = System.Runtime.InteropServices.Marshal;
-using Unsafe = System.Runtime.CompilerServices.Unsafe;
 
 
 namespace Confluent.Kafka.Internal
@@ -50,23 +49,6 @@ public unsafe static string PtrToStringUTF8(IntPtr strPtr)
 #endif
             }
 
-            /// <summary>
-            ///     Reinterpret_cast without strings marshaling
-            /// </summary>
-            /// <typeparam name="T">
-            ///     Type of struct to cast
-            /// </typeparam>
-            /// <param name="ptr">
-            ///     Raw pointer to use
-            /// </param>
-            /// <returns>
-            ///     A value of type <typeparamref name="T"/>
-            /// </returns>
-            public static unsafe T PtrToStructureUnsafe<T>(IntPtr ptr)
-            {
-                return Unsafe.Read<T>(ptr.ToPointer());
-            }
-
             public static T PtrToStructure<T>(IntPtr ptr)
             {
 #if NET45

src/Confluent.Kafka/Producer.cs

@@ -133,7 +133,7 @@ private void DeliveryReportCallbackImpl(IntPtr rk, IntPtr rkmessage, IntPtr opaq
             // Ensure registered handlers are never called as a side-effect of Dispose/Finalize (prevents deadlocks in common scenarios).
             if (ownedKafkaHandle.IsClosed) { return; }
 
-            var msg = Util.Marshal.PtrToStructureUnsafe<rd_kafka_message>(rkmessage);
+            var msg = Util.Marshal.PtrToStructure<rd_kafka_message>(rkmessage);
 
             // the msg._private property has dual purpose. Here, it is an opaque pointer set
             // by Topic.Produce to be an IDeliveryHandler. When Consuming, it's for internal