Skip to content

Commit 6c3df62

Browse files
authored
remove non-serializing Producer and Consumer classes (#760)
* added SchemaRegistryConfigBasicAuthCredentialsSource * review changes * actually ran the integration tests this time * badly formatted xml comment fix * remove base classes + byte[] clients * removed ProducerCore (base) * delivery handler -> internal * internal -> private * removed pointless summaries * remove out of date commnet
1 parent e072176 commit 6c3df62

File tree

64 files changed

+1808
-2805
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+1808
-2805
lines changed

src/ConfigGen/Program.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,9 +436,9 @@ public ConsumerConfig() {}
436436
437437
/// <summary>
438438
/// A comma separated list of fields that may be optionally set
439-
/// in <see cref=""Confluent.Kafka.ConsumeResult{TKey, TValue}"" />
439+
/// in <see cref=""Confluent.Kafka.ConsumeResult{TKey,TValue}"" />
440440
/// objects returned by the
441-
/// <see cref=""Confluent.Kafka.Consumer.Consume(System.TimeSpan)"" />
441+
/// <see cref=""Confluent.Kafka.Consumer{TKey,TValue}.Consume(System.TimeSpan)"" />
442442
/// method. Disabling fields that you do not require will improve
443443
/// throughput and reduce memory consumption. Allowed values:
444444
/// headers, timestamp, topic, all, none

src/Confluent.Kafka/AdminClient.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ internal AdminClient(AdminClientBuilder builder)
485485
}
486486

487487
// build a producer instance to use as the underlying client.
488-
var producerBuilder = new ProducerBuilder(config);
488+
var producerBuilder = new ProducerBuilder<Null, Null>(config);
489489
if (builder.LogHandler != null) { producerBuilder.SetLogHandler((_, logMessage) => builder.LogHandler(this, logMessage)); }
490490
if (builder.ErrorHandler != null) { producerBuilder.SetErrorHandler((_, error) => builder.ErrorHandler(this, error)); }
491491
if (builder.StatisticsHandler != null) { producerBuilder.SetStatisticsHandler((_, stats) => builder.StatisticsHandler(this, stats)); }

src/Confluent.Kafka/ConfigPropertyNames.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@ public static class Consumer
6666
{
6767
/// <summary>
6868
/// A comma separated list of fields that may be optionally set
69-
/// in <see cref="Confluent.Kafka.ConsumeResult{TKey, TValue}" />
69+
/// in <see cref="Confluent.Kafka.ConsumeResult{TKey,TValue}" />
7070
/// objects returned by the
71-
/// <see cref="Confluent.Kafka.Consumer.Consume(System.TimeSpan)" />
71+
/// <see cref="Confluent.Kafka.Consumer{TKey,TValue}.Consume(System.TimeSpan)" />
7272
/// method. Disabling fields that you do not require will improve
7373
/// throughput and reduce memory consumption. Allowed values:
7474
/// headers, timestamp, topic, all, none

src/Confluent.Kafka/Config_gen.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -876,9 +876,9 @@ public ConsumerConfig() {}
876876

877877
/// <summary>
878878
/// A comma separated list of fields that may be optionally set
879-
/// in <see cref="Confluent.Kafka.ConsumeResult{TKey, TValue}" />
879+
/// in <see cref="Confluent.Kafka.ConsumeResult{TKey,TValue}" />
880880
/// objects returned by the
881-
/// <see cref="Confluent.Kafka.Consumer.Consume(System.TimeSpan)" />
881+
/// <see cref="Confluent.Kafka.Consumer{TKey,TValue}.Consume(System.TimeSpan)" />
882882
/// method. Disabling fields that you do not require will improve
883883
/// throughput and reduce memory consumption. Allowed values:
884884
/// headers, timestamp, topic, all, none

src/Confluent.Kafka/ConsumeException.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class ConsumeException : KafkaException
3636
/// <param name="error">
3737
/// The error that occured.
3838
/// </param>
39-
public ConsumeException(ConsumeResult consumerRecord, Error error)
39+
public ConsumeException(ConsumeResult<byte[], byte[]> consumerRecord, Error error)
4040
: base(error)
4141
{
4242
ConsumerRecord = consumerRecord;
@@ -46,6 +46,6 @@ public ConsumeException(ConsumeResult consumerRecord, Error error)
4646
/// An object that provides information known about the consumer
4747
/// record for which the error occured.
4848
/// </summary>
49-
public ConsumeResult ConsumerRecord { get; private set; }
49+
public ConsumeResult<byte[], byte[]> ConsumerRecord { get; private set; }
5050
}
5151
}

src/Confluent.Kafka/ConsumeResult.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@
1919

2020
namespace Confluent.Kafka
2121
{
22-
/// <summary>
23-
/// Represents a message consumed from a Kafka cluster.
24-
/// </summary>
25-
public class ConsumeResult : ConsumeResult<byte[], byte[]> {}
26-
2722
/// <summary>
2823
/// Represents a message consumed from a Kafka cluster.
2924
/// </summary>

0 commit comments

Comments
 (0)