builder classes should return interfaces (#776)

Author: mhowlett

src/Confluent.Kafka/AdminClientBuilder.cs

@@ -132,7 +132,7 @@ public AdminClientBuilder SetLogHandler(Action<AdminClient, LogMessage> logHandl
         /// <summary>
         ///     Build the <see cref="AdminClient" /> instance.
         /// </summary>
-        public virtual AdminClient Build()
+        public virtual IAdminClient Build()
         {
             return new AdminClient(this);
         }

src/Confluent.Kafka/ConsumerBuilder.cs

@@ -292,7 +292,7 @@ public ConsumerBuilder<TKey, TValue> SetOffsetsCommittedHandler(Action<IConsumer
         /// <summary>
         ///     Build a new Consumer instance.
         /// </summary>
-        public virtual Consumer<TKey, TValue> Build()
+        public virtual IConsumer<TKey, TValue> Build()
         {
             return new Consumer<TKey, TValue>(this);
         }

src/Confluent.Kafka/DependentProducerBuilder.cs

@@ -101,7 +101,7 @@ public DependentProducerBuilder<TKey, TValue> SetValueSerializer(IAsyncSerialize
         /// <summary>
         ///     Build a new Producer instance.
         /// </summary>
-        public virtual Producer<TKey, TValue> Build()
+        public virtual IProducer<TKey, TValue> Build()
         {
             return new Producer<TKey, TValue>(this);
         }

src/Confluent.Kafka/ProducerBuilder.cs

@@ -219,7 +219,7 @@ public ProducerBuilder<TKey, TValue> SetValueSerializer(IAsyncSerializer<TValue>
         /// <summary>
         ///     Build a new Producer instance.
         /// </summary>
-        public virtual Producer<TKey, TValue> Build()
+        public virtual IProducer<TKey, TValue> Build()
         {
             return new Producer<TKey, TValue>(this);
         }

test/Confluent.Kafka.IntegrationTests/TemporaryTopic.cs

@@ -23,7 +23,7 @@ namespace Confluent.Kafka
 {
     public class TemporaryTopic : IDisposable
     {
-        AdminClient adminClient;
+        IAdminClient adminClient;
 
         public TemporaryTopic(string bootstrapServers, int numPartitions)
         {

test/Confluent.Kafka.IntegrationTests/Tests/Builder_CustomDefaults.cs

@@ -44,7 +44,7 @@ public byte[] Serialize(string data, bool isKey, MessageMetadata messageMetadata
 
             public MyProducerBuilder(IEnumerable<KeyValuePair<string, string>> config) : base(config) { }
 
-            public override Producer<K, V> Build()
+            public override IProducer<K, V> Build()
             {
                 if (typeof(K) == typeof(string))
                 {
@@ -79,7 +79,7 @@ public string Deserialize(ReadOnlySpan<byte> data, bool isNull, bool isKey, Mess
 
             public MyConsumerBuilder(IEnumerable<KeyValuePair<string, string>> config) : base(config) { }
 
-            public override Consumer<K, V> Build()
+            public override IConsumer<K, V> Build()
             {
                 if (typeof(K) == typeof(string))
                 {

test/Confluent.Kafka.IntegrationTests/Tests/SimpleProduceConsume.cs

@@ -68,7 +68,7 @@ public static void SimpleProduceConsume(string bootstrapServers, string singlePa
             LogToFile("end   SimpleProduceConsume");
         }
 
-        private static void ConsumeMessage(Consumer<byte[], byte[]> consumer, DeliveryResult<Null, string> dr, string testString)
+        private static void ConsumeMessage(IConsumer<byte[], byte[]> consumer, DeliveryResult<Null, string> dr, string testString)
         {
             consumer.Assign(new List<TopicPartitionOffset>() {dr.TopicPartitionOffset});
             var r = consumer.Consume(TimeSpan.FromSeconds(10));
@@ -79,7 +79,7 @@ private static void ConsumeMessage(Consumer<byte[], byte[]> consumer, DeliveryRe
             Assert.Equal(r.Message.Timestamp.UnixTimestampMs, dr.Message.Timestamp.UnixTimestampMs);
         }
 
-        private static DeliveryResult<Null, string> ProduceMessage(string topic, Producer<Null, string> producer, string testString)
+        private static DeliveryResult<Null, string> ProduceMessage(string topic, IProducer<Null, string> producer, string testString)
         {
             var result = producer.ProduceAsync(topic, new Message<Null, string> { Value = testString }).Result;
             Assert.NotNull(result?.Message);

test/Confluent.Kafka.IntegrationTests/Tests/Timestamps.cs

@@ -264,7 +264,7 @@ record = consumer.Consume(TimeSpan.FromSeconds(10));
             LogToFile("end   Timestamps");
         }
 
-        private static void assertCloseToNow(Consumer<Null, string> consumer, TopicPartitionOffset tpo)
+        private static void assertCloseToNow(IConsumer<Null, string> consumer, TopicPartitionOffset tpo)
         {
             consumer.Assign(new List<TopicPartitionOffset>() {tpo});
             var cr = consumer.Consume(TimeSpan.FromSeconds(10));
@@ -273,7 +273,7 @@ private static void assertCloseToNow(Consumer<Null, string> consumer, TopicParti
             Assert.True(Math.Abs((cr.Message.Timestamp.UtcDateTime - DateTime.UtcNow).TotalSeconds) < 120);
         }
 
-        private static void assertCloseToNow_byte(Consumer<byte[], byte[]> consumer, TopicPartitionOffset tpo)
+        private static void assertCloseToNow_byte(IConsumer<byte[], byte[]> consumer, TopicPartitionOffset tpo)
         {
             consumer.Assign(new List<TopicPartitionOffset>() {tpo});
             var cr = consumer.Consume(TimeSpan.FromSeconds(10));

test/Confluent.Kafka.VerifiableClient/Program.cs

@@ -144,7 +144,7 @@ public VerifiableProducerConfig()
 
     public class VerifiableProducer : VerifiableClient, IDisposable
     {
-        Producer<byte[], byte[]> Handle; // Client Handle
+        IProducer<byte[], byte[]> Handle; // Client Handle
 
         long DeliveryCnt; // Successfully delivered messages
         long ErrCnt; // Failed deliveries
@@ -285,7 +285,7 @@ public VerifiableConsumerConfig()
 
     public class VerifiableConsumer : VerifiableClient, IDisposable
     {
-        Consumer<Null, string> consumer;
+        IConsumer<Null, string> consumer;
         VerifiableConsumerConfig Config;
 
         private Dictionary<TopicPartition, AssignedPartition> currentAssignment;

test/Confluent.SchemaRegistry.Serdes.IntegrationTests/TemporaryTopic.cs

@@ -24,7 +24,7 @@ namespace Confluent.SchemaRegistry.Serdes.IntegrationTests
 {
     public class TemporaryTopic : IDisposable
     {
-        AdminClient adminClient;
+        IAdminClient adminClient;
 
         public TemporaryTopic(string bootstrapServers, int numPartitions)
         {