Minor refactor to use RuleRegistry (#33) (#2309)

rayokota · web-flow · commit 96e8d54fd402 · 2024-09-09T09:58:37.000-07:00
* Minor refactor to use RuleRegistry

* Minor cleanup
diff --git a/src/Confluent.SchemaRegistry.Serdes.Avro/AvroDeserializer.cs b/src/Confluent.SchemaRegistry.Serdes.Avro/AvroDeserializer.cs
@@ -39,7 +39,7 @@ public class AvroDeserializer<T> : IAsyncDeserializer<T>
     {
         private ISchemaRegistryClient schemaRegistryClient;
         private AvroDeserializerConfig config;
-        private IList<IRuleExecutor> ruleExecutors;
+        private RuleRegistry ruleRegistry;
 
         private IAsyncDeserializer<T> deserializerImpl;
 
@@ -64,11 +64,11 @@ public AvroDeserializer(ISchemaRegistryClient schemaRegistryClient, IEnumerable<
         {
         }
 
-        public AvroDeserializer(ISchemaRegistryClient schemaRegistryClient, AvroDeserializerConfig config = null, IList<IRuleExecutor> ruleExecutors = null)
+        public AvroDeserializer(ISchemaRegistryClient schemaRegistryClient, AvroDeserializerConfig config = null, RuleRegistry ruleRegistry = null)
         {
             this.schemaRegistryClient = schemaRegistryClient;
             this.config = config;
-            this.ruleExecutors = ruleExecutors ?? new List<IRuleExecutor>();
+            this.ruleRegistry = ruleRegistry ?? RuleRegistry.GlobalInstance;
             
             if (config == null) { return; }
 
@@ -129,8 +129,8 @@ public async Task<T> DeserializeAsync(ReadOnlyMemory<byte> data, bool isNull, Se
                 if (deserializerImpl == null)
                 {
                     deserializerImpl = (typeof(T) == typeof(GenericRecord))
-                        ? (IAsyncDeserializer<T>)new GenericDeserializerImpl(schemaRegistryClient, config, ruleExecutors)
-                        : new SpecificDeserializerImpl<T>(schemaRegistryClient, config, ruleExecutors);
+                        ? (IAsyncDeserializer<T>)new GenericDeserializerImpl(schemaRegistryClient, config, ruleRegistry)
+                        : new SpecificDeserializerImpl<T>(schemaRegistryClient, config, ruleRegistry);
                 }
 
                 return isNull ? default : await deserializerImpl.DeserializeAsync(data, isNull, context)
diff --git a/src/Confluent.SchemaRegistry.Serdes.Avro/AvroSerializer.cs b/src/Confluent.SchemaRegistry.Serdes.Avro/AvroSerializer.cs
@@ -39,7 +39,7 @@ public class AvroSerializer<T> : IAsyncSerializer<T>
     {
         private ISchemaRegistryClient schemaRegistryClient;
         private AvroSerializerConfig config;
-        private IList<IRuleExecutor> ruleExecutors;
+        private RuleRegistry ruleRegistry;
 
         private IAsyncSerializer<T> serializerImpl;
 
@@ -82,11 +82,11 @@ public AvroSerializer(ISchemaRegistryClient schemaRegistryClient, IEnumerable<Ke
         ///     Serializer configuration properties (refer to 
         ///     <see cref="AvroSerializerConfig" />)
         /// </param>
-        public AvroSerializer(ISchemaRegistryClient schemaRegistryClient, AvroSerializerConfig config = null, IList<IRuleExecutor> ruleExecutors = null)
+        public AvroSerializer(ISchemaRegistryClient schemaRegistryClient, AvroSerializerConfig config = null, RuleRegistry ruleRegistry = null)
         {
             this.schemaRegistryClient = schemaRegistryClient;
             this.config = config;
-            this.ruleExecutors = ruleExecutors ?? new List<IRuleExecutor>();
+            this.ruleRegistry = ruleRegistry ?? RuleRegistry.GlobalInstance;
             
             if (config == null) { return; }
 
@@ -147,8 +147,8 @@ public async Task<byte[]> SerializeAsync(T value, SerializationContext context)
                 {
                     serializerImpl = typeof(T) == typeof(GenericRecord)
                         ? (IAsyncSerializer<T>)new GenericSerializerImpl(
-                            schemaRegistryClient, config, ruleExecutors)
-                        : new SpecificSerializerImpl<T>(schemaRegistryClient, config, ruleExecutors);
+                            schemaRegistryClient, config, ruleRegistry)
+                        : new SpecificSerializerImpl<T>(schemaRegistryClient, config, ruleRegistry);
                 }
 
                 return await serializerImpl.SerializeAsync(value, context)
diff --git a/src/Confluent.SchemaRegistry.Serdes.Avro/GenericDeserializerImpl.cs b/src/Confluent.SchemaRegistry.Serdes.Avro/GenericDeserializerImpl.cs
@@ -41,7 +41,7 @@ internal class GenericDeserializerImpl : AsyncDeserializer<GenericRecord, Avro.S
         public GenericDeserializerImpl(
             ISchemaRegistryClient schemaRegistryClient, 
             AvroDeserializerConfig config,
-            IList<IRuleExecutor> ruleExecutors) : base(schemaRegistryClient, config, ruleExecutors)
+            RuleRegistry ruleRegistry) : base(schemaRegistryClient, config, ruleRegistry)
         {
             if (config == null) { return; }
 
diff --git a/src/Confluent.SchemaRegistry.Serdes.Avro/GenericSerializerImpl.cs b/src/Confluent.SchemaRegistry.Serdes.Avro/GenericSerializerImpl.cs
@@ -38,7 +38,7 @@ internal class GenericSerializerImpl : AsyncSerializer<GenericRecord, Avro.Schem
         public GenericSerializerImpl(
             ISchemaRegistryClient schemaRegistryClient,
             AvroSerializerConfig config,
-            IList<IRuleExecutor> ruleExecutors) : base(schemaRegistryClient, config, ruleExecutors)
+            RuleRegistry ruleRegistry) : base(schemaRegistryClient, config, ruleRegistry)
         {
             if (config == null) { return; }
 
diff --git a/src/Confluent.SchemaRegistry.Serdes.Avro/SpecificDeserializerImpl.cs b/src/Confluent.SchemaRegistry.Serdes.Avro/SpecificDeserializerImpl.cs
@@ -49,7 +49,7 @@ internal class SpecificDeserializerImpl<T> : AsyncDeserializer<T, Avro.Schema>
         public SpecificDeserializerImpl(
             ISchemaRegistryClient schemaRegistryClient,
             AvroDeserializerConfig config,
-            IList<IRuleExecutor> ruleExecutors) : base(schemaRegistryClient, config, ruleExecutors)
+            RuleRegistry ruleRegistry) : base(schemaRegistryClient, config, ruleRegistry)
         {
             if (typeof(ISpecificRecord).IsAssignableFrom(typeof(T)))
             {
diff --git a/src/Confluent.SchemaRegistry.Serdes.Avro/SpecificSerializerImpl.cs b/src/Confluent.SchemaRegistry.Serdes.Avro/SpecificSerializerImpl.cs
@@ -86,7 +86,7 @@ public SpecificWriter<T> AvroWriter
         public SpecificSerializerImpl(
             ISchemaRegistryClient schemaRegistryClient,
             AvroSerializerConfig config,
-            IList<IRuleExecutor> ruleExecutors) : base(schemaRegistryClient, config, ruleExecutors)
+            RuleRegistry ruleRegistry) : base(schemaRegistryClient, config, ruleRegistry)
         {
             Type writerType = typeof(T);
             if (writerType != typeof(ISpecificRecord))
diff --git a/src/Confluent.SchemaRegistry.Serdes.Json/JsonDeserializer.cs b/src/Confluent.SchemaRegistry.Serdes.Json/JsonDeserializer.cs
@@ -80,8 +80,8 @@ public JsonDeserializer(ISchemaRegistryClient schemaRegistryClient, IEnumerable<
         }
 
         public JsonDeserializer(ISchemaRegistryClient schemaRegistryClient, JsonDeserializerConfig config, 
-            JsonSchemaGeneratorSettings jsonSchemaGeneratorSettings = null, IList<IRuleExecutor> ruleExecutors = null) 
-            : base(schemaRegistryClient, config, ruleExecutors)
+            JsonSchemaGeneratorSettings jsonSchemaGeneratorSettings = null, RuleRegistry ruleRegistry = null)
+            : base(schemaRegistryClient, config, ruleRegistry)
         {
             this.jsonSchemaGeneratorSettings = jsonSchemaGeneratorSettings;
 
diff --git a/src/Confluent.SchemaRegistry.Serdes.Json/JsonSerializer.cs b/src/Confluent.SchemaRegistry.Serdes.Json/JsonSerializer.cs
@@ -82,8 +82,8 @@ public class JsonSerializer<T> : AsyncSerializer<T, JsonSchema> where T : class
         ///     JSON schema generator settings.
         /// </param>
         public JsonSerializer(ISchemaRegistryClient schemaRegistryClient, JsonSerializerConfig config = null, 
-            JsonSchemaGeneratorSettings jsonSchemaGeneratorSettings = null, IList<IRuleExecutor> ruleExecutors = null)
-            : base(schemaRegistryClient, config, ruleExecutors)
+            JsonSchemaGeneratorSettings jsonSchemaGeneratorSettings = null, RuleRegistry ruleRegistry = null)
+            : base(schemaRegistryClient, config, ruleRegistry)
         {
             this.jsonSchemaGeneratorSettings = jsonSchemaGeneratorSettings;
 
@@ -136,8 +136,8 @@ public JsonSerializer(ISchemaRegistryClient schemaRegistryClient, JsonSerializer
         ///     JSON schema generator settings.
         /// </param>
         public JsonSerializer(ISchemaRegistryClient schemaRegistryClient, Schema schema, JsonSerializerConfig config = null, 
-            JsonSchemaGeneratorSettings jsonSchemaGeneratorSettings = null, IList<IRuleExecutor> ruleExecutors = null) 
-            : this(schemaRegistryClient, config, jsonSchemaGeneratorSettings, ruleExecutors)
+            JsonSchemaGeneratorSettings jsonSchemaGeneratorSettings = null, RuleRegistry ruleRegistry = null)
+            : this(schemaRegistryClient, config, jsonSchemaGeneratorSettings, ruleRegistry)
         {
             foreach (var reference in schema.References)
             {
diff --git a/src/Confluent.SchemaRegistry.Serdes.Protobuf/ProtobufDeserializer.cs b/src/Confluent.SchemaRegistry.Serdes.Protobuf/ProtobufDeserializer.cs
@@ -70,7 +70,7 @@ public ProtobufDeserializer(ISchemaRegistryClient schemaRegistryClient, IEnumera
         }
 
         public ProtobufDeserializer(ISchemaRegistryClient schemaRegistryClient, ProtobufDeserializerConfig config, 
-            IList<IRuleExecutor> ruleExecutors = null) : base(schemaRegistryClient, config, ruleExecutors)
+            RuleRegistry ruleRegistry = null) : base(schemaRegistryClient, config, ruleRegistry)
         {
             this.parser = new MessageParser<T>(() => new T());
 
diff --git a/src/Confluent.SchemaRegistry.Serdes.Protobuf/ProtobufSerializer.cs b/src/Confluent.SchemaRegistry.Serdes.Protobuf/ProtobufSerializer.cs
@@ -71,7 +71,7 @@ namespace Confluent.SchemaRegistry.Serdes
         ///     Initialize a new instance of the ProtobufSerializer class.
         /// </summary>
         public ProtobufSerializer(ISchemaRegistryClient schemaRegistryClient, ProtobufSerializerConfig config = null, 
-            IList<IRuleExecutor> ruleExecutors = null) : base(schemaRegistryClient, config, ruleExecutors)
+            RuleRegistry ruleRegistry = null) : base(schemaRegistryClient, config, ruleRegistry)
         {
             if (config == null)
             { 
diff --git a/src/Confluent.SchemaRegistry/AsyncDeserializer.cs b/src/Confluent.SchemaRegistry/AsyncDeserializer.cs
@@ -27,7 +27,7 @@ public abstract class AsyncDeserializer<T, TParsedSchema> : AsyncSerde<TParsedSc
         protected readonly int headerSize =  sizeof(int) + sizeof(byte);
         
         protected AsyncDeserializer(ISchemaRegistryClient schemaRegistryClient, SerdeConfig config, 
-            IList<IRuleExecutor> ruleExecutors = null) : base(schemaRegistryClient, config, ruleExecutors)
+            RuleRegistry ruleRegistry = null) : base(schemaRegistryClient, config, ruleRegistry)
         {
         }
         public abstract Task<T> DeserializeAsync(ReadOnlyMemory<byte> data, bool isNull, SerializationContext context);
diff --git a/src/Confluent.SchemaRegistry/AsyncSerde.cs b/src/Confluent.SchemaRegistry/AsyncSerde.cs
@@ -32,7 +32,7 @@ namespace Confluent.SchemaRegistry
     public abstract class AsyncSerde<TParsedSchema>
     {
         protected ISchemaRegistryClient schemaRegistryClient;
-        protected IList<IRuleExecutor> ruleExecutors;
+        protected RuleRegistry ruleRegistry;
         
         protected bool useLatestVersion = false;
         protected bool latestCompatibilityStrict = false;
@@ -44,10 +44,10 @@ public abstract class AsyncSerde<TParsedSchema>
         private readonly IDictionary<Schema, TParsedSchema> parsedSchemaCache = new Dictionary<Schema, TParsedSchema>();
         private SemaphoreSlim parsedSchemaMutex = new SemaphoreSlim(1);
         
-        protected AsyncSerde(ISchemaRegistryClient schemaRegistryClient, SerdeConfig config, IList<IRuleExecutor> ruleExecutors = null)
+        protected AsyncSerde(ISchemaRegistryClient schemaRegistryClient, SerdeConfig config, RuleRegistry ruleRegistry = null)
         {
             this.schemaRegistryClient = schemaRegistryClient;
-            this.ruleExecutors = ruleExecutors ?? new List<IRuleExecutor>();
+            this.ruleRegistry = ruleRegistry ?? RuleRegistry.GlobalInstance;
 
             if (config == null) { return; }
 
@@ -57,7 +57,7 @@ protected AsyncSerde(ISchemaRegistryClient schemaRegistryClient, SerdeConfig con
             if (schemaRegistryClient != null)
                 ruleConfigs = schemaRegistryClient.Config.Concat(ruleConfigs);
             
-            foreach (IRuleExecutor executor in this.ruleExecutors.Concat(RuleRegistry.GetRuleExecutors()))
+            foreach (IRuleExecutor executor in this.ruleRegistry.GetExecutors())
             {
                 executor.Configure(ruleConfigs); 
             }
@@ -344,7 +344,7 @@ protected async Task<object> ExecuteRules(
 
                 RuleContext ctx = new RuleContext(source, target,
                     subject, topic, headers, isKey, ruleMode, rule, i, rules, fieldTransformer);
-                IRuleExecutor ruleExecutor = GetRuleExecutor(ruleExecutors, rule.Type.ToUpper());
+                IRuleExecutor ruleExecutor = GetRuleExecutor(ruleRegistry, rule.Type.ToUpper());
                 if (ruleExecutor != null)
                 {
                     try
@@ -367,40 +367,31 @@ protected async Task<object> ExecuteRules(
                                 throw new ArgumentException("Unsupported rule kind " + rule.Kind);
                         }
                         await RunAction(ctx, ruleMode, rule, message != null ? rule.OnSuccess : rule.OnFailure,
-                            message, null, message != null ? null : ErrorAction.ActionType)
+                            message, null, message != null ? null : ErrorAction.ActionType,
+                            ruleRegistry)
                             .ConfigureAwait(continueOnCapturedContext: false);
                     }
                     catch (RuleException ex)
                     {
                         await RunAction(ctx, ruleMode, rule, rule.OnFailure, message, 
-                            ex, ErrorAction.ActionType)
+                            ex, ErrorAction.ActionType, ruleRegistry)
                             .ConfigureAwait(continueOnCapturedContext: false);
                     }
                 }
                 else
                 {
                     await RunAction(ctx, ruleMode, rule, rule.OnFailure, message, 
-                        new RuleException("Could not find rule executor of type " + rule.Type), ErrorAction.ActionType)
+                        new RuleException("Could not find rule executor of type " + rule.Type),
+                        ErrorAction.ActionType, ruleRegistry)
                         .ConfigureAwait(continueOnCapturedContext: false);
                 }
             }
             return message;
         }
 
-        private static IRuleExecutor GetRuleExecutor(IList<IRuleExecutor> ruleExecutors, string type)
+        private static IRuleExecutor GetRuleExecutor(RuleRegistry ruleRegistry, string type)
         {
-            if (ruleExecutors != null)
-            {
-                foreach (IRuleExecutor ruleExecutor in ruleExecutors)
-                {
-                    if (ruleExecutor.Type().Equals(type))
-                    {
-                        return ruleExecutor;
-                    }
-                }
-            }
-
-            if (RuleRegistry.TryGetRuleExecutor(type, out IRuleExecutor result))
+            if (ruleRegistry.TryGetExecutor(type, out IRuleExecutor result))
             {
                 return result;
             }
@@ -409,7 +400,8 @@ private static IRuleExecutor GetRuleExecutor(IList<IRuleExecutor> ruleExecutors,
         }
 
         private static async Task RunAction(RuleContext ctx, RuleMode ruleMode, 
-            Rule rule, string action, object message, RuleException ex, string defaultAction)
+            Rule rule, string action, object message, RuleException ex, string defaultAction,
+            RuleRegistry ruleRegistry)
         {
             string actionName = GetRuleActionName(rule, ruleMode, action);
             if (actionName == null)
@@ -418,7 +410,7 @@ private static async Task RunAction(RuleContext ctx, RuleMode ruleMode,
             }
             if (actionName != null)
             {
-                IRuleAction ruleAction = GetRuleAction(actionName);
+                IRuleAction ruleAction = GetRuleAction(ruleRegistry, actionName);
                 if (ruleAction == null)
                 {
                     throw new SerializationException("Could not find rule action of type " + actionName);
@@ -456,7 +448,7 @@ private static string GetRuleActionName(Rule rule, RuleMode ruleMode, string act
             return actionName;
         }
 
-        private static IRuleAction GetRuleAction(string actionName)
+        private static IRuleAction GetRuleAction(RuleRegistry ruleRegistry, string actionName)
         {
             if (actionName == ErrorAction.ActionType)
             {
@@ -466,7 +458,7 @@ private static IRuleAction GetRuleAction(string actionName)
             {
                 return new NoneAction();
             }
-            RuleRegistry.TryGetRuleAction(actionName.ToUpper(), out IRuleAction action);
+            ruleRegistry.TryGetAction(actionName.ToUpper(), out IRuleAction action);
             return action;
         }
     }
diff --git a/src/Confluent.SchemaRegistry/AsyncSerializer.cs b/src/Confluent.SchemaRegistry/AsyncSerializer.cs
@@ -36,7 +36,7 @@ public abstract class AsyncSerializer<T, TParsedSchema> : AsyncSerde<TParsedSche
         protected HashSet<string> subjectsRegistered = new HashSet<string>();
         
         protected AsyncSerializer(ISchemaRegistryClient schemaRegistryClient, SerdeConfig config, 
-            IList<IRuleExecutor> ruleExecutors = null) : base(schemaRegistryClient, config, ruleExecutors)
+            RuleRegistry ruleRegistry = null) : base(schemaRegistryClient, config, ruleRegistry)
         {
         }
 
diff --git a/src/Confluent.SchemaRegistry/RuleRegistry.cs b/src/Confluent.SchemaRegistry/RuleRegistry.cs
diff --git a/test/Confluent.SchemaRegistry.Serdes.UnitTests/JsonSerializeDeserialize.cs b/test/Confluent.SchemaRegistry.Serdes.UnitTests/JsonSerializeDeserialize.cs
diff --git a/test/Confluent.SchemaRegistry.Serdes.UnitTests/ProtoSerializeDeserialize.cs b/test/Confluent.SchemaRegistry.Serdes.UnitTests/ProtoSerializeDeserialize.cs
diff --git a/test/Confluent.SchemaRegistry.Serdes.UnitTests/SerializeDeserialize.cs b/test/Confluent.SchemaRegistry.Serdes.UnitTests/SerializeDeserialize.cs

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public class AvroDeserializer<T> : IAsyncDeserializer<T>`
`39`	`39`	`{`
`40`	`40`	`private ISchemaRegistryClient schemaRegistryClient;`
`41`	`41`	`private AvroDeserializerConfig config;`
`42`		`- private IList<IRuleExecutor> ruleExecutors;`
	`42`	`+ private RuleRegistry ruleRegistry;`
`43`	`43`
`44`	`44`	`private IAsyncDeserializer<T> deserializerImpl;`
`45`	`45`
`@@ -64,11 +64,11 @@ public AvroDeserializer(ISchemaRegistryClient schemaRegistryClient, IEnumerable<`
`64`	`64`	`{`
`65`	`65`	`}`
`66`	`66`
`67`		`- public AvroDeserializer(ISchemaRegistryClient schemaRegistryClient, AvroDeserializerConfig config = null, IList<IRuleExecutor> ruleExecutors = null)`
	`67`	`+ public AvroDeserializer(ISchemaRegistryClient schemaRegistryClient, AvroDeserializerConfig config = null, RuleRegistry ruleRegistry = null)`
`68`	`68`	`{`
`69`	`69`	`this.schemaRegistryClient = schemaRegistryClient;`
`70`	`70`	`this.config = config;`
`71`		`- this.ruleExecutors = ruleExecutors ?? new List<IRuleExecutor>();`
	`71`	`+ this.ruleRegistry = ruleRegistry ?? RuleRegistry.GlobalInstance;`
`72`	`72`
`73`	`73`	`if (config == null) { return; }`
`74`	`74`
`@@ -129,8 +129,8 @@ public async Task<T> DeserializeAsync(ReadOnlyMemory<byte> data, bool isNull, Se`
`129`	`129`	`if (deserializerImpl == null)`
`130`	`130`	`{`
`131`	`131`	`deserializerImpl = (typeof(T) == typeof(GenericRecord))`
`132`		`- ? (IAsyncDeserializer<T>)new GenericDeserializerImpl(schemaRegistryClient, config, ruleExecutors)`
`133`		`- : new SpecificDeserializerImpl<T>(schemaRegistryClient, config, ruleExecutors);`
	`132`	`+ ? (IAsyncDeserializer<T>)new GenericDeserializerImpl(schemaRegistryClient, config, ruleRegistry)`
	`133`	`+ : new SpecificDeserializerImpl<T>(schemaRegistryClient, config, ruleRegistry);`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`return isNull ? default : await deserializerImpl.DeserializeAsync(data, isNull, context)`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ internal class GenericDeserializerImpl : AsyncDeserializer<GenericRecord, Avro.S`
`41`	`41`	`public GenericDeserializerImpl(`
`42`	`42`	`ISchemaRegistryClient schemaRegistryClient,`
`43`	`43`	`AvroDeserializerConfig config,`
`44`		`- IList<IRuleExecutor> ruleExecutors) : base(schemaRegistryClient, config, ruleExecutors)`
	`44`	`+ RuleRegistry ruleRegistry) : base(schemaRegistryClient, config, ruleRegistry)`
`45`	`45`	`{`
`46`	`46`	`if (config == null) { return; }`
`47`	`47`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ internal class GenericSerializerImpl : AsyncSerializer<GenericRecord, Avro.Schem`
`38`	`38`	`public GenericSerializerImpl(`
`39`	`39`	`ISchemaRegistryClient schemaRegistryClient,`
`40`	`40`	`AvroSerializerConfig config,`
`41`		`- IList<IRuleExecutor> ruleExecutors) : base(schemaRegistryClient, config, ruleExecutors)`
	`41`	`+ RuleRegistry ruleRegistry) : base(schemaRegistryClient, config, ruleRegistry)`
`42`	`42`	`{`
`43`	`43`	`if (config == null) { return; }`
`44`	`44`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ internal class SpecificDeserializerImpl<T> : AsyncDeserializer<T, Avro.Schema>`
`49`	`49`	`public SpecificDeserializerImpl(`
`50`	`50`	`ISchemaRegistryClient schemaRegistryClient,`
`51`	`51`	`AvroDeserializerConfig config,`
`52`		`- IList<IRuleExecutor> ruleExecutors) : base(schemaRegistryClient, config, ruleExecutors)`
	`52`	`+ RuleRegistry ruleRegistry) : base(schemaRegistryClient, config, ruleRegistry)`
`53`	`53`	`{`
`54`	`54`	`if (typeof(ISpecificRecord).IsAssignableFrom(typeof(T)))`
`55`	`55`	`{`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public SpecificWriter<T> AvroWriter`
`86`	`86`	`public SpecificSerializerImpl(`
`87`	`87`	`ISchemaRegistryClient schemaRegistryClient,`
`88`	`88`	`AvroSerializerConfig config,`
`89`		`- IList<IRuleExecutor> ruleExecutors) : base(schemaRegistryClient, config, ruleExecutors)`
	`89`	`+ RuleRegistry ruleRegistry) : base(schemaRegistryClient, config, ruleRegistry)`
`90`	`90`	`{`
`91`	`91`	`Type writerType = typeof(T);`
`92`	`92`	`if (writerType != typeof(ISpecificRecord))`
Original file line number	Diff line number	Diff line change
`@@ -80,8 +80,8 @@ public JsonDeserializer(ISchemaRegistryClient schemaRegistryClient, IEnumerable<`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`public JsonDeserializer(ISchemaRegistryClient schemaRegistryClient, JsonDeserializerConfig config,`
`83`		`- JsonSchemaGeneratorSettings jsonSchemaGeneratorSettings = null, IList<IRuleExecutor> ruleExecutors = null)`
`84`		`- : base(schemaRegistryClient, config, ruleExecutors)`
	`83`	`+ JsonSchemaGeneratorSettings jsonSchemaGeneratorSettings = null, RuleRegistry ruleRegistry = null)`
	`84`	`+ : base(schemaRegistryClient, config, ruleRegistry)`
`85`	`85`	`{`
`86`	`86`	`this.jsonSchemaGeneratorSettings = jsonSchemaGeneratorSettings;`
`87`	`87`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public ProtobufDeserializer(ISchemaRegistryClient schemaRegistryClient, IEnumera`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`public ProtobufDeserializer(ISchemaRegistryClient schemaRegistryClient, ProtobufDeserializerConfig config,`
`73`		`- IList<IRuleExecutor> ruleExecutors = null) : base(schemaRegistryClient, config, ruleExecutors)`
	`73`	`+ RuleRegistry ruleRegistry = null) : base(schemaRegistryClient, config, ruleRegistry)`
`74`	`74`	`{`
`75`	`75`	`this.parser = new MessageParser<T>(() => new T());`
`76`	`76`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ namespace Confluent.SchemaRegistry.Serdes`
`71`	`71`	`/// Initialize a new instance of the ProtobufSerializer class.`
`72`	`72`	`/// </summary>`
`73`	`73`	`public ProtobufSerializer(ISchemaRegistryClient schemaRegistryClient, ProtobufSerializerConfig config = null,`
`74`		`- IList<IRuleExecutor> ruleExecutors = null) : base(schemaRegistryClient, config, ruleExecutors)`
	`74`	`+ RuleRegistry ruleRegistry = null) : base(schemaRegistryClient, config, ruleRegistry)`
`75`	`75`	`{`
`76`	`76`	`if (config == null)`
`77`	`77`	`{`