review changes

Author: Matt Howlett

src/ConfigGen/Program.cs

@@ -38,14 +38,14 @@ internal static List<PropertySpecification> RemoveLegacyOrNotRelevant(List<Prope
                 if (p.Name == "consume.callback.max.messages") { return false; }
                 if (p.Name == "offset.store.path") { return false; }
                 if (p.Name == "offset.store.sync.interval.ms") { return false; }
-                if (p.Name == "enabled_events") { return false; }
                 if (p.Name == "builtin.features") { return false; }
                 if (p.Name == "produce.offset.report") { return false; }
                 if (p.Name == "delivery.report.only.error") { return false; }
                 if (p.Name == "topic.metadata.refresh.fast.cnt") { return false; }
                 if (p.Name == "auto.commit.interval.ms" && !p.IsGlobal) { return false; }
                 if (p.Name == "enable.auto.commit" && !p.IsGlobal) { return false; }
                 if (p.Name == "auto.commit.enable" && !p.IsGlobal) { return false; }
+                if (p.Name.Contains("_")) { return false; }
                 return true;
             }).ToList();
 
@@ -136,7 +136,7 @@ class PropertySpecification
     {
         public bool IsGlobal { get; set; }
         public string Name { get; set; }
-        public string CPorA { get; set; }
+        public string CPorA { get; set; }  // Consumer, Producer or All.
         public string Range { get; set; }
         public string Default { get; set; }
         public string Description { get; set; }

src/Confluent.SchemaRegistry/CachedSchemaRegistryClient.cs

@@ -95,7 +95,7 @@ public CachedSchemaRegistryClient(IEnumerable<KeyValuePair<string, string>> conf
             {
                 if (basicAuthInfo == "")
                 {
-                    throw new ArgumentException($"CachedSchemaRegistryClient: {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthCredentialsSource} was set to 'USER_INFO', but no value was specified for {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthUserInfo}.");
+                    throw new ArgumentException($"CachedSchemaRegistryClient: {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthCredentialsSource} set to 'USER_INFO', but no value specified for {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthUserInfo}.");
                 }
                 var userPass = (basicAuthInfo).Split(':');
                 if (userPass.Length != 2)
@@ -109,17 +109,17 @@ public CachedSchemaRegistryClient(IEnumerable<KeyValuePair<string, string>> conf
             {
                 if (basicAuthInfo != "")
                 {
-                    throw new ArgumentException($"CachedSchemaRegistryClient: {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthCredentialsSource} was set to 'SASL_INHERIT', but {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthUserInfo} as also specified.");
+                    throw new ArgumentException($"CachedSchemaRegistryClient: {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthCredentialsSource} set to 'SASL_INHERIT', but {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthUserInfo} as also specified.");
                 }
                 var saslUsername = config.FirstOrDefault(prop => prop.Key == "sasl.username");
                 var saslPassword = config.FirstOrDefault(prop => prop.Key == "sasl.password");
                 if (saslUsername.Value == null)
                 {
-                    throw new ArgumentException($"CachedSchemaRegistryClient: {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthCredentialsSource} was set to 'SASL_INHERIT', but 'sasl.username' property was not specified.");
+                    throw new ArgumentException($"CachedSchemaRegistryClient: {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthCredentialsSource} set to 'SASL_INHERIT', but 'sasl.username' property not specified.");
                 }
                 if (saslPassword.Value == null)
                 {
-                    throw new ArgumentException($"CachedSchemaRegistryClient: {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthCredentialsSource} was set to 'SASL_INHERIT', but 'sasl.password' property was not specified.");
+                    throw new ArgumentException($"CachedSchemaRegistryClient: {SchemaRegistryConfig.PropertyNames.SchemaRegistryBasicAuthCredentialsSource} set to 'SASL_INHERIT', but 'sasl.password' property not specified.");
                 }
                 username = Convert.ToString(saslUsername.Value);
                 password = Convert.ToString(saslPassword.Value);