Skip to content

Commit 9fb8be9

Browse files
committed
Merge branch '1.0.x'
2 parents 4b3cfcd + caf2ef3 commit 9fb8be9

File tree

8 files changed

+809
-650
lines changed

8 files changed

+809
-650
lines changed

src/Confluent.Kafka/AdminClient.cs

Lines changed: 12 additions & 97 deletions
Original file line numberDiff line numberDiff line change
@@ -322,25 +322,10 @@ private Task StartPollTask(CancellationToken ct)
322322
{ Librdkafka.EventType.CreatePartitions_Result, typeof(TaskCompletionSource<List<CreatePartitionsReport>>) }
323323
};
324324

325+
325326
/// <summary>
326-
/// Get the configuration for the specified resources. The returned
327-
/// configuration includes default values and the IsDefault property
328-
/// can be used to distinguish them from user supplied values. The
329-
/// value of config entries where IsSensitive is true is always null
330-
/// so that sensitive information is not disclosed. Config entries where
331-
/// IsReadOnly is true cannot be updated. This operation is supported
332-
/// by brokers with version 0.11.0.0 or higher.
327+
/// Refer to <see cref="Confluent.Kafka.IAdminClient.DescribeConfigsAsync(IEnumerable{ConfigResource}, DescribeConfigsOptions)" />
333328
/// </summary>
334-
/// <param name="resources">
335-
/// The resources (topic and broker resource types are currently
336-
/// supported)
337-
/// </param>
338-
/// <param name="options">
339-
/// The options to use when describing configs.
340-
/// </param>
341-
/// <returns>
342-
/// Configs for the specified resources.
343-
/// </returns>
344329
public Task<List<DescribeConfigsResult>> DescribeConfigsAsync(IEnumerable<ConfigResource> resources, DescribeConfigsOptions options = null)
345330
{
346331
// TODO: To support results that may complete at different times, we may also want to implement:
@@ -354,26 +339,10 @@ public Task<List<DescribeConfigsResult>> DescribeConfigsAsync(IEnumerable<Config
354339
return completionSource.Task;
355340
}
356341

342+
357343
/// <summary>
358-
/// Update the configuration for the specified resources. Updates are not transactional
359-
/// so they may succeed for some resources while fail for others. The configs for a
360-
/// particular resource are updated atomically. This operation is supported by brokers
361-
/// with version 0.11.0.0 or higher. IMPORTANT NOTE: Unspecified configuration properties
362-
/// will be reverted to their default values. Furthermore, if you use DescribeConfigsAsync
363-
/// to obtain the current set of configuration values, modify them, then use
364-
/// AlterConfigsAsync to set them, you will loose any non-default values that are marked
365-
/// as sensitive because they are not provided by DescribeConfigsAsync.
344+
/// Refer to <see cref="Confluent.Kafka.IAdminClient.AlterConfigsAsync(Dictionary{ConfigResource, List{ConfigEntry}}, AlterConfigsOptions)" />
366345
/// </summary>
367-
/// <param name="configs">
368-
/// The resources with their configs (topic is the only resource type with configs
369-
/// that can be updated currently).
370-
/// </param>
371-
/// <param name="options">
372-
/// The options to use when altering configs.
373-
/// </param>
374-
/// <returns>
375-
/// The results of the alter configs requests.
376-
/// </returns>
377346
public Task AlterConfigsAsync(Dictionary<ConfigResource, List<ConfigEntry>> configs, AlterConfigsOptions options = null)
378347
{
379348
// TODO: To support results that may complete at different times, we may also want to implement:
@@ -391,18 +360,10 @@ public Task AlterConfigsAsync(Dictionary<ConfigResource, List<ConfigEntry>> conf
391360
return completionSource.Task;
392361
}
393362

363+
394364
/// <summary>
395-
/// Create a set of new topics.
365+
/// Refer to <see cref="Confluent.Kafka.IAdminClient.CreateTopicsAsync(IEnumerable{TopicSpecification}, CreateTopicsOptions)" />
396366
/// </summary>
397-
/// <param name="topics">
398-
/// A collection of specifications for the new topics to create.
399-
/// </param>
400-
/// <param name="options">
401-
/// The options to use when creating the topics.
402-
/// </param>
403-
/// <returns>
404-
/// The results of the create topic requests.
405-
/// </returns>
406367
public Task CreateTopicsAsync(IEnumerable<TopicSpecification> topics, CreateTopicsOptions options = null)
407368
{
408369
// TODO: To support results that may complete at different times, we may also want to implement:
@@ -417,21 +378,8 @@ public Task CreateTopicsAsync(IEnumerable<TopicSpecification> topics, CreateTopi
417378
}
418379

419380
/// <summary>
420-
/// Delete a set of topics. This operation is not transactional so it may succeed for some topics while fail
421-
/// for others. It may take several seconds after the DeleteTopicsResult returns success for all the brokers to
422-
/// become aware that the topics are gone. During this time, topics may continue to be visible via admin
423-
/// operations. If delete.topic.enable is false on the brokers, DeleteTopicsAsync will mark the topics for
424-
/// deletion, but not actually delete them. The Task will return successfully in this case.
381+
/// Refer to <see cref="Confluent.Kafka.IAdminClient.DeleteTopicsAsync(IEnumerable{string}, DeleteTopicsOptions)" />
425382
/// </summary>
426-
/// <param name="topics">
427-
/// The topic names to delete.
428-
/// </param>
429-
/// <param name="options">
430-
/// The options to use when deleting topics.
431-
/// </param>
432-
/// <returns>
433-
/// The results of the delete topic requests.
434-
/// </returns>
435383
public Task DeleteTopicsAsync(IEnumerable<string> topics, DeleteTopicsOptions options = null)
436384
{
437385
// TODO: To support results that may complete at different times, we may also want to implement:
@@ -446,18 +394,8 @@ public Task DeleteTopicsAsync(IEnumerable<string> topics, DeleteTopicsOptions op
446394
}
447395

448396
/// <summary>
449-
/// Increase the number of partitions for one or more topics as per
450-
/// the supplied PartitionsSpecifications.
397+
/// Refer to <see cref="Confluent.Kafka.IAdminClient.CreatePartitionsAsync(IEnumerable{PartitionsSpecification}, CreatePartitionsOptions)" />
451398
/// </summary>
452-
/// <param name="partitionsSpecifications">
453-
/// A collection of PartitionsSpecifications.
454-
/// </param>
455-
/// <param name="options">
456-
/// The options to use when creating the partitions.
457-
/// </param>
458-
/// <returns>
459-
/// The results of the PartitionsSpecification requests.
460-
/// </returns>
461399
public Task CreatePartitionsAsync(
462400
IEnumerable<PartitionsSpecification> partitionsSpecifications, CreatePartitionsOptions options = null)
463401
{
@@ -530,51 +468,28 @@ private void Init()
530468

531469

532470
/// <summary>
533-
/// Get information pertaining to all groups in the Kafka cluster (blocking)
534-
///
535-
/// [API-SUBJECT-TO-CHANGE] - The API associated with this functionality
536-
/// is subject to change.
471+
/// Refer to <see cref="Confluent.Kafka.IAdminClient.ListGroups(TimeSpan)" />
537472
/// </summary>
538-
/// <param name="timeout">
539-
/// The maximum period of time the call may block.
540-
/// </param>
541473
public List<GroupInfo> ListGroups(TimeSpan timeout)
542474
=> kafkaHandle.ListGroups(timeout.TotalMillisecondsAsInt());
543475

544476

545477
/// <summary>
546-
/// Get information pertaining to a particular group in the
547-
/// Kafka cluster (blocking).
548-
///
549-
/// [API-SUBJECT-TO-CHANGE] - The API associated with this functionality is subject to change.
478+
/// Refer to <see cref="Confluent.Kafka.IAdminClient.ListGroup(string, TimeSpan)" />
550479
/// </summary>
551-
/// <param name="group">
552-
/// The group of interest.
553-
/// </param>
554-
/// <param name="timeout">
555-
/// The maximum period of time the call may block.
556-
/// </param>
557-
/// <returns>
558-
/// Returns information pertaining to the specified group
559-
/// or null if this group does not exist.
560-
/// </returns>
561480
public GroupInfo ListGroup(string group, TimeSpan timeout)
562481
=> kafkaHandle.ListGroup(group, timeout.TotalMillisecondsAsInt());
563482

564483

565484
/// <summary>
566-
/// Query the cluster for metadata.
567-
///
568-
/// [API-SUBJECT-TO-CHANGE] - The API associated with this functionality is subject to change.
485+
/// Refer to <see cref="Confluent.Kafka.IAdminClient.GetMetadata(TimeSpan)" />
569486
/// </summary>
570487
public Metadata GetMetadata(TimeSpan timeout)
571488
=> kafkaHandle.GetMetadata(true, null, timeout.TotalMillisecondsAsInt());
572489

573490

574491
/// <summary>
575-
/// Query the cluster for metadata for a specific topic.
576-
///
577-
/// [API-SUBJECT-TO-CHANGE] - The API associated with this functionality is subject to change.
492+
/// Refer to <see cref="Confluent.Kafka.IAdminClient.GetMetadata(string, TimeSpan)" />
578493
/// </summary>
579494
public Metadata GetMetadata(string topic, TimeSpan timeout)
580495
=> kafkaHandle.GetMetadata(false, kafkaHandle.getKafkaTopicHandle(topic), timeout.TotalMillisecondsAsInt());

0 commit comments

Comments
 (0)