Skip to content

Commit ae744d8

Browse files
authored
Add missing ConfigureAwait calls (#2477)
* Add missing ConfigureAwait calls * Minor fix
1 parent 3f10fc8 commit ae744d8

File tree

15 files changed

+53
-46
lines changed

15 files changed

+53
-46
lines changed

src/Confluent.SchemaRegistry.Rules/CelExecutor.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ public void Configure(IEnumerable<KeyValuePair<string, string>> config,
4444

4545
public async Task<object> Transform(RuleContext ctx, object message)
4646
{
47-
return await Execute(ctx, message, new Dictionary<string, object>() { { "message", message } });
47+
return await Execute(ctx, message, new Dictionary<string, object>() { { "message", message } })
48+
.ConfigureAwait(false);
4849
}
4950

5051
public async Task<object> Execute(RuleContext ctx, object obj, IDictionary<string, object> args)
@@ -59,7 +60,7 @@ public async Task<object> Execute(RuleContext ctx, object obj, IDictionary<strin
5960
object guardResult = false;
6061
try
6162
{
62-
guardResult = await Execute(ctx, guard, obj, args);
63+
guardResult = await Execute(ctx, guard, obj, args).ConfigureAwait(false);
6364
}
6465
catch (RuleException e)
6566
{
@@ -75,7 +76,7 @@ public async Task<object> Execute(RuleContext ctx, object obj, IDictionary<strin
7576
expr = expr.Substring(index + 1);
7677
}
7778

78-
return await Execute(ctx, expr, obj, args);
79+
return await Execute(ctx, expr, obj, args).ConfigureAwait(false);
7980
}
8081

8182
private async Task<object> Execute(RuleContext ctx, string rule, object obj, IDictionary<string, object> args)

src/Confluent.SchemaRegistry.Rules/CelFieldExecutor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public async Task<object> Transform(RuleContext ctx, RuleContext.FieldContext fi
6969
{ "tags", fieldCtx.Tags.ToList() },
7070
{ "message", message }
7171
}
72-
);
72+
).ConfigureAwait(false);
7373
if (result is ByteString)
7474
{
7575
result = ((ByteString)result).ToByteArray();

src/Confluent.SchemaRegistry.Serdes.Avro/GenericDeserializerImpl.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public override async Task<GenericRecord> DeserializeAsync(ReadOnlyMemory<byte>
5656
return isNull
5757
? default
5858
: await Deserialize(context.Topic, context.Headers, data.ToArray(),
59-
context.Component == MessageComponentType.Key);
59+
context.Component == MessageComponentType.Key).ConfigureAwait(false);
6060
}
6161

6262
public async Task<GenericRecord> Deserialize(string topic, Headers headers, byte[] array, bool isKey)
@@ -85,7 +85,7 @@ public async Task<GenericRecord> Deserialize(string topic, Headers headers, byte
8585
SchemaId writerId = new SchemaId(SchemaType.Avro);
8686
using (var stream = schemaIdDeserializer.Deserialize(array, context, ref writerId))
8787
{
88-
(writerSchemaJson, writerSchema) = await GetWriterSchema(subject, writerId);
88+
(writerSchemaJson, writerSchema) = await GetWriterSchema(subject, writerId).ConfigureAwait(false);
8989
if (subject == null)
9090
{
9191
subject = GetSubjectName(topic, isKey, writerSchema.Fullname);
@@ -126,7 +126,7 @@ public async Task<GenericRecord> Deserialize(string topic, Headers headers, byte
126126
.ContinueWith(t => (JToken)t.Result)
127127
.ConfigureAwait(continueOnCapturedContext: false);
128128
readerSchemaJson = latestSchema;
129-
readerSchema = await GetParsedSchema(readerSchemaJson);
129+
readerSchema = await GetParsedSchema(readerSchemaJson).ConfigureAwait(false);
130130
Avro.IO.Decoder decoder = new JsonDecoder(readerSchema, json.ToString(Formatting.None));
131131

132132
datumReader = new GenericReader<GenericRecord>(readerSchema, readerSchema);
@@ -137,14 +137,14 @@ public async Task<GenericRecord> Deserialize(string topic, Headers headers, byte
137137
if (latestSchema != null)
138138
{
139139
readerSchemaJson = latestSchema;
140-
readerSchema = await GetParsedSchema(readerSchemaJson);
140+
readerSchema = await GetParsedSchema(readerSchemaJson).ConfigureAwait(false);
141141
}
142142
else
143143
{
144144
readerSchemaJson = writerSchemaJson;
145145
readerSchema = writerSchema;
146146
}
147-
datumReader = await GetDatumReader(writerSchema, readerSchema);
147+
datumReader = await GetDatumReader(writerSchema, readerSchema).ConfigureAwait(false);
148148
data = datumReader.Read(default(GenericRecord), new BinaryDecoder(stream));
149149
}
150150
}

src/Confluent.SchemaRegistry.Serdes.Avro/GenericSerializerImpl.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ public async Task<byte[]> Serialize(string topic, Headers headers, GenericRecord
162162

163163
if (latestSchema != null)
164164
{
165-
writerSchema = await GetParsedSchema(latestSchema);
165+
writerSchema = await GetParsedSchema(latestSchema).ConfigureAwait(false);
166166
FieldTransformer fieldTransformer = async (ctx, transform, message) =>
167167
{
168168
return await AvroUtils.Transform(ctx, writerSchema, message, transform).ConfigureAwait(false);

src/Confluent.SchemaRegistry.Serdes.Avro/SpecificDeserializerImpl.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public override async Task<T> DeserializeAsync(ReadOnlyMemory<byte> data, bool i
107107
return isNull
108108
? default
109109
: await Deserialize(context.Topic, context.Headers, data.ToArray(),
110-
context.Component == MessageComponentType.Key);
110+
context.Component == MessageComponentType.Key).ConfigureAwait(false);
111111
}
112112

113113
public async Task<T> Deserialize(string topic, Headers headers, byte[] array, bool isKey)
@@ -134,7 +134,7 @@ public async Task<T> Deserialize(string topic, Headers headers, byte[] array, bo
134134
SchemaId writerId = new SchemaId(SchemaType.Avro);
135135
using (var stream = schemaIdDeserializer.Deserialize(array, context, ref writerId))
136136
{
137-
(writerSchemaJson, writerSchema) = await GetWriterSchema(subject, writerId);
137+
(writerSchemaJson, writerSchema) = await GetWriterSchema(subject, writerId).ConfigureAwait(false);
138138
if (subject == null)
139139
{
140140
subject = GetSubjectName(topic, isKey, writerSchema.Fullname);
@@ -181,13 +181,15 @@ public async Task<T> Deserialize(string topic, Headers headers, byte[] array, bo
181181
}
182182
else
183183
{
184-
datumReader = await GetDatumReader(writerSchema, ReaderSchema);
184+
datumReader = await GetDatumReader(writerSchema, ReaderSchema).ConfigureAwait(false);
185185
data = Read(datumReader, new BinaryDecoder(stream));
186186
}
187187
}
188188

189189
Schema readerSchemaJson = latestSchema ?? writerSchemaJson;
190-
Avro.Schema readerSchema = latestSchema != null ? await GetParsedSchema(latestSchema) : writerSchema;
190+
Avro.Schema readerSchema = latestSchema != null
191+
? await GetParsedSchema(latestSchema).ConfigureAwait(false)
192+
: writerSchema;
191193
FieldTransformer fieldTransformer = async (ctx, transform, message) =>
192194
{
193195
return await AvroUtils.Transform(ctx, readerSchema, message, transform).ConfigureAwait(false);

src/Confluent.SchemaRegistry.Serdes.Avro/SpecificSerializerImpl.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ public async Task<byte[]> Serialize(string topic, Headers headers, T data, bool
204204

205205
if (latestSchema != null)
206206
{
207-
var schema = await GetParsedSchema(latestSchema);
207+
var schema = await GetParsedSchema(latestSchema).ConfigureAwait(false);
208208
FieldTransformer fieldTransformer = async (ctx, transform, message) =>
209209
{
210210
return await AvroUtils.Transform(ctx, schema, message, transform).ConfigureAwait(false);

src/Confluent.SchemaRegistry.Serdes.Json/JsonDeserializer.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,8 @@ public override async Task<T> DeserializeAsync(ReadOnlyMemory<byte> data, bool i
193193
{
194194
if (schemaRegistryClient != null)
195195
{
196-
(writerSchemaJson, writerSchema) = await GetWriterSchema(subject, writerId);
196+
(writerSchemaJson, writerSchema) = await GetWriterSchema(subject, writerId)
197+
.ConfigureAwait(false);
197198
if (subject == null)
198199
{
199200
subject = GetSubjectName(topic, isKey, writerSchema.Title);
@@ -210,7 +211,7 @@ public override async Task<T> DeserializeAsync(ReadOnlyMemory<byte> data, bool i
210211
migrations = await GetMigrations(subject, writerSchemaJson, latestSchema)
211212
.ConfigureAwait(continueOnCapturedContext: false);
212213
readerSchemaJson = latestSchema;
213-
readerSchema = await GetParsedSchema(latestSchema);
214+
readerSchema = await GetParsedSchema(latestSchema).ConfigureAwait(false);
214215
}
215216
else if (schema != null)
216217
{
@@ -296,7 +297,7 @@ protected override async Task<JsonSchema> ParseSchema(Schema schema)
296297
JsonSchemaResolver utils = new JsonSchemaResolver(
297298
schemaRegistryClient, schema, jsonSchemaGeneratorSettings);
298299

299-
return await utils.GetResolvedSchema();
300+
return await utils.GetResolvedSchema().ConfigureAwait(false);
300301
}
301302
}
302303
}

src/Confluent.SchemaRegistry.Serdes.Json/JsonSchemaResolver.cs

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ public JsonSchemaResolver(ISchemaRegistryClient schemaRegistryClient, Schema sch
7979
public async Task<JsonSchema> GetResolvedSchema(){
8080
if (resolvedJsonSchema == null)
8181
{
82-
await CreateSchemaDictUtil(root);
83-
resolvedJsonSchema = await GetSchemaUtil(root);
82+
await CreateSchemaDictUtil(root).ConfigureAwait(false);
83+
resolvedJsonSchema = await GetSchemaUtil(root).ConfigureAwait(false);
8484
}
8585
return resolvedJsonSchema;
8686
}
@@ -94,8 +94,9 @@ private async Task CreateSchemaDictUtil(Schema root, string referenceName = null
9494
{
9595
foreach (var reference in root.References)
9696
{
97-
Schema refSchemaRes = await schemaRegistryClient.GetRegisteredSchemaAsync(reference.Subject, reference.Version, false);
98-
await CreateSchemaDictUtil(refSchemaRes, reference.Name);
97+
Schema refSchemaRes = await schemaRegistryClient.GetRegisteredSchemaAsync(reference.Subject, reference.Version, false)
98+
.ConfigureAwait(false);
99+
await CreateSchemaDictUtil(refSchemaRes, reference.Name).ConfigureAwait(false);
99100
}
100101
}
101102
}
@@ -107,7 +108,7 @@ private async Task<JsonSchema> GetSchemaUtil(Schema root)
107108
{
108109
if (!dictSchemaNameToJsonSchema.ContainsKey(x.Name))
109110
{
110-
var jsonSchema = await GetSchemaUtil(dictSchemaNameToSchema[x.Name]);
111+
var jsonSchema = await GetSchemaUtil(dictSchemaNameToSchema[x.Name]).ConfigureAwait(false);
111112
dictSchemaNameToJsonSchema.Add(x.Name, jsonSchema);
112113
}
113114
}
@@ -125,7 +126,7 @@ private async Task<JsonSchema> GetSchemaUtil(Schema root)
125126
string rootStr = root.SchemaString;
126127
JObject schema = JObject.Parse(rootStr);
127128
string schemaId = (string)schema["$id"] ?? "";
128-
return await JsonSchema.FromJsonAsync(rootStr, schemaId, factory);
129+
return await JsonSchema.FromJsonAsync(rootStr, schemaId, factory).ConfigureAwait(false);
129130
}
130131

131132
private class CustomJsonReferenceResolver : JsonReferenceResolver
@@ -163,7 +164,7 @@ public override async Task<IJsonReference> ResolveFileReferenceAsync(string file
163164
return schema;
164165
}
165166

166-
return await base.ResolveFileReferenceAsync(filePath, cancellationToken);
167+
return await base.ResolveFileReferenceAsync(filePath, cancellationToken).ConfigureAwait(false);
167168
}
168169

169170
public override async Task<IJsonReference> ResolveUrlReferenceAsync(string url, CancellationToken cancellationToken = default)
@@ -189,7 +190,7 @@ public override async Task<IJsonReference> ResolveUrlReferenceAsync(string url,
189190
}
190191
}
191192

192-
return await base.ResolveUrlReferenceAsync(url, cancellationToken);
193+
return await base.ResolveUrlReferenceAsync(url, cancellationToken).ConfigureAwait(false);
193194
}
194195
}
195196
}

src/Confluent.SchemaRegistry.Serdes.Json/JsonSerializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ protected override async Task<JsonSchema> ParseSchema(Schema schema)
282282
{
283283
JsonSchemaResolver utils = new JsonSchemaResolver(
284284
schemaRegistryClient, schema, jsonSchemaGeneratorSettings);
285-
return await utils.GetResolvedSchema();
285+
return await utils.GetResolvedSchema().ConfigureAwait(false);
286286
}
287287
}
288288
}

src/Confluent.SchemaRegistry.Serdes.Protobuf/ProtobufDeserializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ public override async Task<T> DeserializeAsync(ReadOnlyMemory<byte> data, bool i
136136
{
137137
if (schemaRegistryClient != null)
138138
{
139-
(writerSchema, fdSet) = await GetWriterSchema(subject, writerId);
139+
(writerSchema, fdSet) = await GetWriterSchema(subject, writerId).ConfigureAwait(false);
140140
}
141141

142142
message = parser.ParseFrom(stream);

0 commit comments

Comments
 (0)