Use returned schema id as key (#1587)

jeremy001181 · Matt Howlett · commit cc6123905605 · 2021-05-05T10:33:05.000-05:00
diff --git a/src/Confluent.SchemaRegistry/CachedSchemaRegistryClient.cs b/src/Confluent.SchemaRegistry/CachedSchemaRegistryClient.cs
@@ -302,7 +302,7 @@ public async Task<int> GetSchemaIdAsync(string subject, Schema schema)
                     // throws SchemaRegistryException if schema is not known.
                     var registeredSchema = await restService.LookupSchemaAsync(subject, schema, true).ConfigureAwait(continueOnCapturedContext: false);
                     idBySchema[schema.SchemaString] = registeredSchema.Id;
-                    schemaById[schemaId] = registeredSchema.Schema;
+                    schemaById[registeredSchema.Id] = registeredSchema.Schema;
                     schemaId = registeredSchema.Id;
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,7 @@ public async Task<int> GetSchemaIdAsync(string subject, Schema schema)`
`302`	`302`	`// throws SchemaRegistryException if schema is not known.`
`303`	`303`	`var registeredSchema = await restService.LookupSchemaAsync(subject, schema, true).ConfigureAwait(continueOnCapturedContext: false);`
`304`	`304`	`idBySchema[schema.SchemaString] = registeredSchema.Id;`
`305`		`- schemaById[schemaId] = registeredSchema.Schema;`
	`305`	`+ schemaById[registeredSchema.Id] = registeredSchema.Schema;`
`306`	`306`	`schemaId = registeredSchema.Id;`
`307`	`307`	`}`
`308`	`308`