From 52ab04e185ef4006bd2c29128899fad1e72b3d09 Mon Sep 17 00:00:00 2001 From: Patrik Pfaffenbauer Date: Sat, 16 Nov 2024 12:38:05 +0100 Subject: [PATCH 1/2] add argument null check for oauth params --- src/Confluent.Kafka/ClientExtensions.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Confluent.Kafka/ClientExtensions.cs b/src/Confluent.Kafka/ClientExtensions.cs index 79e685247..ebca60af7 100644 --- a/src/Confluent.Kafka/ClientExtensions.cs +++ b/src/Confluent.Kafka/ClientExtensions.cs @@ -1,4 +1,5 @@ -using System.Collections.Generic; +using System; +using System.Collections.Generic; namespace Confluent.Kafka { @@ -41,6 +42,9 @@ public static class ClientExtensions /// public static void OAuthBearerSetToken(this IClient client, string tokenValue, long lifetimeMs, string principalName, IDictionary extensions = null) { + ArgumentNullException.ThrowIfNull(tokenValue, nameof(tokenValue)); + ArgumentNullException.ThrowIfNull(principalName, nameof(principalName)); + client.Handle.LibrdkafkaHandle.OAuthBearerSetToken(tokenValue, lifetimeMs, principalName, extensions); } From c6d03b5fb13e5e03ba0269a08df1538980c853b8 Mon Sep 17 00:00:00 2001 From: Patrik Pfaffenbauer Date: Sat, 16 Nov 2024 12:40:04 +0100 Subject: [PATCH 2/2] do not set second param, it will be set automatically by the implementation --- src/Confluent.Kafka/ClientExtensions.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Confluent.Kafka/ClientExtensions.cs b/src/Confluent.Kafka/ClientExtensions.cs index ebca60af7..1befc1426 100644 --- a/src/Confluent.Kafka/ClientExtensions.cs +++ b/src/Confluent.Kafka/ClientExtensions.cs @@ -42,8 +42,8 @@ public static class ClientExtensions /// public static void OAuthBearerSetToken(this IClient client, string tokenValue, long lifetimeMs, string principalName, IDictionary extensions = null) { - ArgumentNullException.ThrowIfNull(tokenValue, nameof(tokenValue)); - ArgumentNullException.ThrowIfNull(principalName, nameof(principalName)); + ArgumentNullException.ThrowIfNull(tokenValue); + ArgumentNullException.ThrowIfNull(principalName); client.Handle.LibrdkafkaHandle.OAuthBearerSetToken(tokenValue, lifetimeMs, principalName, extensions); }