Skip to content

Commit 56759d8

Browse files
authored
First cut at JavaScript serdes (#73)
* First cut at serdes * Checkpoint - no errs * Minor cleanup * Add siv * Fix eslint errs * Minor cleanup * Minor cleanup * Fix configs * Fix execute calls * Clean up public, compat levels * Fix test * Incorporate review feedback
1 parent 9563d4a commit 56759d8

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+4636
-218
lines changed

buf.gen.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# Learn more: https://buf.build/docs/configuration/v2/buf-gen-yaml
2+
version: v2
3+
inputs:
4+
- directory: proto
5+
plugins:
6+
- local: protoc-gen-es
7+
opt: target=ts
8+
out: schemaregistry

e2e/schemaregistry/schemaregistry-client.spec.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ describe('SchemaRegistryClient Integration Test', () => {
148148
const getMetadataResponse: SchemaMetadata = await schemaRegistryClient.getSchemaMetadata(testSubject, schemaVersion);
149149
expect(schemaMetadata).toEqual(getMetadataResponse);
150150

151-
const keyValueMetadata: { [key: string]: string } = {
151+
const keyValueMetadata: { [key: string]: string } = {
152152
'owner': 'Bob Jones',
153153
'email': '[email protected]'
154154
}
@@ -163,11 +163,11 @@ describe('SchemaRegistryClient Integration Test', () => {
163163

164164
const version = registerResponse?.version!;
165165

166-
const updateCompatibilityResponse: Compatibility = await schemaRegistryClient.updateCompatibility(testSubject, Compatibility.BackwardTransitive);
167-
expect(updateCompatibilityResponse).toEqual(Compatibility.BackwardTransitive);
166+
const updateCompatibilityResponse: Compatibility = await schemaRegistryClient.updateCompatibility(testSubject, Compatibility.BACKWARD_TRANSITIVE);
167+
expect(updateCompatibilityResponse).toEqual(Compatibility.BACKWARD_TRANSITIVE);
168168

169169
const getCompatibilityResponse: Compatibility = await schemaRegistryClient.getCompatibility(testSubject);
170-
expect(getCompatibilityResponse).toEqual(Compatibility.BackwardTransitive);
170+
expect(getCompatibilityResponse).toEqual(Compatibility.BACKWARD_TRANSITIVE);
171171

172172
const testSubjectCompatibilityResponse: boolean = await schemaRegistryClient.testSubjectCompatibility(testSubject, backwardCompatibleSchemaInfo);
173173
expect(testSubjectCompatibilityResponse).toEqual(true);
@@ -177,21 +177,21 @@ describe('SchemaRegistryClient Integration Test', () => {
177177
});
178178

179179
it('Should update and get default compatibility', async () => {
180-
const updateDefaultCompatibilityResponse: Compatibility = await schemaRegistryClient.updateDefaultCompatibility(Compatibility.Full);
181-
expect(updateDefaultCompatibilityResponse).toEqual(Compatibility.Full);
180+
const updateDefaultCompatibilityResponse: Compatibility = await schemaRegistryClient.updateDefaultCompatibility(Compatibility.FULL);
181+
expect(updateDefaultCompatibilityResponse).toEqual(Compatibility.FULL);
182182

183183
const getDefaultCompatibilityResponse: Compatibility = await schemaRegistryClient.getDefaultCompatibility();
184-
expect(getDefaultCompatibilityResponse).toEqual(Compatibility.Full);
184+
expect(getDefaultCompatibilityResponse).toEqual(Compatibility.FULL);
185185
});
186186

187187
it('Should update and get subject Config', async () => {
188188
const subjectConfigRequest: ServerConfig = {
189-
compatibility: Compatibility.Full,
189+
compatibility: Compatibility.FULL,
190190
normalize: true
191191
};
192192

193193
const subjectConfigResponse: ServerConfig = {
194-
compatibilityLevel: Compatibility.Full,
194+
compatibilityLevel: Compatibility.FULL,
195195
normalize: true
196196
};
197197

@@ -207,12 +207,12 @@ describe('SchemaRegistryClient Integration Test', () => {
207207

208208
it('Should get and set default Config', async () => {
209209
const serverConfigRequest: ServerConfig = {
210-
compatibility: Compatibility.Full,
210+
compatibility: Compatibility.FULL,
211211
normalize: false
212212
};
213213

214214
const serverConfigResponse: ServerConfig = {
215-
compatibilityLevel: Compatibility.Full,
215+
compatibilityLevel: Compatibility.FULL,
216216
normalize: false
217217
};
218218

eslint.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ module.exports = ts.config(
5757
ignores: ["**/*.js"],
5858
rules: {
5959
...config.rules,
60-
"prefer-const": 0,
60+
"prefer-const": "warn",
6161
"@typescript-eslint/no-explicit-any": "warn",
6262
"@typescript-eslint/no-unused-vars": "warn",
6363
}

0 commit comments

Comments
 (0)