Skip to content

Commit 80d552d

Browse files
committed
Add client software name and version
1 parent fa65e50 commit 80d552d

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ Steps to update:
231231

232232
## Releasing
233233

234-
1. Increment the `version` in `package.json` and change README.md to point to the new version.
234+
1. Increment the `version` in `package.json`. Change the version in `client.js` and `README.md`.
235235

236236
1. Run `npm install` to update the `package-lock.json` file.
237237

lib/client.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ var util = require('util');
1414
var Kafka = require('../librdkafka.js');
1515
var assert = require('assert');
1616

17+
const bindingVersion = 'v0.1.7-devel';
18+
1719
var LibrdKafkaError = require('./error');
1820

1921
util.inherits(Client, Emitter);
@@ -50,6 +52,9 @@ function Client(globalConf, SubClientType, topicConf) {
5052
// key is a real conf value
5153
delete globalConf.event_cb;
5254

55+
globalConf['client.software.name'] = 'confluent-kafka-javascript';
56+
globalConf['client.software.version'] = `${bindingVersion}-librdkafka-${Kafka.librdkafkaVersion}`;
57+
5358
this._client = new SubClientType(globalConf, topicConf);
5459

5560
var extractFunctions = function(obj) {

0 commit comments

Comments
 (0)