Skip to content

Commit ca1e002

Browse files
committed
Remove debug-only properties
1 parent 0848e7f commit ca1e002

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

lib/kafkajs/_consumer.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -176,12 +176,6 @@ class Consumer {
176176
*/
177177
#topicPartitionToBatchPayload = new Map();
178178

179-
/**
180-
* TODO: remove this or make it a bit more reliable.
181-
* This is a debug property for this branch.
182-
*/
183-
clientId = null;
184-
185179
/**
186180
* @constructor
187181
* @param {import("../../types/kafkajs").ConsumerConfig} kJSConfig
@@ -390,7 +384,7 @@ class Consumer {
390384
{ code: error.ErrorCodes.ERR__INVALID_ARG });
391385
}
392386
const rdKafkaConfig = kafkaJSToRdKafkaConfig(kjsConfig);
393-
this.clientId = rdKafkaConfig['client.id'];
387+
394388
this.#logger = new DefaultLogger();
395389

396390
/* Consumer specific configuration */
@@ -1190,7 +1184,7 @@ class Consumer {
11901184
*
11911185
* Worker termination acts as a async barrier.
11921186
*/
1193-
async #worker(config, perMessageProcessor, fetcher, id) {
1187+
async #worker(config, perMessageProcessor, fetcher) {
11941188
let nextIdx = -1;
11951189
while (!this.#workerTerminationScheduled) {
11961190
/* Invalidate the message cache if needed */
@@ -1252,7 +1246,7 @@ class Consumer {
12521246
Array(workersToSpawn)
12531247
.fill()
12541248
.map((_, i) =>
1255-
this.#worker(config, perMessageProcessor.bind(this), fetcher.bind(this), i)
1249+
this.#worker(config, perMessageProcessor.bind(this), fetcher.bind(this))
12561250
.catch(e => {
12571251
if (this.#logger)
12581252
this.#logger.error(`Worker ${i} encountered an error: ${e}:${e.stack}`);

0 commit comments

Comments
 (0)