Fix memory leak: ConfImpl within Conf

milindl · milindl · commit fd13955ed1dc · 2024-04-04T15:29:45.000+05:30
diff --git a/src/config.cc b/src/config.cc
@@ -145,7 +145,11 @@ void Conf::stop() {
   }
 }
 
-Conf::~Conf() {}
+Conf::~Conf() {
+  // Delete the rdconf object, since that's what we are internally.
+  RdKafka::Conf *rdconf = static_cast<RdKafka::Conf*>(this);
+  delete rdconf;
+}
 
 NodeKafka::Callbacks::Rebalance* Conf::rebalance_cb() const {
   RdKafka::RebalanceCb *cb = NULL;

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,11 @@ void Conf::stop() {`
`145`	`145`	`}`
`146`	`146`	`}`
`147`	`147`
`148`		`-Conf::~Conf() {}`
	`148`	`+Conf::~Conf() {`
	`149`	`+ // Delete the rdconf object, since that's what we are internally.`
	`150`	`+ RdKafka::Conf rdconf = static_cast<RdKafka::Conf>(this);`
	`151`	`+ delete rdconf;`
	`152`	`+}`
`149`	`153`
`150`	`154`	`NodeKafka::Callbacks::Rebalance* Conf::rebalance_cb() const {`
`151`	`155`	`RdKafka::RebalanceCb *cb = NULL;`