Skip to content

Commit 0653fe0

Browse files
committed
address feedback
1 parent d789244 commit 0653fe0

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

src/confluent_kafka/_model/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class ConsumerGroupTopicPartitions:
6262
List of topic partitions information.
6363
"""
6464

65-
def __init__(self, group_id: str, topic_partitions: Optional[List['cimpl.TopicPartition']] = None) -> None:
65+
def __init__(self, group_id: str, topic_partitions: Optional[List[TopicPartition]] = None) -> None:
6666
self.group_id = group_id
6767
self.topic_partitions = topic_partitions
6868

src/confluent_kafka/_util/conversion_util.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,13 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
from typing import Union, Type, TypeVar
15+
from typing import Union, Type
1616
from enum import Enum
1717

18-
# Generic type for enum conversion
19-
E = TypeVar('E', bound=Enum)
20-
2118

2219
class ConversionUtil:
2320
@staticmethod
24-
def convert_to_enum(val: Union[str, int, E], enum_clazz: Type[E]) -> E:
21+
def convert_to_enum(val: Union[str, int, Enum], enum_clazz: Type[Enum]) -> Enum:
2522
if type(enum_clazz) is not type(Enum):
2623
raise TypeError("'enum_clazz' must be of type Enum")
2724

src/confluent_kafka/admin/_cluster.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def __init__(self, controller: Node, nodes: List[Node], cluster_id: Optional[str
4141
self.cluster_id = cluster_id
4242
self.controller = controller
4343
self.nodes = nodes
44-
self.authorized_operations: Optional[List[AclOperation]] = None
44+
self.authorized_operations = None
4545
if authorized_operations:
4646
self.authorized_operations = []
4747
for op in authorized_operations:

0 commit comments

Comments
 (0)