Skip to content

Commit 57608ce

Browse files
authored
Ensure cached schema matches input (#1922)
1 parent 4a3694b commit 57608ce

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/confluent_kafka/schema_registry/schema_registry_client.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@ def set_schema(self, subject: str, schema_id: int, schema: 'Schema'):
473473
self.schema_id_index[subject][schema_id] = schema
474474
self.schema_index[subject][schema] = schema_id
475475

476-
def set_registered_schema(self, registered_schema: 'RegisteredSchema'):
476+
def set_registered_schema(self, schema: 'Schema', registered_schema: 'RegisteredSchema'):
477477
"""
478478
Add a RegisteredSchema to the cache.
479479
@@ -484,7 +484,6 @@ def set_registered_schema(self, registered_schema: 'RegisteredSchema'):
484484
subject = registered_schema.subject
485485
schema_id = registered_schema.schema_id
486486
version = registered_schema.version
487-
schema = registered_schema.schema
488487
with self.lock:
489488
self.schema_id_index[subject][schema_id] = schema
490489
self.schema_index[subject][schema] = schema_id
@@ -786,7 +785,7 @@ def register_schema_full_response(
786785

787786
registered_schema = RegisteredSchema.from_dict(response)
788787

789-
self._cache.set_schema(subject_name, registered_schema.schema_id, registered_schema.schema)
788+
self._cache.set_schema(subject_name, registered_schema.schema_id, schema)
790789

791790
return registered_schema
792791

@@ -866,7 +865,7 @@ def lookup_schema(
866865

867866
registered_schema = RegisteredSchema.from_dict(response)
868867

869-
self._cache.set_registered_schema(registered_schema)
868+
self._cache.set_registered_schema(schema, registered_schema)
870869

871870
return registered_schema
872871

@@ -1025,7 +1024,7 @@ def get_version(
10251024

10261025
registered_schema = RegisteredSchema.from_dict(response)
10271026

1028-
self._cache.set_registered_schema(registered_schema)
1027+
self._cache.set_registered_schema(registered_schema.schema, registered_schema)
10291028

10301029
return registered_schema
10311030

0 commit comments

Comments
 (0)