Skip to content

Commit 5c34474

Browse files
committed
Adress review comments + add DEVELOPER.md
1 parent 801df15 commit 5c34474

File tree

2 files changed

+50
-53
lines changed

2 files changed

+50
-53
lines changed

DEVELOPER.md

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
# Developer Notes
2+
3+
This document provides information useful to developers working on confluent-kafka-python.
4+
5+
6+
## Build
7+
8+
$ python setup.py build
9+
10+
If librdkafka is installed in a non-standard location provide the include and library directories with:
11+
12+
$ C_INCLUDE_PATH=/path/to/include LIBRARY_PATH=/path/to/lib python setup.py ...
13+
14+
15+
## Generate Documentation
16+
17+
Install sphinx and sphinx_rtd_theme packages:
18+
19+
$ pip install sphinx sphinx_rtd_theme
20+
21+
Build HTML docs:
22+
23+
$ make docs
24+
25+
or:
26+
27+
$ python setup.py build_sphinx
28+
29+
Documentation will be generated in `docs/_build/`.
30+
31+
32+
## Tests
33+
34+
35+
See [tests/README.md](tests/README.md) for instructions on how to run tests.
36+

README.md

Lines changed: 14 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
Confluent's Kafka Python Client
2-
===============================
1+
Confluent's Python Client for Apache Kafka<sup>TM</sup>
2+
=======================================================
33

4-
**confluent-kafka-python** provides high-level Producer, Consumer and AdminClient classes compatible with all
4+
**confluent-kafka-python** provides a high-level Producer, Consumer and AdminClient compatible with all
55
[Apache Kafka<sup>TM<sup>](http://kafka.apache.org/) brokers >= v0.8, [Confluent Cloud](https://www.confluent.io/confluent-cloud/)
66
and the [Confluent Platform](https://www.confluent.io/product/compare/). The client is:
77

@@ -23,8 +23,8 @@ See the [API documentation](http://docs.confluent.io/current/clients/confluent-k
2323
Usage
2424
=====
2525

26-
Below are some examples of typical usage. For more examples, including [how to configure](examples/confluent_cloud.py) the python client for use with
27-
[Confluent Cloud](https://www.confluent.io/confluent-cloud/), see the [examples](examples) directory.
26+
Below are some examples of typical usage. For more examples, see the [examples](examples) directory or the [confluentinc/examples](https://github.com/confluentinc/examples/tree/master/clients/cloud/python) github repo for a [Confluent Cloud](https://www.confluent.io/confluent-cloud/) example.
27+
2828

2929
**Producer**
3030

@@ -205,21 +205,22 @@ The `Producer`, `Consumer` and `AdminClient` are all thread safe.
205205
Install
206206
=======
207207

208+
**Install self-contained binary wheels**
209+
210+
$ pip install confluent-kafka
211+
208212
**NOTE:** The pre-built Linux wheels do NOT contain SASL Kerberos/GSSAPI support.
209213
If you need SASL Kerberos/GSSAPI support you must install librdkafka and
210214
its dependencies using the repositories below and then build
211215
confluent-kafka using the command in the "Install from
212216
source from PyPi" section below.
213217

214-
**Install self-contained binary wheels for OSX and Linux from PyPi**
215-
216-
$ pip install confluent-kafka
217-
218218
**Install AvroProducer and AvroConsumer**
219219

220220
$ pip install "confluent-kafka[avro]"
221221

222-
**Install from source from PyPi** *(requires librdkafka + dependencies to be installed separately)*:
222+
**Install from source from PyPi**
223+
*(requires librdkafka + dependencies to be installed separately)*:
223224

224225
$ pip install --no-binary :all: confluent-kafka
225226

@@ -268,47 +269,7 @@ http://docs.confluent.io/current/installation.html#rpm-packages-via-yum
268269
* On **OSX**, use **homebrew** and do `brew install librdkafka`
269270

270271

271-
Build
272-
=====
273-
274-
$ python setup.py build
275-
276-
If librdkafka is installed in a non-standard location provide the include and library directories with:
277-
278-
$ C_INCLUDE_PATH=/path/to/include LIBRARY_PATH=/path/to/lib python setup.py ...
279-
280-
281-
Tests
282-
=====
283-
284-
285-
**Run unit-tests**
286-
287-
In order to run full test suite, simply execute:
288-
289-
$ tox -r
290-
291-
**NOTE**: Requires `tox` (please install with `pip install tox`), several supported versions of Python on your path, and `librdkafka` [installed](tools/bootstrap-librdkafka.sh) into `tmp-build`.
292-
293-
294-
**Integration tests**
295-
296-
See [tests/README.md](tests/README.md) for instructions on how to run integration tests.
297-
298-
299-
300-
Generate Documentation
301-
======================
302-
Install sphinx and sphinx_rtd_theme packages:
303-
304-
$ pip install sphinx sphinx_rtd_theme
305-
306-
Build HTML docs:
307-
308-
$ make docs
309-
310-
or:
311-
312-
$ python setup.py build_sphinx
272+
Developer Notes
273+
===============
313274

314-
Documentation will be generated in `docs/_build/`.
275+
Instructions on building and testing confluent-kafka-python can be found [here](DEVELOPER.md).

0 commit comments

Comments
 (0)